linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Karim Manaouil <kmanaouilinux@gmail.com>
To: npiggin@gmail.com
Cc: david@redhat.com, akpm@linux-foundation.org,
	mike.kravetz@oracle.com, linux-mm@kvack.org,
	kmanaouilinux@gmail.com
Subject: mm: Question: pte SMP data race in do_anomyous_page()?
Date: Thu, 25 May 2023 11:06:40 +0100	[thread overview]
Message-ID: <ZG8zMF6jMWdiBpP+@ed.ac.uk> (raw)

Hi,

In do_anonymous_page(), a new page is allocated and zeroed, and the 
corresponding page struct is initialised (setting flags PageUptodate,
PageSwapBacked, etc. and initialising the various counters).

Then, set_pte_at() is called directly without calling smp_wmb() to make
the updates above visible on other CPUs.

This could race with a page table walker. The walker can read the new pte
and try to access the page struct or the page content before the changes
above were made visible.

The reason I thought about this is because of the comment in
pmd_install(), which describes exactly the same situation, so I
wondered why the same thing is not considered in do_anonymous_page().

I might probably be missing something, but I would love to hear your
comments.

Cheers
Karim




             reply	other threads:[~2023-05-25 10:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 10:06 Karim Manaouil [this message]
2023-05-25 12:55 ` David Hildenbrand
     [not found]   ` <ZHB2wyNtHn6qRWZB@ed.ac.uk>
2023-05-26  9:12     ` David Hildenbrand
2023-05-31  4:55       ` Alistair Popple
2023-05-31  7:27         ` David Hildenbrand
2023-05-31 12:54           ` Alistair Popple
2023-05-25 13:53 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZG8zMF6jMWdiBpP+@ed.ac.uk \
    --to=kmanaouilinux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox