From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D565C77B7A for ; Thu, 25 May 2023 07:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE02900002; Thu, 25 May 2023 03:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38F9E6B0075; Thu, 25 May 2023 03:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2569C900002; Thu, 25 May 2023 03:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 11DD86B0074 for ; Thu, 25 May 2023 03:59:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CAE071203B3 for ; Thu, 25 May 2023 07:59:46 +0000 (UTC) X-FDA: 80828028372.01.5F1605D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id A684B40006 for ; Thu, 25 May 2023 07:59:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=V58wO3Bz; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+2513424fa4087fe74412+7214+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2513424fa4087fe74412+7214+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685001584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1SbotI5SOBhG7bXBLx5uW2S/thCuqPvVS6nzOwu9CA8=; b=cwZVAJZJvvo5+RTud21PQnIsGcPqcmpj9Y6ovDDZVETAOMsdsLCKXDtxIYq6UJnc91HlGA Fijrw0m9zquOXujQbZ6HH6YM2gohp1fXRM1O9VkHg/1o2XI1oTSCFuH01oW72uYQHzHw0D MoGRgJxTsIzFz7a8efsksg3TN/l3RbA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=V58wO3Bz; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+2513424fa4087fe74412+7214+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2513424fa4087fe74412+7214+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685001584; a=rsa-sha256; cv=none; b=xXBKk+a9N2Kfk1FuT3ZbAi4lM043Na5FySkfJtGkX2AHGxsIcS8Jtf+QJh/lL6Uqi9sFDn i0DUlkwQqpi3y6r+H/eFYONOCC082in1p5EEjLfOluwIC14yGTq7ejp4OBhQLJ9lFCBmgB 77r/v3gauAxKnZJ3fGNPhPXNM3qL6UU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1SbotI5SOBhG7bXBLx5uW2S/thCuqPvVS6nzOwu9CA8=; b=V58wO3BzmmE0SuFDyj/dG3wtLK lAzsAvB3ZVtK85AeH07/CJcxdL6YrVPVNDBjp1gDEQPt3y4PFxy1zANuqX7eVYeIgd3P7ogmbXOTU da9+kR0/TlSsh1y3pAg8cJlsO45ZGPvvuTYFq/fNI4L86nVhMdF9l0CdKYvln7GJza2VN0yD6cUMZ 9AGBExT5R92fPahMcA7LeZjMrK7dkBLryYUAAfcvK7uRiSTSxKle8hlE9ag/8t3Jjq9Yn1IOJUZuo uX3hxlvo7360UC0O1DFIK/1Wbl7Y+nHItalF92A3t01qoCyYcTe7+nOpiFXaZa42gRD6g3h1sC3BR Yy6h2YmA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q25sp-00Fu4N-2E; Thu, 25 May 2023 07:59:39 +0000 Date: Thu, 25 May 2023 00:59:39 -0700 From: Christoph Hellwig To: Dave Chinner Cc: Uladzislau Rezki , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , linux-xfs@vger.kernel.org Subject: Re: [PATCH 0/9] Mitigate a vmap lock contention Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: A684B40006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gpbwkrzfghioyi55io3oeju6zpnaddxx X-HE-Tag: 1685001583-749641 X-HE-Meta: U2FsdGVkX19QDu1PykQkOHMrn/XQY+2asylBq7EY5pcoOGri1QrFatMLCMJAtwIi3ZpSifz1ZTWp3tCqagaBkk2E3nlkYOvniGfJGcAcBZXLObncvS/7sn/Dgn0gFnbgdzVPGcz51M/oEiqTxSZeppm3zivqXUt83KKARo1MjKPCjFXYB0l8liVFDdfR6GkpOIqJu43Pu8+O41hpSuMLYxIulnouJ8CKR8Wto5pzMSidIz13cAqMuKZZP+eFxYpSRtrCv9ItgiHhMnF793WnpbKG8w/rkZRWfCWuvURt1LVkb+P/jHO9ixVJY1mdfeRGG833RbjvxI13dPFBo9as5KDrmWC0BMBK0H8QcqVv47jI/yH17bw+oYkyAysKJPiNMAgG4FHiEs6DMrzuyXltrg6iLo1U5H2jE/JDdKHN7JphABVjF3J9QULeQEjwpqAHjNj5sudQl741vYXFjAEgWzgKxxlKcOA+v6DjH9bENR6DjfXOO27J+ZWRNK6A1RtXs3JkNrY4I++CYU2nSyvCnmL3Mw7Xc3jabl1FGTJcoB77yjrCqEmuNzo9NkRbvKFe7DkdthtiUgr+eaWvKGGKAKirZ7xq4bf3+0qOPB8lB41LjfnDDztqqw+LwLhlRtmVRjdY2l/WtKMFy3vWUBbCaaIdIk6yw37WJ2X44KtSDiZH+MFwIXKKTJJsz6Z273HAJlosYYv1wJKMcKaVWIP2Xc7DcoVR6TS0ELHbNGrpJs2Hg0jGFLSzKEk3OvTIKuCrphKAgjkNarEV3Z0EqxcTdm3tEV1bqKgyg6r3DAkV2H1DXIE5DgzJOjjfCVt2gRPKnrlTns1e4/sCMCIMRwp3SlXKaW7+pqM6VUVkvf8SBVeJoh8ZB3jjTmOvYXbKdcIggDQ4cV6YBzqsS/IEsZ/FgqW2jsFnqsRGD5DiV0pnxtcKW2zrsQozywb9/cSz0upDc7ZOB8Zd3rciSmtfgvx uFm2J7e5 djfdvTJPkmh3q4nqr6k5xlfs16OP12ctNx4Tf1n3z2eFP7DEtM7Bc/579kn9Tu8sVDibt4Ttvbj7M+/1iMrEDwEHKwbD0kjvirreOehgqzTkT05IPRZkvImdIz6fJTlKu3SfM4xqaTISPw4KJnD1wTDSo4cmr2Nh2Yct1nMTkL84RomSp+VOhcmB9xLXpYVuA+cofsTvYtwBPLenoXYMUftHTXsZh6V5ktlhJxFMXx9ft3WVrNhDjj6057Zu/TEImXyK2ilqVziYy7UBG9jq3V/WEOD2nCoMn5Cvjnrbdkn1UiLHGOP7vnSzMMR4aWBaCeEssojp7+2wyYWlMfxUjDTtqRQ1rMBIHuYoxEzQl5fA9SG3jjxDUcDiHx9D+q6LprMJ10jywH4Cg0aoDGT8cwJ7tuqGA+lNvZ7IuTHhTTd8juwT16MVr+CanzRDZ1DMEmja7hfzKkhZPDWM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 07:56:56AM +1000, Dave Chinner wrote: > > It is up to community to decide. As i see XFS needs it also. Maybe in > > the future it can be removed(who knows). If the vmalloc code itself can > > deliver such performance as vm_map* APIs. > > vm_map* APIs cannot be replaced with vmalloc, they cover a very > different use case. i.e. vmalloc allocates mapped memory, > vm_map_ram() maps allocated memory.... > > > vm_map_ram() and friends interface was added because of vmalloc drawbacks. > > No. vm_map*() were scalability improvements added in 2009 to replace > on vmap() and vunmap() to avoid global lock contention in the vmap > allocator that XFS had been working around for years with it's own > internal vmap cache.... All of that is true. At the same time XFS could very much switch to vmalloc for !XBF_UNMAPPED && size > PAGE_SIZE buffers IFF that provided an advantage. The need for vmap and then vm_map_* initially came from the fact that we were using the page cache to back the xfs_buf (or page_buf back then). With your work on getting rid of the pagecache usage we could just use vmalloc now if we wanted to and it improves performance. Or at some point we could even look into just using large folios for that with the infrastructure for that improving a lot (but I suspect we're not quite there yet). But ther are other uses of vm_map_* that can't do that, and they will benefit from the additional scalability as well even IFF just using vmalloc was fine for XFS now (I don't know, I haven't actually looked into it).