From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BA4C77B7E for ; Thu, 25 May 2023 04:05:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2376B0075; Thu, 25 May 2023 00:05:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B61D06B0078; Thu, 25 May 2023 00:05:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A78E9900003; Thu, 25 May 2023 00:05:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96F4E6B0075 for ; Thu, 25 May 2023 00:05:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67667A0A9B for ; Thu, 25 May 2023 04:05:13 +0000 (UTC) X-FDA: 80827437306.12.874CFD1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id B3B6A100018 for ; Thu, 25 May 2023 04:05:11 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Vpkjy/zP"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684987511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Rcg59tq5Dl+6L+r8l6uwmuQm/aS0R/EBEonRbKOuco=; b=QA1+I/rzXYxZMnNm+3QD4rIwt5vIajfQ/u0gbYONBewgT8XalC4+A9phxgGyQk8T4FixmG rBDrnjCUkgfu1InhV67qvTF6WJV6xduIE0lEyC63ODeufvxQHXTRF2UtdSGffUe0WSwqda pR6lMOHrYpsjfHD0HJCrq0gtWAhQN0o= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Vpkjy/zP"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684987511; a=rsa-sha256; cv=none; b=yvJvgyunmomEmk4reDFelkj+XFzX9GFhkNk2heilKOC0ls1xEGdmldaNvOFKyAeTfU9gIR lM3atTPmKSdm8DA5/iWJxKqK2ZiNbvgYzILRdTRFS3Xj/tcechUC9ugJz5ecTJQymcTqnN tp0sj6wHjbPjoZJxgGA6peiKUG9LdeY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Rcg59tq5Dl+6L+r8l6uwmuQm/aS0R/EBEonRbKOuco=; b=Vpkjy/zPqLAbxZf6ITNl+lGwjS nZwEanDG+mDgOewsGVfDM/uPyMY/vLDHgN9HUb32EbjT9dm9j8GWHEFIEcAD3KJ2S2APD70rT1aYq PWrA4DCdUJvyxk1XlvD5OJzRNU0z8XPOni5p290SZUGrL7h5SLcUG6a612QRkvOLbPzxkHVECZJoi 0jvFoo5OToVmjcTFuYzEG+Mfxmc7DGXTQs42v3hE2g2R0FTObPuNWgBYkdIvpgnjcZhq/5BdgcKX+ nGl5XTusfjuyS7BYl5GycouUlMSaW4ctAmtjq0dYdVQpAwD/mpB+4evqKKLpwU7OeEGOlX7nCHImW amBlZbHA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q22Ds-00BpM4-4Y; Thu, 25 May 2023 04:05:08 +0000 Date: Thu, 25 May 2023 05:05:08 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 09/36] arm64: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-10-willy@infradead.org> <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B3B6A100018 X-Stat-Signature: tncp34iqma4rmximex6d9fihicy9moa4 X-Rspam-User: X-HE-Tag: 1684987511-547458 X-HE-Meta: U2FsdGVkX18WNU4vFIBfyIV8aENf4tXfNkzr0Nmv7kNrSq2lb1BuSEvnlAjZi18kbd6+kuVda9MgSesOXpFK/KkPfaq77W/zh/7wQgw8nWhNBXuz6F/hV3LOhy+xzc6EgqMYqR1sdPoFdJ9X3Ps54O3YTl95WhlSKOaXdUtTlTs4Ls7fuMb4IYKOJ5ryzwBmab2OixBV3NZoH82KtadgLh2MLuQM254M66yF7KK0k6qIaeB6R4z0+42aNM4sGnSLfo20LyTOp8NkWbKoW2dNl1GsVrHg5wnhWvI6b9PFIW+IkIU6Ionh22t+hiB5xvBXIrCemF7VI2691mSH+hd0R+W+9BOpHlmED6v5JICLpbpFZ+hgoYqPcYeD9Gi4iKQJRZ/sd4M5Xx6Iy3iTciFRayyGqyXpNEoduOtdyEGSNHflpKe3XaiOwB7kgdvH2BVhZBYZvx+UrrNXZEyTeyLYGE9BVQ6Ps0AcotAjX8JgD7OQcIEvfyEdRC6TUCoSdQnrhRF2K/ZodW6rMwQ+jp2fMDPoxhBIAaWM2PAWCgEyfgr5B7wiaBrwAyBDiisQhOZO1QFnCExOLCqV5U36eLwYBjnqzMsX8CGU5yTXjMd9oPvlf5Bsvzt5I/cDje3HYpoes5BI364WHxY8/7R82CuYOC3A3lSe8n1RrDS1udURCqvvn9o9dKh/XtsOwFwij1bDWvuoZOIm28Iu+p8OkzLN7GOFMW14YvgFyJYIh8XseGuTz8A/ZUoN0cH192ix5/hw0YTHlDd5m/sgP0tie4kAI9jozZ3F1eteB50gpWSrgXr4AGaFqWxxFU3esgZu5PSVV2AmQC9iVOllPVCuIxcSAzZLKfuHsujiddD+Ghn4/V4gW8p+gWmgp0KZxxRMeDD565kdzsa6t97e2SSP+rbJg/A0mVxC7D+gy44XgZLa3/9j5DEJKSvhunPt4Yhnwt87W0p5qZYewwAfH30kOC8 orQi+1Ke TzOdgwy0mlZGzUN2a4ggG8Fby5hKR1SIGnVDxekXWDI0CrX9jPm3b0RGPWRMmQuGPQ4zIXvy1q3K91sdcpdqMJVqgIHP52LHXvYczrH02A74Pht3xy22DAlnqlobKJgEKjvn8iJyg6FN/e/k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 09:05:35AM +0530, Anshuman Khandual wrote: > > @@ -127,6 +127,8 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *, > > */ > > #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 > > extern void flush_dcache_page(struct page *); > > +void flush_dcache_folio(struct folio *); > > This is giving a checkpatch.pl warning > > WARNING: function definition argument 'struct folio *' should also have an identifier name > #36: FILE: arch/arm64/include/asm/cacheflush.h:130: > +void flush_dcache_folio(struct folio *); Yes, but checkpatch is *stupid*. Don't just follow tools blindly. How is naming the parameter here helping anyone?