From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A219DC77B73 for ; Wed, 24 May 2023 22:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAE8A900002; Wed, 24 May 2023 18:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5EE16B0075; Wed, 24 May 2023 18:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D8D900002; Wed, 24 May 2023 18:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B5BD46B0074 for ; Wed, 24 May 2023 18:44:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7E9C11C785C for ; Wed, 24 May 2023 22:44:21 +0000 (UTC) X-FDA: 80826628722.19.505F505 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 4B1AE4000C for ; Wed, 24 May 2023 22:44:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A78oxpDv; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684968259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JPoOjhwLXPec5N/XBPFEXrHrpaUF5lpSnwsns99mvPk=; b=NaLNduUyWAG61o3oSzGfpjbbkr0szn0aaI+weljY0rtWTcTxi2RvlS9PDGVnhVgST5rwXg uzxhN0GURd08w4JCwWiM7UDzdSBQ3bOgk9/HrRRsseq/gPHwagtAH4n09mZLilImEYPWoj 5GgEzDgy2or1YWc9rUyt2ijFpgwd3xE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A78oxpDv; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684968259; a=rsa-sha256; cv=none; b=ny57P+HRe3O77Hrx3fbJSuQOvKWAC1ccepaH8/Pi/tmIXKiWpJyRe8i51KxDY4mtrO1mkz jp/kYHYT/lj6iD5QUEMzLzHMbbsjzED2vyVcTYaMhnlKefTlxdiWEnKOKgHRsWemCuMYqs HPNZujtdnYylnUESq0pkgWOljADHUTs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684968258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JPoOjhwLXPec5N/XBPFEXrHrpaUF5lpSnwsns99mvPk=; b=A78oxpDvBz35PmQqXnNcebKJR1C71cPm3UWU+yD73X9dcgxx0eFAn1/5mb+ExbnY5sDP3g Bn7OLUvCzUTYsG/DDubvTZq/LiYr8wi6T0zD/69V+qFn3ewSU237BWIK8Xe5PCYRtLTk7I iqzTq9YgSzNSbDiDvcCJopm3HPfQSOw= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-dADvPuTlP0KCXlI9-xQCcQ-1; Wed, 24 May 2023 18:44:15 -0400 X-MC-Unique: dADvPuTlP0KCXlI9-xQCcQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3f386bb966cso2529281cf.1 for ; Wed, 24 May 2023 15:44:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684968255; x=1687560255; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JPoOjhwLXPec5N/XBPFEXrHrpaUF5lpSnwsns99mvPk=; b=fzQJDc8IFSbE0r6N1gR9NMqwCfadJ+wKZJJ9hT2ICXcV2go+No/U95/mQfKJ1To8hB kR7Rzau/ukyVlidppTsg9a+OpNrdwMj794Bq6gVuwZ/m+nwimae64Fu82qjMlScLkkeI 7+jSBThl+4KZs6Rt0/mYvzcsm53niIVuaHBSalFpo7rT0HVb+uuscEn/T1ebuxnJD0hZ kAo2SgcK6raKHC1GRYYVsYFZgGLEmghi+Z6QmlxIQ+6bwMItBzlSHNJSnitfQDQ3pXBv n4VK9Ahz36Vrk8AGD9sfZCi5PF2SGQxsLOY+Dbyba9gT3cOsz0HqdVSOzeeVbWshcsKp pc5g== X-Gm-Message-State: AC+VfDzoF4ZdU9ibAIDeyPjI6ni/IdJRkMHVj2t3MrrbTK8nBnxFND88 agSyChS/FUWn6EXQifsLaRhq4QhOEZzKWx+ZFtH6L1x3dujdU7oGEWwAmypUv1ETCosRbKjlF+o MPdEvfKUtfRI= X-Received: by 2002:a05:620a:2b92:b0:75b:3a99:241c with SMTP id dz18-20020a05620a2b9200b0075b3a99241cmr3995845qkb.7.1684968254996; Wed, 24 May 2023 15:44:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DDwCvPTbPVkW+3OaRTKABEOPbZ8FcFX9lEyuaGjGgRdBSzhRkXTDsVeO4Keydw3iWkAeX+Q== X-Received: by 2002:a05:620a:2b92:b0:75b:3a99:241c with SMTP id dz18-20020a05620a2b9200b0075b3a99241cmr3995817qkb.7.1684968254738; Wed, 24 May 2023 15:44:14 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-62-70-24-86-62.dsl.bell.ca. [70.24.86.62]) by smtp.gmail.com with ESMTPSA id m5-20020ae9e005000000b007578b6d060bsm3573906qkk.126.2023.05.24.15.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 15:44:14 -0700 (PDT) Date: Wed, 24 May 2023 18:44:11 -0400 From: Peter Xu To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 15/31] mm/userfaultfd: allow pte_offset_map_lock() to fail Message-ID: References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> <49d92b15-3442-4e84-39bd-c77c316bf844@google.com> MIME-Version: 1.0 In-Reply-To: <49d92b15-3442-4e84-39bd-c77c316bf844@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4B1AE4000C X-Rspam-User: X-Stat-Signature: 6gosp5bnb4fyb1y3ug9g5uzogswap4hj X-Rspamd-Server: rspam01 X-HE-Tag: 1684968259-529971 X-HE-Meta: U2FsdGVkX1+od6A99ImuQDKxINosl2lNCE9w4PD6tx6rUE26hHDTC21wbyepW0HLqW894DiBU04uhPuE+NLaatQ+vs9Mto7aR35v8fLlkbZp/H3aGurahaEslTKlJKPYyQY6eq8qMaQKSsLfOPcb4f0S1WZ9B2pKcBYtjbT+YEY5AoHjpx53UbPU45cL0kA0XSnrYhF16xEGFwmY1TO8XoGyyDeWL1th9sFGI50e7etFgBJKQlGfPaQUE3aD/2kfvSl36r8Q05zEHBf9ByGg/CB2GWEE5fN/VcqtJ+6LR5wPHFxYkVR64gwxhPz7AwEu4O6OU+qHc80hxdrGeMIeilf9awkOLtsVAXBO0WesTZKT7mP5srDMUHoYGT7nOQWPx4HhVgF7yGTy4eGVJxloibE4L7Bufq0gzXeiXo9KKeHLr314QChuxBEz2dfVPaq+QCGmrId1Mb+P31PSrY1F9hqGpYfL+dGKQmyT2fo/lsZ4sI9NdKSaYe4GrNRfVrD8e1vmxs6wOG+mDnsj5aDfbTIFW6u83Cr7ORjfyw2y2Y2aDdYmPpH6lPLecr5DNBTvR8HnJkQ5UACF/3p+F5IdXp/DRoujcQ+yJDNYDbMsbXX8uR20NiTuYYr97AzwH5mTNuiP6s6Nrfix/WobluJcK6f3MuhLHZAaXHYPij4IK0dngVRRx1zGV60w/lapO3QSJQ0pRRUqJK2V4TQ7TVNOSneCVkQxiloCkmCR95N2wRkvymwJ9rJI2qXFL0R8F0HQ03rdEQG2A+9cDKj0VGqpzRRTN1l8iZjWw/vGuXtPA0Q4EZY1i5ylfhCqsCks+hLFnNEl1saxWSI4EitfpROq7ZxXWaNMmUTo5s0bDXo//42CcuCKalr1+6gLQSCeqawJDnPm9rAwPQ3dC/NfnSTeej351FtA+Ts4trDKiNhIa91sg6+QcM/sxjkUzkDc2HXO2BdLtMp6iddm0+o39Dv 5ru6pPbz 4EwQN76JVIh86RT1ZOVJ+AYurMnpTX6oWN6yiAQEp4ksG6gyt29SLHM4tUviRKky+Ea+axc/bcj1IZbYDKVcGW5bceNTGP0AFujpnmsYwraBbD1FH8sNjw+aQd9SQMl4xRy6v087gNmS2lQ6vV3hK7RmiRRuCFmzaw9ehgYD5B7wbGgMSoHkpT4yPLqySxd+grzUkHhy+ztkFXPjS0JRx0RSc/E2B9s51sI2DGBAa3HqVswnm1yVThewvhWuVM1FZl97kjdNoxth1K+FJFiNQqXXXrGCdtO5dcIIReqk9NDarGxVb6g8l3K5fYPo+4MtfLyx8V5RfezJCbvIWrU9fcwtVAR2Weip/In0/Ua31VnmPiFYaeG8IWEmP0F8Y9XzZj5bU2K4ekGVI+zwSXKhjvRGP6EK9K1Dpo54hTlsgmpERLVv3jyEJB4saXgRRkQnXLaJoCi4Zsqm5IkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Hugh, On Sun, May 21, 2023 at 10:07:35PM -0700, Hugh Dickins wrote: > mfill_atomic_install_pte() and mfill_atomic_pte_zeropage() treat > failed pte_offset_map_lock() as -EFAULT, with no attempt to retry. Could you help explain why it should be -EFAULT, not -EAGAIN or -EEXIST? IIUC right now if pte existed we have -EEXIST returned as part of the userfault ABI, no matter whether it's pte or thp. IMHO it may boil down to my limited knowledge on how pte_offset_map_lock() is used after this part 2 series, and I assume the core changes will be in your 3rd series (besides this one and the arch one). Please shed some light if there's quick answers (IIUC this is for speeding up collapsing shmem thps, but still no much clue here), or I can also wait for reading the 3rd part if it'll come soon in any form. Thanks, -- Peter Xu