From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAD4C7EE2C for ; Wed, 24 May 2023 22:08:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29845900003; Wed, 24 May 2023 18:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22051900002; Wed, 24 May 2023 18:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EB58900003; Wed, 24 May 2023 18:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EAA81900002 for ; Wed, 24 May 2023 18:08:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BE8A61408EC for ; Wed, 24 May 2023 22:08:10 +0000 (UTC) X-FDA: 80826537540.24.30674B3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 0D2381C0014 for ; Wed, 24 May 2023 22:08:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c9zMLElg; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf18.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684966088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/JToQHdkxgbDyu1xaJQwVWxSodxYnloGI/u4TaisGIw=; b=eVlDdYXVEegVt8+NJ2BfAMEoZf5/5sxvl7QxM8T5saRCfYBHhWMtSyujPKSCl94TunVoEy 5NyI8c0z4LwYbt8HvtRHjtfhEu+xTuCGAr+sG7VzKPmQezHyLHbrwMF0DY0k1sU/quiRyQ 3e8c12HycjWq/2P1vAJ/Z+WXiu9bqlM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c9zMLElg; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf18.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684966088; a=rsa-sha256; cv=none; b=aZ8Q5OKkjiLB1zh6TUIB5l1vPZpIz6nXo544dCy7gZeKOTUn5j0qJ7Ut3Hb4L+tfcW6u4F 5vqvxDz8fCJDOV76Gc9GI50R8hKWUqsBNQ93woauPWs6+sCarvfp9Abp5IrpFqMX3BV5lL iTRoG5rHNAIah/R9zXm28Z5aUjD/pZs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=/JToQHdkxgbDyu1xaJQwVWxSodxYnloGI/u4TaisGIw=; b=c9zMLElgRCGRia6SL8BuLKzB7B Mq+Qz2ZTPnhGMkg0GqFoMp8NImins+kYcs+UlKaemxvTM9avgqVIft1UaVmAM9iPgY6bsqW2N9UcD GitGvwsNHQxiFG9f8hEtykExK9rUUHyTd6y3HFt/7lsJPwgsvGCa2SPXxLfuONcbljL0O7kn/HK/a ujZGfNbX5tv7OqaDvhqDQ3rikEiwcj6GKTPRRcHz0XKhM/FS9p0K7wsuioA/p6BK5z/Kjw8r8SKhY NE6gzr+49AfB4wU6dqYtEyGR/xflH8FHzNBLCEoBJwdnh+rP+Y15Z/R63lCDLuDRK2sjFFjjui8Ga jgjZVgVw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1weA-00Em4l-06; Wed, 24 May 2023 22:07:54 +0000 Date: Wed, 24 May 2023 15:07:53 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, lennart@poettering.net, gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, lucas.demarchi@intel.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection Message-ID: References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 0D2381C0014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5an5dfxm14swdu59k6s95ybsz58f75j6 X-HE-Tag: 1684966087-621428 X-HE-Meta: U2FsdGVkX18jmoCIyPdPzJ/C2sIeMPZs0ubi/RYqdoU5Fgmvk0/DrUFMeu/3S+SSP/2VfowqHQzlL7yH6QyLb6hUKOlN2LzIeOeoNxpmnOY1QURhNh9Vy8ACQQMpKdEDU2rke54Eei7izK+nQe5Ajwa4Xz38qphpfeu3Hex1sDQizSAMrLNvth1P+e/zUd22TRUln0Wuom8gTTrVpStpfxUKCJOm1iMCc6kyTmKd5j60L1kkVQdysD2SQkhNO88iYncTCIyvZqx3wzwHIa5Uu6+PuT+R8Z6bPzFkJO24EJ6krwcJ7MDeBB7g7s8VrVqIOfhxNZU/ni/R6u5NZADL0/RP2y7AN2U10BFX0kfqP3y1LmsgfjkFoaqz6LvySBqbkty+tY4dLx1ykzpKgjP1RskVuwHm/rWJF1UYGxTRzBCo7jkUfqAORuwoLPr2YryEnr1XSFSqrt5iDLjMB/RZ0Hq5JIr/hPVK/ptzYQDuapZTRygU/GY2n62cYcB2Q5M/pDsIZr3AlX2ePuHQMia8hjCTnZnRc83/HJSuTE/AM3UlZw4go03o4EzNpygLA682FIDUgbVUH1tcjNvi1w6FYq1fB3Gdiu16D+hIcQU1dIM7M8oOFXoFtzkkCLm7uAmHfJI1meBY39eXk/CMkPll/aNNGxIvtsSU/1bCbXUWRr/ywjQDcFP+7mYDTisgNvxQjgzq9FozTKzPrgnWPN6v48xIuQd78Qeml2953teOvJ31VT1sGFeYQG1MNAmxyKn0CNL/1ozfwNzqAOVfisIM56QVC5WjapwQrsN/5Pzl4yMOFVZ4GxGDs4FEWKHFq9YBmedyez9HOVHQG7y4r9nIpET86Ah3NTrfrQ3smsWh3B6NQnG2lYjtm+ZXF8X/IcoEg6t2+6SI8xrwEY29GJta4K1vcQhyvmv/Edj7as3CaJeWiAdTGJbZ2UHfZFYQGvBb3EIXGERzTepGH1cDDeq Yjz2x47v VmFI10GjEiuSDPxWGBgmeHxEFHWxaPMhnTwkqCkSkg34fLiWVmADhNuJ/E+s85lVjBh8HnwvIx+OljkMEWt8XwWP6u0HPt7VZ7LV0hMZ6VSm1brS3RruZreHpcmUUgR3JON3hZXCn3UzwS2oEzI5zeBe+69rKN+hzQjcUpM504aZ4/L0Y98H0Q6c8/5gKbMCuGDuGSlOqPcqQGdsY5Hou6COxb8mwKjsFkFz7WauwSEcSyVi1+Q1qhU1neR7Knl0DHgavq42FhmTQ4Iq6tzHemiydzwbtChXcXVY9bcqKfbBUKYnvAWz0VwHQ8rgX9uIwPKN9FN8BLEq+Q3Zc9gQRoJepRj4Erca+Elr9FdnF88P+2dWjDanysyE2wD5eZIxB5ZmRNuLs4RBHgpiJiuvoGlO1kQVfPlTGyT95FyAZG/sKgKxaBMB8sZomMLiRndiSDNTdGRcHhJquDxHokFh4c2v2v+mSGWzTeD+xdI2MSelZgfY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001483, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24, 2023 at 02:56:47PM -0700, Linus Torvalds wrote: > On Wed, May 24, 2023 at 2:52 PM Linus Torvalds > wrote: > > > > Stop adding horrific code for some made-up load that isn't real. > > Even if you trigger some "worst case 3x memory use", that is > _temporary_, and will be free'd in the end. > > The patches to "fix" this are worse than the disease. Fine with me, we can punt back and wait and hope udev fixes this. No one can tell me I didn't try. Now let's hope userspace will try an alternative. Luis