From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819AFC77B7C for ; Wed, 24 May 2023 21:57:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBF8F900003; Wed, 24 May 2023 17:57:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D48A5900002; Wed, 24 May 2023 17:57:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC288900003; Wed, 24 May 2023 17:57:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A9F3C900002 for ; Wed, 24 May 2023 17:57:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 814C280828 for ; Wed, 24 May 2023 21:57:04 +0000 (UTC) X-FDA: 80826509568.06.9CE8EFC Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf19.hostedemail.com (Postfix) with ESMTP id 720A51A0021 for ; Wed, 24 May 2023 21:57:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=VcANevIb; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf19.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684965421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PAhC/flunH4mhtUx9WkifybqdgbT+jLIDs5rKRqBH18=; b=W194+9F5YBYeu9uFgpBiHHLNE+/Wn5uI7Gz5AO7bLaXMm8WfA4L2NbGPzsyLM9f8RAtMvM 2U9duenpHEfo200KXhaUFXmgduGmbV/H9J+PYbaYf868nU6r6FjMAT2SJ9n6QCVBmKvU5a PsZ1YpNsW3U7wTeoSJ4vQrfEdQGqIuI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=VcANevIb; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf19.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684965421; a=rsa-sha256; cv=none; b=3PvKqLA9tD8rEt1lJe7IUfB5Xr6JkCbdqSH0ZEsNGy5P4qj4CiPxukOsLM492/KEGX/B6L wLMNmNOrvqDfrEa3qNvLtpkxilNclD43hVZ6eardZRZTjcHC3k8P2+5kKyrmcpaTHiGyCF ZEhXrqTOMSPaHS6Xb/NEU03u1mKLgWI= Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-253340db64fso697023a91.2 for ; Wed, 24 May 2023 14:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1684965420; x=1687557420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PAhC/flunH4mhtUx9WkifybqdgbT+jLIDs5rKRqBH18=; b=VcANevIbUge33+JiwrVldMPsDVseKzleSpEoGVXvCtvf59KvdrxkNaG3LuTkHdW4Jk bifOJhE2t54HMCgFf22CN2SG1cVz5SG5Lko5jtDAvmJP1YtUNTibOJe5TrnwIpvIOFYR dOrd/xuRTa+VnYbxbX7Rn0MbebnB6yrfeiMEBHHLsoKYVoaHG7M7CsH56LaK0Gh7rdBq C2unCUg13w37PapsE/+jP/rfI9e9ejFvHv85XK6ohMG1yFOAxI5zmjatNWwb/cCXOFso h/YeuYHyIZlpMyxTKJUzb+DpHWDl8D7Slzl1NiYD68IRDEkqt8JInDTOFbEVdcrm4ai5 6/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684965420; x=1687557420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PAhC/flunH4mhtUx9WkifybqdgbT+jLIDs5rKRqBH18=; b=kyl2eK0wB5SVsclHcDAKgYo//co4Dzsy4Tv1cSkiLuXAK2zxgF1oHCqjygv+nhHoL7 Q3ttfBPmm01ZQnaXJOgQMLRhKbKzWWiP55sxQZIs8v2EfSBAQ5zGGquPsN56QFHtwe3b 1/ILc8UrczBBWt4o6ZtnpyXYYNVg/ECBHzm0RZUKWi7Kbv3OC23AWcKYEm75Gbw6qq0n dwrFkvgQJGrRuR8QV0S1hjHH5AC9MOI+3SNoxalYNmMcm6mR+uAOt8HdWiHPFwpjtiiK t52y3TS+ViSiq49Ee1XTkNKE1PuJMzeoB1PMLssHGIqMDpYlH2kKx8r22oZB2eg0QJ0V GDcQ== X-Gm-Message-State: AC+VfDyGo2vwVXxwiKIiLeX3VfUh6nS+F0p788AR0Z3A4RRi8ooP6yyZ sPp+Y7sZIoQO1GH4b2egOot1yIimA1Tm2DOF+sE= X-Google-Smtp-Source: ACHHUZ5QRESsHt/p5Vp49+LOpaxi0xAHAvojh3fT62UGmVDu+zceNYswQcWGKavnizqXEm1VGKl/5w== X-Received: by 2002:a17:90b:46d1:b0:247:529f:92d7 with SMTP id jx17-20020a17090b46d100b00247529f92d7mr19482622pjb.8.1684965420233; Wed, 24 May 2023 14:57:00 -0700 (PDT) Received: from dread.disaster.area (pa49-179-0-188.pa.nsw.optusnet.com.au. [49.179.0.188]) by smtp.gmail.com with ESMTPSA id 8-20020a17090a018800b0024e41f23a2dsm1954764pjc.3.2023.05.24.14.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 14:56:59 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1q1wTY-003UIE-1M; Thu, 25 May 2023 07:56:56 +1000 Date: Thu, 25 May 2023 07:56:56 +1000 From: Dave Chinner To: Uladzislau Rezki Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , linux-xfs@vger.kernel.org Subject: Re: [PATCH 0/9] Mitigate a vmap lock contention Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 720A51A0021 X-Stat-Signature: 8kar1igz88f99dzs3wcjngfg6yfi4gmc X-HE-Tag: 1684965421-366692 X-HE-Meta: U2FsdGVkX18DlFjqwJEsbsnncQnatq7N1keAfmeTmJH2S8rxfPqGQA76dlKfxt/eFqY6hsr1isn4W+Q4s0lc/19KGHg6JmZ49FxGNNb+E5ESm5Pc2EYbVvcIHYnuu3HwdhxIlPKXHkgctOC0FrpK4oR4nPyFfP3CcInZkBMi7lL3HuOlRlw83yUe8c0LuBYs1jZ0XO4z09IYimLn1i+JxWnJRco/Qq76ggDGpKQdFdITJLcd3OrkpO/zY30Y0Qd/WN6KhjRtSiixqgmzfIuVYB4flrzgZzCdHUG1l0Z8oqXNKPQsbvrc/piNOiVeIxRcSBEDTxYV30iMbMgQCmqXoeIbWNVXORd/UmTu97po7jluhA9pMggjcWJC1azpQnCybsig+Wbo41vJxHjqhGrIF3rYp/B50GlCCI9om8mQWi0i9T37E5xRLd5yAa8GHU/yhTscOSQEZiNgl3IFpOoD7Wy2bNy8F1I2eqM6IZ2Zo55ULzH32Cn4xTiRtOeA3uAEFMGIHaaVtxt25q0AsMFbmrBugyusHLV35xFOVhMTSpFQIuaWVCUf5XWBoOd+9cvtVNO76rY/1tgudpp0fp9GqW0kjZoFG9HSVZr/TFIZPqw/W7fdcvK25k1fRegsKKcqFNTHIGhQvqcshIKmauVzb/1Nt1sMzDJYNmSkA3PO0JhlqmXeQ9YcRJXuqcCZu7s1JPr6/Dt2Pyru/JDLQNAmob7WTKoI3YMxPHVCboL6ouzNIoOiWrmPmllKoPKbH2eDDRu+P/xfZOqJTvBzVp5e/ax9PJWPqdotoJa3ZA9UTialSObtndyfmkL1vJABg/jZz1q18Cnot1iAItxgqQRwPElnjgLqDJjtVnAH5OKAUJEuAcu5m+Z0cdoToNM+DvJgRVxLLqYERSj7mNvZcJmVhKDmHdNMvKSPnUpLQHkQA8pyH8bEJzzX7Y3ofur/A6nnkRjbZOCd4t/Tf2UwzoB OPsFVZU7 5gxSm6gawcAU5X8qv6xYAMe7Y4Ejd/AzJE2fyJ+Mkb41bFKvDgmyyZv+Wf58PZNPDg2Tda1TnuCeSFR1fw5n60XGcvzp7yPb5HhDYZhJ0A7oI8K/Uwp9wsVVhgnFPawwg1MgLYa130ep7CVDDjw3p++f5dpQq+j+ClZ7EO0GI/VRPg8cNE1EiTG1uDj67JVWXq0xeH51vZUOFLtEGfzqXi/k8cRnr4eUs0dzHVzWFXX7Alt8JEsMcGbeBlfWA0HGEbGDezCTMrVa57r0rWB0oWF+u2dQDKafcl89br4Uwn1d0nL3jiukRF6A6nZbC35i98kk8nm1PDcgzny/TxJC6eUK1c4tsnZPS+fqGxp976Ffl19gOZL+WtOXu5jl5+SJTG4nDA0anpQuyShZ4eD8tN71Jj2TRGDcofDK4Ua54feD/5zVkimOFLRpOgYD5LwwMIiJWffS0lrzvBIaacNDrUGfhl64JCRqc0ssLRCOZu9qg0fqfS8J59Ka/vnffgY1QBjSK4KVySO1z7Mnf7SaW50ZtjJXTg/BJQHrXWHiyKFrCotOXQqp9HvvU4MZpNBXdT2ZSyTddcNW4lo4QWxxBrrLyNz7xnpWVYWjf2YkOh+e0punbW3FfUiCnlkG2sZH3TFFUvUxKhg+sPNa//O/HBL4gCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24, 2023 at 11:50:12AM +0200, Uladzislau Rezki wrote: > On Wed, May 24, 2023 at 03:04:28AM +0900, Hyeonggon Yoo wrote: > > On Tue, May 23, 2023 at 05:12:30PM +0200, Uladzislau Rezki wrote: > > And I would like to ask some side questions: > > > > 1. Is vm_[un]map_ram() API still worth with this patchset? > > > It is up to community to decide. As i see XFS needs it also. Maybe in > the future it can be removed(who knows). If the vmalloc code itself can > deliver such performance as vm_map* APIs. vm_map* APIs cannot be replaced with vmalloc, they cover a very different use case. i.e. vmalloc allocates mapped memory, vm_map_ram() maps allocated memory.... > vm_map_ram() and friends interface was added because of vmalloc drawbacks. No. vm_map*() were scalability improvements added in 2009 to replace on vmap() and vunmap() to avoid global lock contention in the vmap allocator that XFS had been working around for years with it's own internal vmap cache.... commit 95f8e302c04c0b0c6de35ab399a5551605eeb006 Author: Nicholas Piggin Date: Tue Jan 6 14:43:09 2009 +1100 [XFS] use scalable vmap API Implement XFS's large buffer support with the new vmap APIs. See the vmap rewrite (db64fe02) for some numbers. The biggest improvement that comes from using the new APIs is avoiding the global KVA allocation lock on every call. Signed-off-by: Nick Piggin Reviewed-by: Christoph Hellwig Signed-off-by: Lachlan McIlroy vmap/vunmap() themselves were introduce in 2.5.32 (2002) and before that XFS was using remap_page_array() and vfree() in exactly the same way it uses vm_map_ram() and vm_unmap_ram() today.... XFS has a long, long history of causing virtual memory allocator scalability and contention problems. As you can see, this isn't our first rodeo... Cheers, Dave. -- Dave Chinner david@fromorbit.com