From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7347C7EE23 for ; Wed, 24 May 2023 15:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A5F2900006; Wed, 24 May 2023 11:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52EF7900002; Wed, 24 May 2023 11:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A81F900006; Wed, 24 May 2023 11:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 231D1900002 for ; Wed, 24 May 2023 11:07:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EE114AD8C1 for ; Wed, 24 May 2023 15:07:34 +0000 (UTC) X-FDA: 80825477628.01.D3A04E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 5843080240 for ; Wed, 24 May 2023 15:05:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BAyw3H2/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684940750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1IKq4W7kXMUcZYad8O4aYshE6tNJx+8XRtusGP3BwA=; b=CByAkcioG88eCaoEgAHE+m/qzs7PhPlD1B7xxWs1FdwRT+sKhY0PL090uXeVKDIjZgx93H r/Z3A09+c5yWBlYbK0LxHQQRdFLx/IjuSIPz5pJKpI/dV0m1z0NxdKKPvS9z8ZcJz8GnAw AMvDCNkqMpDY80ZG5LhVm5td/xMdRAU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BAyw3H2/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684940750; a=rsa-sha256; cv=none; b=pBiYPbv5FmkSGgqcxg+PC1509T1KkoNCdBHSxXTXzKNQ+fN6kK56bQWf+vHKbfUGgCUvWl kqbDie7RAmtOva/f0iQKA55tEtC5dVG8ZZ8xi6Y83EM6eH+EvkZcTyW0w9U3OZZN87Rea4 jpVGZI78KJBNLrfCwpFKY6KjP0hs/2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684940749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C1IKq4W7kXMUcZYad8O4aYshE6tNJx+8XRtusGP3BwA=; b=BAyw3H2/ocVKgwVIV7n89FUoU3gfpbEEoPObPGMI4HmsNQiQItDhdp1tfiDhTQZ6YV+0n1 AOobINnCEBkQ1HgbIoriv4Jmi+2ReFQxYNGcEHwhEZJxIgRvwIp6ZqZapX7VUwvdGcbsCz GFS9AH9hrzDyO9/qByEhpf+SEX/CDb8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-Sz1oWBIqOjubyqhgiz6XSw-1; Wed, 24 May 2023 11:05:47 -0400 X-MC-Unique: Sz1oWBIqOjubyqhgiz6XSw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-623b86d929dso1403936d6.0 for ; Wed, 24 May 2023 08:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684940746; x=1687532746; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1IKq4W7kXMUcZYad8O4aYshE6tNJx+8XRtusGP3BwA=; b=VZs3WZ9RwqeJCOt6uxfaYqEaU0KcllfqCTpIdDrb9R8yPSnp3JZptrxMiGGszT8qlv j17psqqeQLEbq+zb95uT6dFQXQETF0NPuCSKpQ7nDtu0fI47QwKiaAEfYtMDNrwTtYn9 b+BGyaU6nqdCeR+qvze7uQZVHgYIImfK/rYBXlQjiKhoMCfLJL2Ii45bjpSdU1gQ4uHF eYc5hx6aLxxLdcDttMuBw47nRg1P2DUFPMQhELPJ07smlOMwsEb6G8/nFbGnB/Rju1+M WxY5OPQ3nrJxVDri4U3MdaFzuVaXlZ1la7fhOynsrA0P2pcY+vHEBWmGSjkhRO1FA7eV CCqQ== X-Gm-Message-State: AC+VfDxMm5d1ea9QX0lAfr9+C7naxBjavBPgFinSuFSo/cx8sKgd6qQ1 gn0WNXAPkFzndo4qqtAoW0blgKU2PDqyRSDmReD2OSnJYZUVIeN3KgiIGW8S/MYSVR7FFBH2Egv KX/fhyF86gUg= X-Received: by 2002:ad4:5961:0:b0:625:aa49:a48b with SMTP id eq1-20020ad45961000000b00625aa49a48bmr2106786qvb.6.1684940746117; Wed, 24 May 2023 08:05:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5u2JsTk1mmNXoqf84VPpm8+rDS0A+qmShWJLS/640lXVGHgY6BmYlqoYyLv6ghI1O3C3OnlA== X-Received: by 2002:ad4:5961:0:b0:625:aa49:a48b with SMTP id eq1-20020ad45961000000b00625aa49a48bmr2106736qvb.6.1684940745557; Wed, 24 May 2023 08:05:45 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-62-70-24-86-62.dsl.bell.ca. [70.24.86.62]) by smtp.gmail.com with ESMTPSA id v10-20020a0cf90a000000b0062136626e09sm3625337qvn.57.2023.05.24.08.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 08:05:44 -0700 (PDT) Date: Wed, 24 May 2023 11:05:43 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Christian Brauner , David Hildenbrand , Hongchen Zhang , Huang Ying , James Houghton , "Liam R. Howlett" , Miaohe Lin , "Mike Rapoport (IBM)" , Nadav Amit , Naoya Horiguchi , Shuah Khan , ZhangPeng , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/3] mm: userfaultfd: add new UFFDIO_SIGBUS ioctl Message-ID: References: <20230511182426.1898675-1-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 5843080240 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5xohpgrzqxawskfwmsg68mirktyq9tj8 X-HE-Tag: 1684940750-740669 X-HE-Meta: U2FsdGVkX18D2Ug8kJi9jENdX4UP/2V1iQsT7kBZGWp3k74oE0qoktSPIUXMt9Yqaiu+Wmoblbk4hnYjNDWvO1TWn0FnOC+cUQsffJ2o9dlxxn68hh41CUTQS9UoMs5HJRfirGtKf+DD1mzA1tgRkakU0R+KzIWX0wHqNlNGcudugOe5gJPQX8Q/amZaCSPaqUCc1xpV7W2LdILgN/x/rRL9dOHxUJOyscEsIjvcG8mpVpdmJZRbaP1JvOVi/RIZ6taFtiTyCuD0onHmWpxlHH6qQM3avM3TTBzu/FxT9mhY+EdlvGWhkhp0YuJ3ne4W7raGCzSl5/ucOhPM3GTWOTNgMIoHW60uVr2PCkI5JvIWrPETBXhWckTIOfdk7D/1XySJyqJrnZ0eWdbAym+b9zdZiYmqBwAIN4pWSMcKx9X/erxe2xiybwUhJJS0it0UcfadzrG7UAIFApbubDg/U/plXP8XvijjDnpUX+PYzHeomZEzFxnyclNp/us5Vw5RXtBf1noGBxIiE2zi0NzAZUIAxRR8vTVQHHKD+vvrmUpXq/9sF5AQJhu4HpG2QqoxYXCDz+HG3RZ8dBsn1JQ2q/LThSWv+KvQutB8dWOldjDXga9nZV9/z9M1lB/iFr/0K7WqWJCgO08QtnkGY28kPH7G8RyEoFkDIFIpdh3skjOgNqBdusByJKQuUDLZUovwqi3ixsaZLtcyuOotc5bOt2v+N1b05+j/VkTVcAmlHS3MVEWIiynjdyPZnUGE4ecCMlvzAOVWChVmkuy9eLT+4lQfFdIw1xDbSw1M51AJCc4oSkMzM5JZDIj49Efu07U6KdrWWRSJidyXWnyNlZrw4LfgERWi1+HPW5YcExQKGKzUJU/teU4Ax5Nejy90/1uXemjGcbX/pyHoK9jh13IEJGj+EvjcQxk6hhgRQdqr9/4CrH113eaGTkJOwwwIoFIVPUIk7KHfK8XFxctL2Xq 9N+yZHjy 2dK7fFlF/pZfpf1dR0MvLThJBg6sZa1YOfktO9oLkw0aHr0lWPbsGEqAYuiZXYEY2QMhbkKE+onsuEJpq17J6WEnJWmLYPwh312zuJ/DI+Fo5WjMYcjsB1J57AnJqRvM3mz8aJIr/UZ/z5netsa2RwwiylTQxYZlvEB3wwPu8Ogd8JORqc/CXRSRwpRg8DCmSyjG/enPvE20wCQjT9Arvz19F4gbwFuAsXRguU1tZd1uus9U+/tRPi5vdmNfzIJoAjsAyw/QgJ3zuMULtDDjRipI/HU91ToG7IwUu+6eFJH/97syhQlTyoo48Co/uExWh28ZUyDZmMZNN2XuPDT/WXExbhnQASf5fcjye/xPTDEv6ZkXlHFFWCjpEkxrxZKbVHCA1Rkn9BqdX+2HWjvPNNg9IF2tmd/anlWm5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 10:59:05AM -0700, Axel Rasmussen wrote: > > Actually.. I think maybe we should have 1 patch changing SWAPIN_ERROR from > > VM_FAULT_SIGBUS to VM_FAULT_HWPOISON. > > > > Let's imagine a VM having anonymous page backing and got a swapin error > > when faulted on one of the guest page. Instead of crashing the hypervisor > > with sigbus we should probably make it a MCE injected into the guest too, > > because there's no page corrupt in bare metal in this specific case, > > however to the guest it's the same as having one page corrupted just like a > > real MCE. > > This is a great idea, you're right that injecting an MCE into the > guest is exactly the end goal, and it seems like VM_FAULT_HWPOISON > will "just work". Also the name UFFDIO_POISON resolves any confusion > with UFFD_FEATURE_SIGBUS, so that's a nice side benefit. Hopefully! Please double check it with KVM running altogether to make sure the patch works exactly as expected. [...] > We'll want hugetlbfs support for this operation too, but it's only > really useful (at least for our use case) after HGM is merged. But, > there's no strong reason not to just implement both all at once - I'll > extend v2 to also work properly with hugetlbfs. Probably it isn't too > hard, I just need to do a bit more reading of how swap markers are > handled in hugetlbfs. Sure. We have too many flags separating different types of memory, so I think it'll be nice if when it can still trivially work for everything. For this specific case, since your goal is definitely having hugetlb hgm supported so it'll be even more trickier if only hgm will be supported but not !hgm hugetlbs, so we'd better target it initially with all mem types. Thanks, -- Peter Xu