From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795C4C77B73 for ; Wed, 24 May 2023 11:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E7AA900004; Wed, 24 May 2023 07:51:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09799900003; Wed, 24 May 2023 07:51:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA19D900004; Wed, 24 May 2023 07:51:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D76A0900003 for ; Wed, 24 May 2023 07:51:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6D9C14058E for ; Wed, 24 May 2023 11:51:34 +0000 (UTC) X-FDA: 80824983708.18.8BC7016 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf22.hostedemail.com (Postfix) with ESMTP id B2147C0009 for ; Wed, 24 May 2023 11:51:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Uxj3xXgG; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684929092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GvUgAiVcia693kIUClLrrqIlm3JaNHdyav0slu5eGMo=; b=FiVzU1FWZv1YwBygNbqvHutIozxCE6uXZBL1bTt3iJtlw1SoyqnFcyShIsHGiXNhnXxfW+ W43l7fVm0044uXEsmuhWW+gL10FFM74Hsiqjm75H1o/X5Q8JoeN3/avZx5ESRjkM8Gntym S5EWaZNyIgKEHTRGB15oWZTUAG4O16w= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Uxj3xXgG; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684929092; a=rsa-sha256; cv=none; b=lyNV2puAheDsyRD7lEFaZPY/6vvs3YK1sh5rUdqp+0sjQlurhv9VjCOEbAB0rP1schro6I KhHfGpUDMmvKwRahSsHIWRK9D16Q8zUNMTkWk/WE6seYpd3SXPYPp2jIYdfgmOP6aDQip5 FPHd6fOwV3Pt6xH26OmJL/geMirHmIs= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f37b860173so820413e87.2 for ; Wed, 24 May 2023 04:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684929091; x=1687521091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=GvUgAiVcia693kIUClLrrqIlm3JaNHdyav0slu5eGMo=; b=Uxj3xXgGnT30AuMcmLrKrrEH5nvwD2JZzKwg55Oah9UjaPnmaZ8+obVXreoQGkd1db cgh44MEZMQp3Ie9DLMiJFfO73UDMbY/3bVjxxInbGXlFeBptP/nd+mMv2DBwFm5CdrxS +0aHm8ZXe296v4jlNaSdABStyefNYJt+fKTtCjlEqbdGQMT3KfL/NWcKJihaOOUoJKVw vPAfwhaPIXQJBlzXLJtLPnM9jHstl4KPoTSlceryQ08vm3zxv1G5GqicsnroCrvfkO9+ RsuQwyBX3ftJ5dHMCFT4D6/1JhA9czj9VWJmmsE1U3Sv+Cmz2QnDJ9OuTxPXaPB4Vzdy 4WXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684929091; x=1687521091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GvUgAiVcia693kIUClLrrqIlm3JaNHdyav0slu5eGMo=; b=fTAh3G8oc4mjPntl4wI7V3/0In3qhQoWkHVGA3kUbUBFEtk69aGY/xLF1JPdKmvuIG tS1Qduy4vWJMNlbPmVqZ1A/yU1dneMzRciXuAE9iyqSBX7HI67TUpeAGieGlSYy5cAWa W66blsxKwLzD2R0g6jAhqD/fTSf3qXIAFTqixz/8WxoNHSqMIIobEIvljUKln0gdzGll qzKDUALZwc856Mc6BtIvgTOcR4dJfm87a2a6G5mAgwlae5RGKgZf1RdGctTX4U919PxI s3tKLwlTSmXkVcc18gPsKnBc8KEeEf7RAEskbVSvlp1Iqu4v3bZjwCb2Dg4+ZoQjOs8v lbTQ== X-Gm-Message-State: AC+VfDwM6XXd1EIinW7lbbyV7bgggVVTYvROek9x8G9rG9LO+DYLfLFm czLMufv9Wvw9Cq0Rl5VJ3yQ= X-Google-Smtp-Source: ACHHUZ4YO6KydrlqOjZzVkw80x8WD00C5pF74fH56kjKmcRPV0kbT3Tt0vZ+jtgPmNTQ6h7jAwPcdg== X-Received: by 2002:ac2:4c8c:0:b0:4f4:af2c:97e with SMTP id d12-20020ac24c8c000000b004f4af2c097emr3065261lfl.11.1684929090720; Wed, 24 May 2023 04:51:30 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id f9-20020ac25329000000b004eca2b8b6bdsm1692804lfh.4.2023.05.24.04.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 04:51:30 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 24 May 2023 13:51:28 +0200 To: "Liam R. Howlett" , "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-3-urezki@gmail.com> <20230523172409.goshjwenknthrbr4@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523172409.goshjwenknthrbr4@revolver> X-Rspamd-Queue-Id: B2147C0009 X-Rspam-User: X-Stat-Signature: rxxf8xkzsym5itu3jio1e3kmhinyy5a5 X-Rspamd-Server: rspam01 X-HE-Tag: 1684929092-217393 X-HE-Meta: U2FsdGVkX19AF3HzTpDziiiuF2U0Te9+rMY1j+1HImIpghWy8Xq3edYENLA33wNtotED2TZ0Kcpkt6/AYB0GZI4WyPi1XwSu542ZHUDQm6A3t34wJCy0c5yxQdjvV9hAzzzGfdeRFXQ7rhC0Jlteo+Mqk5lXFSe95xdZYFkm3FODPuYOqojdivlh4xoh2g8AZ9rjF3zG+jOQ3ui1loGCg4gBZemznHf665PegnlvZy8/5U2nRj9HUv1BOwIU9B0mAehnzv6hB+GRFTLaa0M1XewWOCsdsB3g8Wjziw+ZVoCCeFYLZVnM6m0IswEvohkmsRVm1CqP5tiMJ0waL/IXLbpSO4vjLoHFIhrdz0vutCU9U+5ZPRQEOiF2DXyTCAYjAOGY23O0k0RoUn6KVnoklnLHxOELsamk6fsZEhrx381r6PhEPLCIVP+DkeYQK+etrsl1Cr+3XvYOR4HSb9IB3IJqGKK1wiuYDFsCvQTDFMqs0P6oTYrTuWgTNwg1+OMeBRhc48+Fa4iWk60rZLJQQ814atXR0Gv5LnWGJua3ioJj3L4HSdPNAABk+1i7pOU81Fr1cu2LTvS8DHEG349FyhEQQwDkGbAoWINzIxiOmijWvnUEyNDvLp6FcMITiyTppf7CcknjR20hawoFIgbZ2WAyFO9NaUXaewX1i2epD9l2tqbo0wPh7TRjgcsKBZTAv+OXzbUVciZs+SldC1wo1yTgi9YzzbfHwZL/JEE8Ywkr5NJvyo9nZcw6IcWZ+peZTG12RXudcbRTCkDmVAoJ19MaIoCINzg1At2KcXSJyxgNB65FVfKx5Nf3GL7iAYD5o2yNtSzRfap31138gZ7d34x1cDDsICPH6y7+cpPQpP7Fe0abk9SnM7G4YJs68EftZmGucST+Nr5EjGuvskeupz3fYG4WBOEw+TuLtSV/XSBK8Mb1uap/BjiELJNXUUVHpTDduNI3j+LOIdBlEpf AitNnbbZ 8v2JzBzgWqrBONGrme1nbUldM9cZCKhUukNF/IIoqSfs13anpSd/5fX4FTg6olNI+gZ/o+Gxi8fYWqB6TSOqcTCEEyo2117boNpDxQAIXSL0tnJJ2KFBeidGu43sQ1UV43Oow52Qb1+7mhbEE1Qug0eEYU67aVZL8BbQ42bidnKtIsQz49ASviisD6ruK0v0nVbNXiXIsNDVIVQS1UdWv3sYPl2CGH9iA4/DCGTIrdTW5sk0zk/egUD2/aYutH/bNhPTdWBSNqGoUuy8/ApiJhkPRG8Dc+yxDMOjdAytmjvEXVS+2AZWoq41MX8RbNtHH4MSc2HXlsRK2JucoITIpiAK4agA5S0FMcHhn14Ma7LC0OAaBQZ3LXXxed3t1WnJcygWku9/ndJIFuOxq0qwdJDLbRg9n47tAiwHATk1DDDlILX/Al5Vsm14/Zdpr/5Z4Owtnyx05gENhF4dZiFoR3XoV4yH/sYewMrRdOuMaCltps2/oyNQN9yBxlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 01:24:09PM -0400, Liam R. Howlett wrote: > * Uladzislau Rezki (Sony) [230522 07:09]: > > This patch renames the adjust_va_to_fit_type() function > > to a shorter variant and more expressive. A new name is > > va_clip(). > > > > There is no a functional change as a result of this patch. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 409285b68a67..5f900efec6a9 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1383,9 +1383,9 @@ classify_va_fit_type(struct vmap_area *va, > > } > > > > static __always_inline int > > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > > - struct vmap_area *va, unsigned long nva_start_addr, > > - unsigned long size) > > +va_clip(struct rb_root *root, struct list_head *head, > > + struct vmap_area *va, unsigned long nva_start_addr, > > + unsigned long size) > > { > > struct vmap_area *lva = NULL; > > enum fit_type type = classify_va_fit_type(va, nva_start_addr, size); > > @@ -1501,7 +1501,7 @@ va_alloc(struct vmap_area *va, > > return vend; > > > > /* Update the free vmap_area. */ > > - ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > > + ret = va_clip(root, head, va, nva_start_addr, size); > > if (WARN_ON_ONCE(ret)) > > ret is only used in this WARN_ON_ONCE() check (from patch 1), since you > have shortened adjust_va_to_fit_type(), you can probably drop the ret > variable all together here? > I can move the WARN_ON_ONCE() check into the va_clip(). So it makes sense. As for a return value, we should check it, at least here: ret = va_clip(&free_vmap_area_root, &free_vmap_area_list, va, start, size); if (WARN_ON_ONCE(unlikely(ret))) /* It is a BUG(), but trigger recovery instead. */ goto recovery; i t can fail, though it rather goes toward almost zero%. Thank you for looking at it, Liam! -- Uladzuslau Rezki