From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619E1C7EE29 for ; Thu, 25 May 2023 18:35:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A8A900003; Thu, 25 May 2023 14:35:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A451900002; Thu, 25 May 2023 14:35:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81E49900003; Thu, 25 May 2023 14:35:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7038D900002 for ; Thu, 25 May 2023 14:35:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 28540A0D41 for ; Thu, 25 May 2023 18:35:29 +0000 (UTC) X-FDA: 80829630378.01.D54A701 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 259DF40016 for ; Thu, 25 May 2023 18:35:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dREWFlMg; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf04.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685039727; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3UfPchLUYdWy9KCje7JNWMJZu0GBbqs1XHhZyb9Elpg=; b=ywjD07ahCEdRnvyd5qjhQO4pOfjfVOgevOXy4xh5NhNRVwX6pkNO4o7i61z3dKv7wrfigJ dC/jRR8fOrLm0jTj/9ZPAoh3MN8SLNN3lC6NG/8iZO/cKpW8A95SOhGvA2Hnmr+zRvs4AN rLrCsjgb+33jGoCMfYRGlvfnwOlPtfQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dREWFlMg; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf04.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685039727; a=rsa-sha256; cv=none; b=nhN4jpjbPQ6CmBNRTCD8Y8/AJx5c+JehXd3PFrHK1EivI+jWekMNrG3Gz6j7YyoxT14wnZ xlT2+Q8oqM7ahw+xjAOKJV3MJzgNrwiKXJTgEWW3Q7U41eouYIHFaAn9N8/5V6DRs+qYol 5U/BwuCtm7CYfqIR3NjoWWDBY57K81w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3UfPchLUYdWy9KCje7JNWMJZu0GBbqs1XHhZyb9Elpg=; b=dREWFlMgPsOScdh4mHYj5vpNlw HeeuA9W7TI40gjiRe+mbNwDH9vWaRtED9kNXnJ7Eusr53g6BtLAuotQypKw9DJH2uep7C9CpsQ1TQ bllam3AtdkUmxLMZlhm16mC05+GB2+Gk4N6vp43KXCjFQaya1hE5GmKX/HKra0P2wBWWcjHIEo1V2 3QPjca4/AhFY57yNLeouXSnrY3JLPy6ofCSM2oqccSgpfEqxBRP9wS2qzKiS/7ETGDwKvXWJBCVSf eqlNosa0U3phxMepSLIM4URGOCcoENiqxjZrTOQyp1azZhXnTh3gdW9Ek2FpB4L2sCBWcXpjL3ZiV CQJ4yMnw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2Fnt-00HPwi-2H; Thu, 25 May 2023 18:35:13 +0000 Date: Thu, 25 May 2023 11:35:13 -0700 From: Luis Chamberlain To: Linus Torvalds , Linux FS Devel , hch@lst.de, brauner@kernel.org, david@redhat.com Cc: tglx@linutronix.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, lennart@poettering.net, gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, lucas.demarchi@intel.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection Message-ID: References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 259DF40016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: aay66jx1stxm3sa716zgi6yqi5u7i9p1 X-HE-Tag: 1685039726-495201 X-HE-Meta: U2FsdGVkX19+qspIrPA5PO7Mpjg6ZJR5lI1ztnO2ebuveWUyjcAFIxQOO+EV8BEoLnq7vHOWtg+h4H6hLSZv+WEeKurSPm+877uy1EexLOEbopqwd/OddQU1wIramnb0TK3dhoXr036NVIR8nPkLtUGqDIc70MBiQyVc/ZxhvtkD0MT+b+K5fAKHvTUUEP5RqVCl+UgfIau2dY1yxFIIJaks3DM2W5Cf9HVpShrBFbIOsfYgY4UM+XkhiNFQBfPpA4U70Ew5uASON6qjyfIZ6Biziettr/qNO+rRAg1JG77UFr3YIgmIGr84NpmzHNEVv6hYeixw97xletQMn8GQESu72PUahCqTbg8SFNgozghYeaT9kU2EOl3Bcc6Uvs9oDf7F03Skbw3+s8nTgFaD98QDDPmIQadrWpbtrAVwwHmBswodOCPWB4hBQ7qCCYM5HBZA+wtAf8cIiTrhukEurWTs84kgrAe6bSG8OoHm9v0jMkKbad00bNeXDV0LweoMzV1qhDsHFKK8yl5T+pYnray/35jNw8+SwdvF3e8QPfSyDX0K1eg08fUJQY6r8OHnu6qc10rrdzJR/24/AIIA+Sh4Q/vUDtLKXNnohPFrfWcIAFVPQ5a2dHJBO+o7YyQVbNoy1bmKZ63I+OlSG/Qw4cxw0Ov/4tTBO68Q+rEeZ4bnqeiJnUcoZn8H49ECDh1MPmH5ppRXPlkVYcXTkuVy8iTlLvMjqOXb99XcMnE+tSMl+baJYroVBnU57soobVWgVnX1kave2MVUr4Fw8L6PKeKYk67eQg46FbYuoncJKvZGR2rrHu043vIjeHkoJAx6d0hyq0bD31j9tYXlg+IDne9OlC7ovvV8241OlGpZf/Bs1ufMAEnvXb1ebgMX7uowy+FNyMc3w9yTs913EcEmw2oRWhhLo37EISZMnH28XKQHOVy6kKHD/TH/b2VAE/YX9Z91OtiwHZQnHh1EiJk MQ8FowOn B5FmPr8rsF/l40HYhitzRrvHJeh0o2z1HQLrqd4AOWoW317q+KMoaiFndBgqOcQxwi1mCPInYJpAGMBPJdNJkS+BegLU5pTOZ5WMnaNhic9UBlvAGzNUq8a96MDkk7oQUNDBASGpURjebNLOE9HcItpusbMJ54ADJkFJvuNIBNhz74FnWxB18VEM4hrAjuxfyvWd9x4oncuNtzw30SiTRMiBtHMYZYR+jI9SUYCDJ3yHxY2QAZoWyiadYwA//m26thU0TnBKGS/VS1alKYypyHua3u4GwQOkKBuPA5/6nIBXIHfwNqOWm6ndK+ELacT+MmmpnR76tYP7IKYjR+h1Fwr4HTqCLKQaC48/zjtVp5MPEfshNqLNp71n0B8ZA5m1c5hHOo4XaY1U2qbjlJTHrTOigf1Yyr2fRuK+VWJU7k+5P4zWOpKTYJCw1Sr0/00Ud6fIQ+TcswsAuaO8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 11:08:13AM -0700, Luis Chamberlain wrote: > + fsdevel please review, > So with two other hunks added (2nd and 4th), this now matches parity with > my patch, not suggesting this is right, just demonstrating how this > could be resolved with this. We could also just have a helper which lets > the module code allow_write_access() at the end of its use of the fd > (failure to load or module is removed). This even fixes the pathological case with stress-ng for finit_module: ./stress-ng --module 8192 --module-name xfs (stress-ng assumes you have all dependencies already loaded and the module is not loaded, it uses finit_module() directly) Luis