From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7AFC7EE31 for ; Thu, 25 May 2023 16:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738F9900002; Thu, 25 May 2023 12:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E9056B0075; Thu, 25 May 2023 12:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B08C900002; Thu, 25 May 2023 12:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D4766B0074 for ; Thu, 25 May 2023 12:38:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1000E80A8F for ; Thu, 25 May 2023 16:38:00 +0000 (UTC) X-FDA: 80829334320.26.AB38449 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4DBBA1C001E for ; Thu, 25 May 2023 16:37:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685032678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJG3XonGqwQZM3zjv5292/4k+DBqsTBpPdeV3DeaMU0=; b=ZN10YmFBRuk/c1tuaXpWdPSaenO4LgclCowbkniCyWvrOfFCXYdYvK9OWO6gk0KDKc2idt fqMNeFWUgXkF7wE+6eR5KxMwr3vKbvjt/sIE7b11QYa4sBG80rPJEH8077XSopjW8INfmB mDe6p0vKEfzvSiQgU3x0o5h2r+/yQDY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685032678; a=rsa-sha256; cv=none; b=iVX88KZO+KFM5Lh4b0YNWOiZkVNEFsLOM9082gREfqCNzceU5Hf/mcOXRWzP04bgAsHcCW EBxOy34ks76DQc88jMMX22jqyFib3eMGnLoMdW9WHN3QSiYjBu5QA+5wFJAYPmP17+yoHi nKBRPiyePIZflZoazMmyWth89R/18PA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A226613E9; Thu, 25 May 2023 16:37:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A40FC433EF; Thu, 25 May 2023 16:37:50 +0000 (UTC) Date: Thu, 25 May 2023 17:37:47 +0100 From: Catalin Marinas To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Russell King , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 03/23] arm64/hugetlb: pte_alloc_huge() pte_offset_huge() Message-ID: References: <77a5d8c-406b-7068-4f17-23b7ac53bc83@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4DBBA1C001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 76hu6bk3gqu7jw93aun51ifamcfntymd X-HE-Tag: 1685032677-928745 X-HE-Meta: U2FsdGVkX1+oS/VJSJpFu8ogd7Sb4qVXQER3mvC03fkFdLtqrdzHR/yw7Uwi8JBpnQW66+LHiazEnEcWLXZ1k0GINcViZ2kuGls+IEEUgI/hz134DR8wtszSa0mg4cpSrbSaMtecXkaElGYd2HLLdpfBfg4qwJd75F+xRSzVsJGo7CHvwOOAIIMno9ealqjFlRsTRH7Vsraiwh2OqUpG+GY8ZaCRqDvCUTiXSc9u/tmxJFSAvI4GUFSwEDuxPsyF/vDfLwchr7LTDL429YQlvVEAqiMywqqCJIA2OSx1q73FlLnbXfSVhM/mZYm4zYJg2Yq21X8dzdmC8Ns7R36dpR3Gl21k1y9RGWoWemZixGCYI1ezAm/pRFpilC4jK52k8IiIrcX0E4V2rfcUIqhkKj28xaA9vNDuwP6vVntXjdz4TE3jZ70ux9b4dRNXyyN71PPFqJOnjDGT0Ny3m0oLZ/GAht41aelZLFt0veRDeAaO3XnKbCY9bIpH6m+0rwHpY9RtxlGkWn9RO9pTHuDVLZirdD6FGnExbnPmj/PiMJHfwIb9TOrWQuXrNJpKx63CVVqkSzDRlikFBxlflAyxtMW2kwM5ydzBE23kRqbyJN2L0Gy5IJEpUwFovBgEiSmU/VkWeecbjr8d0qVakRLOdwePJAeWwFfp2d7r8o2rAXKTfluKCJlbvI6xlkF3mdQ0HA1mmk5YV0HJ16yar0GvLWvvemyR4Du2WpdtL3aszkxbvtGjMglsK2R+s4fNTUch9eTSiJZUgFrsq4wHhsaL7TGuMbY5DLbBOFdW2S0qvDD4tU83Zi/04V8nk7ytQONqJ1asMf9QVXFlApgWgcq+fpDJwgzePq8bcXHKJoSfvaioY3oJNUUSsnphzPaE1CbUVsGmisoMzY7qR/wAiKPQmWLIj7WBzeUWH7uHkSeD1x7ZWyHpsN0Tx5Yf9WdH1Aal1jcXeaRzWd3EHq1kYEJ rxVvusmV zPy8YifYfUpOER0LLX3+EupEUOy63q2rlzJq1docereYah6mqkDKFgRvXnHwpoalSgWDUonAKSbK21PiSdmSrE1U+abhNCFqY3qzEbXzhY6/GL33RTV2YToAYv+drXVh6PRCdCD/+xlyMBIZbp5wm6Z+AYQCzZdCv5rwKM/XrG2E8hTQ6vwp/XjJv124L7QolWti6N3r24ccHdhjG13XW0J6x6m96wDrNKKgOnE6lSA0ttFBrCS6+UITxacNvYnf7/Vm6d+IlGVwaxP3m84SQgh/6we2OMWdrGxC3rHfeKAtNDr/xjkNOQFP86zsHsR9vfrjcofnslwCUctNjh9g0UgHIUesc327N9vyUebShCImZo52zejKkYMs1pTVgWyaInI9lAKZHmMnTdokuk0cpEEzsoKVd4lZoc0KMLWd8AVI845dPJMGJwzWkPszxf9qZhTU+mubO0/E73Pyc480HpT/ZApOgrQhvZ/Bc5nDxzguOWzxzJgHjyxJ/mP5k0v6exv5D+CFQqtWhMWe3Dh3eyWzx5HJXjbCgsr26 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 09:45:57PM -0700, Hugh Dickins wrote: > pte_alloc_map() expects to be followed by pte_unmap(), but hugetlb omits > that: to keep balance in future, use the recently added pte_alloc_huge() > instead; with pte_offset_huge() a better name for pte_offset_kernel(). > > Signed-off-by: Hugh Dickins Acked-by: Catalin Marinas