From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30ABBC77B7C for ; Wed, 10 May 2023 22:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5916D6B0071; Wed, 10 May 2023 18:08:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5415A6B0074; Wed, 10 May 2023 18:08:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430036B0075; Wed, 10 May 2023 18:08:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32D2E6B0071 for ; Wed, 10 May 2023 18:08:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05A19A06CE for ; Wed, 10 May 2023 22:08:31 +0000 (UTC) X-FDA: 80775735222.15.090C106 Received: from out-55.mta1.migadu.com (out-55.mta1.migadu.com [95.215.58.55]) by imf30.hostedemail.com (Postfix) with ESMTP id E71E78000C for ; Wed, 10 May 2023 22:08:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="syYion/p"; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.55 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683756509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WrIQPQnkmZGURp0Bxb/q8NWjaJP+SM0tcC5NbyW/agE=; b=Q17NMQEwzm3cTDXvDBfDUvqe2nSuWg3PvIVTCvS9TmAnICrHUPUiwXN5H8wBL3/B777tmi AJ2bNpItoiynZiWM+EMeSlY0DEfiIgyewIWCl0m2luVh7jJ4KQHDmKODODoWfPH9GzxU2Z FsMFlE84mq8QH0cV2x8LeV8oke9ChLA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="syYion/p"; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.55 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683756509; a=rsa-sha256; cv=none; b=YRlJDPavhkvOBOB0ibHwdNX1Y02Q3T271h2V8oyh//aK6LdPEjJtc01te9AcySGLXQhpHw PC408whJ+3A/1SHQ9oCjLjaaMKs5+h9a692P1uAPmIBYxw6XNY9XCw0Z7Kfz2yQpDHLQla aR5zQDqHi0z1piYckrMuRcuupYCNXV4= Date: Wed, 10 May 2023 15:08:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1683756506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WrIQPQnkmZGURp0Bxb/q8NWjaJP+SM0tcC5NbyW/agE=; b=syYion/pf3iN5g6Erh/3IJtGMvtUP1OBfdD3Vp5MYVa4Lwh3Ievk83IcH0lqtCkDhM1UhN qHRIfMmS3RbokWDV5HvZmpwqnXrvohilj8m+uFX9+pcuE0VIwzX6rOM3WtEvscoATWoUJ8 XBuQafjM5RUyAeeQUbrpb6ERXDxKJAE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: "zhaoyang.huang" Cc: Andrew Morton , Roman Gushchin , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCHv4] mm: optimization on page allocation when CMA enabled Message-ID: References: <1683685251-2059-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1683685251-2059-1-git-send-email-zhaoyang.huang@unisoc.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E71E78000C X-Stat-Signature: jahw1zdd999pamsjjpehpt3zdgmyp3rr X-HE-Tag: 1683756508-507999 X-HE-Meta: U2FsdGVkX18jYSEZcxbcSxA7TKfrq+6gVP/wKkAhfzWvI0gt35+xKE8vntvwj5eVyZH/OVVl+0LC4oGpNxsO3l812Yi0kk8eBcSOJH4UdLbUYajt3cCg45K94n3S3YmpLt7tTxcryZZkG584lqgfx8aR0HvS/eo9jp0++3oUOw8GNH021J76FN4E3Ep59IabFvqvyHgA4MjdqX2NiFyie0yj8cwmBE2S3/To/w9W+YkmQg5bZ8irAmKZbeBvGKumIZoECr06Ac7EPmjayHG/MFXftKFAXB5iszuggUP1dIn13misPa65M/BaeH9NE+GIlv0az/cP/ncJqAQ6mw5jg6eDMznuhepmSXh4l8lT5+J5BsaUsmO4WxjjisfjycrU3FXz0XbTHZHclx//gxkU/Qn7NfjGj43G9JO8U5MJXloEA8SOHibF2B9DNTAo9W+vqh4QVi44L+xOAyRU5AqOpwKQ9Ei8GYqc8Yaue5KVk0X+dIbOmJtdk3/s2GYNq89U6OQwoKP2giZiKp+Ikt8dcEdwPwgizmA6TicI070XV1gtVKG+gfViuDbSQvpt/EV+VJdjyMCkuRZScp66RmCBwPAHoxWaagEfyLNZYfxa4/GC00Qv0W6oqgjP1BdUXuBdmtmw8HqQmvrCrL0mYIMeoIDueOPMePbp4NlF+yZbxkxOrVjwQ5W25XRTPOUzgETR1c3YuI3H24pyYAwJyAP8Lo02PyXQ607lPU73dFNqmkRwkO0Fshl0UBiGVxbf5WBxI4KgMXn1NVyBo6WJgGRR9Ag5Z/V+TEpiPGxLZh4fGHH+BCv07nXjXRyDGeBn6Ylbt+GoKc+CerLWQIFixMNLMBsASoqINnBvOuc021cLkUOm1wqoFmj8BiPT0dp8xiCwXbpQRUdvpyxu/qfqt8DOUaEIjtKyiY5oxOXsFxbtmqKY9fzQcbdWjmFqQDeTgggE32sJ/QqAk+i0/0tHj3R oi/Ba5ib goW03jA7pkpFaMpuzXYwWctGjbdKeKvFy5VSIl3Ork9RG+dh8WPnAMctNBdV4pQql17Y8S8IVMdOrt+MNmOZ3qyMCWTO07Wt0nFQHFFVTO/UC22oNbkMXqTyVamUFkCQuhpsUW0GRQ5LhjfaqiuIkZRfwNzT8ET1l1B6IXiSyZZqesWvhGUOD4YbIVhNqBa78ZJl+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 10:20:51AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Let us look at the series of scenarios below with WMARK_LOW=25MB,WMARK_MIN=5MB > (managed pages 1.9GB). We can know that current 'fixed 1/2 ratio' start to use > CMA since C which actually has caused U&R lower than WMARK_LOW (this should be > deemed as against current memory policy, that is, UNMOVABLE & RECLAIMABLE should > either stay around WATERMARK_LOW when no allocation or do reclaim via entering > slowpath) > > -- Free_pages > | > | > -- WMARK_LOW > | > -- Free_CMA > | > | > -- > > Free_CMA/Free_pages(MB) A(12/30) B(12/25) C(12/20) > fixed 1/2 ratio N N Y > this commit Y Y Y > > Signed-off-by: Zhaoyang Huang I'm mostly fine with the code. The commit message is still very confusing to me, not sure I understand what exactly this table means. And you still use "U&R". Also I'm a bit concerned about potential performance implications. Would be great to provide some benchmarks or some data. Probably it's ok because of we have pcp caches on top, but I'm not 100% sure. Thanks!