From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B63C7EE22 for ; Tue, 9 May 2023 20:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FB056B0071; Tue, 9 May 2023 16:15:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AC626B0072; Tue, 9 May 2023 16:15:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899FD6B0074; Tue, 9 May 2023 16:15:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 779106B0071 for ; Tue, 9 May 2023 16:15:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 37697120947 for ; Tue, 9 May 2023 20:15:30 +0000 (UTC) X-FDA: 80771821620.22.5B9D0F9 Received: from out-31.mta0.migadu.com (out-31.mta0.migadu.com [91.218.175.31]) by imf24.hostedemail.com (Postfix) with ESMTP id D5DCB180008 for ; Tue, 9 May 2023 20:15:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hVlZyijC; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.31 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683663327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LkTznK2Z03Vodu7CHSj8IilAg1DvNfs35ZJK4M95LHM=; b=ed7TZEF9Zw+b/uvnivFS65KWj1HvzPK5KLlyNYS6cKliC//bBZOIbzbNTZYkNpyP0/A9t3 omPmZiOBu1HuUv/SmIPGPoeySnCPRH+YxTexE7tbYNgRhGRUME8UVMsFcqJWopUPTPVIZw T99OH9y7M57YSwmxAcxQqf/BLVWmZ9U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683663327; a=rsa-sha256; cv=none; b=e6cIOzMAFJ/LwWGSMBRhbm3CjIqxG5Tu4Xs8vzh7WzT8pgxOcqJR4WKRM3O55JzyWpFoPb NcYypITWgUrE2bpMkMTRxDjM8iRkMiEVh7s13EpVuuYS4Yt/4EINWlEE/qekW9klrXIVRj khekxmOVUUU1GeJv2mySnBdiuu6Ve2A= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hVlZyijC; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.31 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 9 May 2023 16:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1683663324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LkTznK2Z03Vodu7CHSj8IilAg1DvNfs35ZJK4M95LHM=; b=hVlZyijC8g1SgMMcQzMD2aPZOFsIXJukaHMQb7xAEZD0ie3kpmD214xSLxW6Qwe29rRInp iGi16+pUQ1aKH0le1y5M7fozdDuuDjk5weFK4WsJ2563X4AR/tPsnXme6t3R11oOvUVdxp 0emtidDzOsxOH1uEW0xSB7wFOIfH52M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: cc5ybp57rjfdf9wesrfcppipgjd6fxsn X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D5DCB180008 X-HE-Tag: 1683663326-825902 X-HE-Meta: U2FsdGVkX1+18BeT4mNf3AZ1Zsmrb3yl9mpJWmFrk5FQ2Tj3u2LL8Qf7uxKLNLmsIaS6IBljSL6oHIcBOod8wmDddWYC1MtoUu43sSuvMv+igTrnceSNFDxa6GcqRGkcmUa2z/WCQThGgqt8+sSPlDotj1TlwVlcVieKIU1i0anmCO4eSlXzWa91eRg6UGlfBnevJSpS3FXyiSRu6tvqk1mQnprLJZJA9IusaRVwL0QtaqcOjStc/BMjR/wF9RvOWPM/EIOKqF4wJln130BWBYre+ZYLTX6tg9/ndFLJHIgRvGcZVU11dVS6PnAiHEVINqB6q8knLSqjMRDHZqs0PNSEAkpW2A6kkh3Vx3Bfw8VH/cI6sELiVsrjyuMsl3T68H5L319qEMnAHVhYJ8zlQbUhdjlUrcnRjQChFfCD+4IIkPf46iGA9PQpR0rTgPtP/0Q5QQDH0hoZrOkt9JiNoiCl1ePnjgjGj1fdbebOVm/+S0TDtUVHZcpZDQCoIp0Gymj6NgVca8ov32OT1gd0FQjw8xIUBPSee2d4fmWyCUocGyAZlyagibSUZgJLYW9UAOldyDsOUK2G2fhFASeo+iZbn8AyKObS2QnXuBcOhJ0p1YIR/0pdZkiD51rgq95F3Oxg2aS0QtJqjo+pa+r9tCF9b+VHwKADmGoURWhQdekMS0aSx56H8SRKJOJ11bqOplzhevp4Ym8kCTbBCu5DV00L1io793DkRQQjjx55E3If6oe7YHuBf0uVmGgd8fRK8tXyc+DoNDogHyiLT800QXRlgzti8ujyR2lekxp3xzID6M9+X1kQ4/soeSez0hcaZIVBc2T45E4RdogqT/gqWMvoW47eBhk58QR4o9ZigNwgCaHMvvboKP3BqUgSz1cmmAOTYzcUg3IpJN6fzBXZrKl7bWo6F/5GlDlCP/+ezeeWII3zQ3UMsqj2Hfr0CIusbx1ig6L7f8iYsUiHwdI H2Iqn2J3 MPz+EzcUdEHDXVnOaeNl1qsFypuclMPMznCc3b+mADHNpX4qYfz20ZJ6FzJsCp6BFE3D4Rehdy3Dn3F6kaFMeYIzzaFvF3IaF4ZpvjZyyd7PL9iOSbUxd/iRFtqYo7QLNSXMgwq4ciOkjbWkFAqxUEStKW+iJSjwglpBCA+x9DEar0egmb6F9U9K5Hw2eAUZFVpnghHJ9rCHue8otcWEDRDHQSwXj2oXpZNOfTkkg9RytY7EdWZXOEKK4tT00Ck/3maR2VfEzc1P5OZ0kwaRVIGFIINgyydIPqrCH6YopU/43stry61j3+A71sohe7z90QO9slJbFgE4Xr5smamRikgqHr26AtKN5ptP9rDyrcQWqQlcyw6zq8GgABQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 11:19:38AM -0700, Lorenzo Stoakes wrote: > On Tue, May 09, 2023 at 12:56:32PM -0400, Kent Overstreet wrote: > > From: Kent Overstreet > > > > This is needed for bcachefs, which dynamically generates per-btree node > > unpack functions. > > Small nits - > > Would be good to refer to the original patch that removed it, > i.e. 7a0e27b2a0ce ("mm: remove vmalloc_exec") something like 'patch > ... folded vmalloc_exec() into its one user, however bcachefs requires this > as well so revert'. > > Would also be good to mention that you are now exporting the function which > the original didn't appear to do. > > > > > Signed-off-by: Kent Overstreet > > Cc: Andrew Morton > > Cc: Uladzislau Rezki > > Cc: Christoph Hellwig > > Cc: linux-mm@kvack.org > > Another nit: I'm a vmalloc reviewer so would be good to get cc'd too :) > (forgivable mistake as very recent change!) Thanks - folded your suggestions into the commit message, and added you for the next posting :)