From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E65C7EE24 for ; Tue, 9 May 2023 21:12:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26C3F6B0071; Tue, 9 May 2023 17:12:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C866B0072; Tue, 9 May 2023 17:12:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E48F6B0074; Tue, 9 May 2023 17:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F10786B0071 for ; Tue, 9 May 2023 17:12:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 996941409E4 for ; Tue, 9 May 2023 21:12:46 +0000 (UTC) X-FDA: 80771965932.10.991DDB5 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 699231A0010 for ; Tue, 9 May 2023 21:12:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="UT/piCyq"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683666764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=svGV0USSt7ecLCHRTXbLuwPhCwC3JPPXKAzLDLNlRjA=; b=eV3xtO780UVkg+piizvt4aiZWzIf9k3te5vHaIcgwmt3ROyZa5eAdOlbRRwyriLL/dTqIm VBlOBnoUN/GYtLjXH7c/n4izeyeDuCL5jCCV+AP86sC1Pg4q4LIbmurhI7YA/b0lUOXalE 6B3C1+GyyOdgo9ob6SOUsO3Eghr9qb0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="UT/piCyq"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683666764; a=rsa-sha256; cv=none; b=0ReKEFomwdc/hSZBgPWnpRNw2LrkTTp/Mc2/I1kqold72WmKcmsAFVcesZ0WwGQYyOiNGR f71MnTs5p9KCaSLrE65COtsHXgDvE4wktZK/gssjdLlfuZszZT8/HQlZdGV9RDoIE2qrov fTJL62I0IRQKlIuqLNtNwXlefElQM+M= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-643a6f993a7so3578527b3a.1 for ; Tue, 09 May 2023 14:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683666763; x=1686258763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=svGV0USSt7ecLCHRTXbLuwPhCwC3JPPXKAzLDLNlRjA=; b=UT/piCyqIzYoo+P2gSw+QQSyXT0S06eCT2Xlnjp6RY/huIoizI4Z37OkANO8EOPf0J 1FKeGRsDcihqTx55Tz1ahXEmVVP6dzwEjVwlk6WuSFffQ0TACXkSe+9wP8UAjcmARF1b rDAy/rKtPPCRaLJfJte0zBsCo8pGHosvS/Eijb+xnJLKumBuC5cKSGZu6Mz3hw1Wbk9q boLY7gSp3JIuzVYrSGaNiq/uag3s0MLcOIg6J5fO0xdr1qILObJbsId9/hnJcj0mqFHt d0SmEg0kkhd/bKibWC3sGGVnEGXfOh31xRyfsI72weVAST/OE5Oko9LHzeSjwMwH3uJN 54bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683666763; x=1686258763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=svGV0USSt7ecLCHRTXbLuwPhCwC3JPPXKAzLDLNlRjA=; b=XJVjaBW8T4PiObGz4oGgLsgnx1EABjIvTD7Saz989VKEqL4pfZc0ACiAyMnXYdk5kW 94UFGhaus8sK+hChbIKlaFi1B5h0NWjzA+ViGH33+rLkcOpw9KWVN37aPjt3fJqU5Xt4 zsaFYSB9EWAxwGfbtm/BvtB9YSSMY8CbD2+5tTcYSgggCK6t1/RmXWpttDPWqmL/1oWP NSqA9KuRy0KDtEwrEUeGMI0lOBe2WTAMEPs1ODTNoXAt3Owj45EkpDPe3wXcs22lZ52l mHhaU3rHKalBMrfHapNMmL6iAI6O8b6zIW49EU+4Qk+kEjcbBVCDEWDD6BBFjgHDT8MM t1NA== X-Gm-Message-State: AC+VfDywLHpaBhIZdHAMOBSxBB2nd5jFNt6HtnIhcjrah29Xz1y8B0z7 KPJAZufkWoirpfHbMVLS22I= X-Google-Smtp-Source: ACHHUZ5eWk0NpGNLDCVvDwN9Ku5AnbknilcOnjk0aKEKmCzXWCGhqSQlpGyrMrVu7tHz/auQMy6Vfw== X-Received: by 2002:a17:902:ce8d:b0:1aa:fc8c:8f1f with SMTP id f13-20020a170902ce8d00b001aafc8c8f1fmr19261002plg.50.1683666763082; Tue, 09 May 2023 14:12:43 -0700 (PDT) Received: from localhost ([2001:4958:15a0:30:3c22:a6a6:f3a4:12ce]) by smtp.gmail.com with ESMTPSA id l6-20020a170902d34600b001a800e03cf9sm2050041plk.256.2023.05.09.14.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 14:12:42 -0700 (PDT) Date: Tue, 9 May 2023 14:12:41 -0700 From: Lorenzo Stoakes To: Christoph Hellwig Cc: Kent Overstreet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: u8j8impa9n78od3k1tgdmhh1e8nypchy X-Rspam-User: X-Rspamd-Queue-Id: 699231A0010 X-Rspamd-Server: rspam07 X-HE-Tag: 1683666764-586748 X-HE-Meta: U2FsdGVkX1+Z5CCTg8n3YAsc1gONMypWgq2SjnlgupDjx+sG1H7EdhoWTZQtzC2y6qkz/yXipUXUyarh5yqQsAMRxf3b1BMAHiWeXR/Yen6gSAK36Jo/pvK60RhvPBxEWB5cSBz0bUUkxfH/gRedO+5RpdkiORbp9jCuf0YaSdB3TUwCd+qDKk2xUMRNiWh7IsO+etckdXX8Ix847e0/XDRNGdZgNNauCeK4z6xWZ+T9Ch3t60oqgm2UDJ4JiCLyoM+z6BV6YW89jliuGjjBAnbwb3hE/SrQiMLivASjurXQi0SdIxVk2S/9lAf2tgPD/y8TMkTEKsrwHX9i6rc6+zvfyoKsp2MlQfxLbOqlmkUIV+EjNNcgKzwtXWRrhdOED4EPiYEpW5vo2OHBBwOF7/F/WMgwV+u2GLFjaKWZfff2Z+bjaOKdUYqkreEnPeY9KrXbXfmI3LOeBQu0a5i8GO9A52RKwNR0TzPw3ZI0bkZ2fIjKycLgGq5H71kGP+FD+5Zh44KnBslG4wNbIpaXcX2mE79W4Fj+DZByQBFFM4wcmsJtnlTTs/xALFUQsrZUG6ehlvLQrDTWEVdEiuMcVhamkEtXV4SikCFlacAqsJz7bBU+HQ9ZT4rlCujbAW2NnihNeOuJvGQTt1JcFrg/H0QuZhYIN9wZvow0Hq8K2bqYh5UAjEJvFtjjXnaVvmqTT7JPydpjiL2q0E6k9lKJLXE6egHl06ZFkrvy6aqzgFmMGinJ3A4lRWBQ0khhAE3XU9cXS7L23Aiz70+gUIWQvRMo6U1mx/Owtxu3gVUY4Ao6C5FjXyAbz/d9ctAEIVA/U1yiS5tUy0iU5GoXqoBQ/2LDgfXD1EqqKb1OmJZZ+EAIZKp7aAj5ZyZVsywvmx5LrOaV77KZmKln7CoWtdublGbtdU7fjEDMXtxU58DL/vU6NkXp3e4YYOtORoGd5wGDF4/KnRNaKtSMWqFiQcX iRPyJrFD h/4QUlt6d8tMZlPtsOdGnkSmFZJd7pX+2Cc2DJMRZLb1Xtq+zbQFjEIBXfXKvYN30PwFK5QUbYxbHdnMLXBiqPStXWYk0MUYDemuNayMLNMWzyuQ8unInGAsr2ziaIaSc3LD7sw/LuByCKTEY6qP50y5dH21vxz2PH5HVDemM5SJBNdY1LJSy/6A5n8xzPqHBLP0gylzMkWNp1Q7JRXxbSVWndbsXnOmoXudzHfWNgA1TgrnKhBRGe15IRT1a1vbkCmXRoi+KlFllz8G7pyCYbGIAKXM4fGUjTCg9XTb2+Ed2zC+uXyrYpRzfXk0E5mwuvSJcmIa02i91bR3ZyF0ZgGfRtCDBdhpdIQGi58XG7qYqgpwOcOP8cjkb/78NSTvSt3mWFvC6Xq6ih/KQ1eLqctvjECTNgYgCtV7QoTk86ppX4TTXBmouEfHPsaLiZZL0ORSmehsn3bh8lnk2QbVT4V7+8uIED5PWR8bFTwTBrwIjGtFeIdejuWb0/G+DYYVcTMMjEcEFfMlRY/v12joVLzF6Pfyx6oaw3K/ze2/MukoG17aoqfW0/mbUSbPtReMzEywu9LcIb+3OJ6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.094601, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 01:46:09PM -0700, Christoph Hellwig wrote: > On Tue, May 09, 2023 at 12:56:32PM -0400, Kent Overstreet wrote: > > From: Kent Overstreet > > > > This is needed for bcachefs, which dynamically generates per-btree node > > unpack functions. > > No, we will never add back a way for random code allocating executable > memory in kernel space. Yeah I think I glossed over this aspect a bit as it looks ostensibly like simply reinstating a helper function because the code is now used in more than one place (at lsf/mm so a little distracted :) But it being exported is a problem. Perhaps there's another way of acheving the same aim without having to do so?