From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FFEC7EE22 for ; Mon, 8 May 2023 14:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C74F06B0071; Mon, 8 May 2023 10:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFE916B0074; Mon, 8 May 2023 10:22:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9E706B0075; Mon, 8 May 2023 10:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 96D5E6B0071 for ; Mon, 8 May 2023 10:22:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA97680641 for ; Mon, 8 May 2023 14:22:28 +0000 (UTC) X-FDA: 80767303176.17.660F83C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 895C616000D for ; Mon, 8 May 2023 14:22:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="eVM/8o1a"; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683555745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1+CnzOGbtXpZAgNtp1Sbc0yNA//AQM0s+VQt27TC/ik=; b=yV68nnEbCxZqIUVuqVBY9ym2vu1cGLd4uqj0I07R7GptHy19m1Ha75Ns0/M9jh3pPz3Hkd q8+K8B23OPckLgcle642WOV6yDgRHbtgI8HdQd9eBE2Ls2YaZa9IMmIWvwvUmpRlK12TG/ cTtLfQ/lUZuYCLMLQvO9dERuWVd7y/A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683555745; a=rsa-sha256; cv=none; b=g5CHWdxcsYvXqLkcVG8i3tKQv5PXPFcW5KY3jxpSfnDpnyaHKglD5yM1CzPD6AFgSA6LpQ xm/Agziu6I4chnhrsQ7hyUgKS9nvUToHFo9BIpX7j9uPtcyR8E/w3UW8FkWqbJ8xnKfaTJ OIOVWyokuoBCfySgW4oS5sZzGvvhKlQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="eVM/8o1a"; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0FC931FF4C; Mon, 8 May 2023 14:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683555744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+CnzOGbtXpZAgNtp1Sbc0yNA//AQM0s+VQt27TC/ik=; b=eVM/8o1alDoqtQpkgMPhmAod2H5Fc6iyKsQDNKeqMLlHo/xPCR35JDYD+d+I7w4UZ9kWH3 VCrzjKQvEPzPDVRetbxkswIOt8zxpkW/T4CbCF8/1fcRlTaJQbpnBLhdaXRKFVAV5Eaatf xxnm38qzJa8/0EbQEiMAH7BZSOHR0A4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7FAFE1346B; Mon, 8 May 2023 14:22:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jLHpEJ8FWWQJCgAAMHmgww (envelope-from ); Mon, 08 May 2023 14:22:23 +0000 Date: Mon, 8 May 2023 16:22:21 +0200 From: Michal Hocko To: Haifeng Xu Cc: shakeelb@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm, oom: do not check 0 mask in out_of_memory() Message-ID: References: <20230508073538.1168-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508073538.1168-1-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: 895C616000D X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: ypm8iwwbwnzyuum5d4rx1qmsxzkhxhso X-HE-Tag: 1683555745-319064 X-HE-Meta: U2FsdGVkX19X+br5RTiLlulLBxaeu+LiyW8tcubvvmgkZdBu07CJPay9vRbi8oLu88HMkxa2WBNBosPFAs5m3bQgj/AOHyYZds7/CS04tw/Oc7B2j1ZwAKNMLO00ICDPSukrUknaE8zq0MydxkdxkRLAHGOpC5g9xp6T/v5l1WFcFNSrzdTN+ye7awOtZ6lCCU/ytNmRQx8PoE8hCz+xIDcoNuv/us3p1JD6pPYz0EsuSYOUX/rCdumzGGv8cns2BUjteit/RruUJCV8U2erQk00UTRBdDl43kf3RjOiI8hngOtoiyUcm+k7U+7YljY42VQKi6R7XKUaC5GlOeWEJN9ngzTZOPigbY7sby93/tp9P3XDbjZDXRHQmmuon9e7CExJeKydMIPZxbkbve0Nj835zIPJSnyJF+RxoTObGg/1wB92HR6NFFmvK47SR0EI6xnq1knbWd/hHFk8bXBQ8SFzpa2tuy3CpXsqsh3V6l7JNF7gMeZyIExcODPv3yW4uLQ2lrQ+4fYtPJSNzuHNt0xU8MHSYiIOZgXEXxz6jYbKyDqHwdHqwufwvHyrvOdZ6qg3tspEM+lZbg3H7t4LlgW3QWmS3iavwK9BQRD5cbMXPx6d5wkCvK+2djsGzfd1tpojEQ/EMSuFnkxQzSBNPaEf0KYyV6CZer+ERkl2t0YM0ckey0nYwIZzirrEpOUQIhQmCKK6PZtviHeM6+71G3yfMwLNjLt+F7cLYinC7v76rIRBOd/LIeHzexaI5ZRqmAyMa05QWgUPlv9+hRXsvOOb6Ojjb4vW+S5OYIoEWV/zbkRAiHJRvhxl71LsgXmaYRYV/Q9AjKcHwzNlp6bsBpoCfW/UTMU6zpJD9i3NMICwJD8LOc71OArg0H7JqOds+EvYgMxO/R425gfw9ounPS1k3hnFyP2rZD8ZHTu/XGUiU9VGq1eU+6XaUeej9/Fpa549Z162GiYN2HtTwJj X1fZzvVD gEHJgo+RJeNqzr94N2rEgAXhqDAUJpGlhqDakqonQXkQjf9E7PBxuEZ2YvEZaMh1kAbxG7ZrbFwjES80woo7wfXSDcN5A+vN7H6qYsEWs78YJUTAwHICRXFewqc2E+ErLjsUwzQWoWVN14Uji4jxGl+QHlvrEBvvjc1IoV6btLle2Jr/i8FvCZXESFb6lW3TPamRPIr42PlX7YoibXABuVF6+WwC83qfYeXgKSfcN7jHwV5X3cjhpmfmNnSxiiVylMiUiY09efJpSU9Ybhm/bzGamv3ozo9VLabxkyp7CSdVCEycBwdoH6bb0dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 08-05-23 07:35:38, Haifeng Xu wrote: > Since commit 60e2793d440a ("mm, oom: do not trigger out_of_memory > from the #PF"), no user sets gfp_mask to 0. Remove the 0 mask check > and update the comments. > > Signed-off-by: Haifeng Xu Acked-by: Michal Hocko Thanks! > --- > mm/oom_kill.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 044e1eed720e..612b5597d3af 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -1130,12 +1130,10 @@ bool out_of_memory(struct oom_control *oc) > > /* > * The OOM killer does not compensate for IO-less reclaim. > - * pagefault_out_of_memory lost its gfp context so we have to > - * make sure exclude 0 mask - all other users should have at least > - * ___GFP_DIRECT_RECLAIM to get here. But mem_cgroup_oom() has to > - * invoke the OOM killer even if it is a GFP_NOFS allocation. > + * But mem_cgroup_oom() has to invoke the OOM killer even > + * if it is a GFP_NOFS allocation. > */ > - if (oc->gfp_mask && !(oc->gfp_mask & __GFP_FS) && !is_memcg_oom(oc)) > + if (!(oc->gfp_mask & __GFP_FS) && !is_memcg_oom(oc)) > return true; > > /* > -- > 2.25.1 -- Michal Hocko SUSE Labs