From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54FD0C77B78 for ; Tue, 2 May 2023 18:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C366E6B007D; Tue, 2 May 2023 14:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6E66B0080; Tue, 2 May 2023 14:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAEFF6B0081; Tue, 2 May 2023 14:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 93F986B007D for ; Tue, 2 May 2023 14:47:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF415417EA for ; Tue, 2 May 2023 18:47:12 +0000 (UTC) X-FDA: 80746197546.02.75CA0A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id CDA1B40E6E for ; Tue, 2 May 2023 01:04:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXpDO8c+; spf=pass (imf01.hostedemail.com: domain of ming.lei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682989538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ee9kbmLrY2Y7aS+ZkEL+0QK6onncfphaK4NZ0iubdi0=; b=KPgquMbWxADTpniJzftzt8crXdCdgHx4zTXNSbqLKJY9R9sMac1OuNm3rMiEagHt6UETGf Wy2s6P5jqUOc8r5mV3FRZ/ci5xkOROTA6UMAu2OsckGZF4xzjh+KxLrseihRaubeZsm/ka NCZew7g0iyYgr/n6rxWVa8KaVokHDZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682989538; a=rsa-sha256; cv=none; b=jyj6P3td8rOs+eNT3VlojHpujXdLfj4NyF21afYcP3l8WqTGi9utTt8vrZXEaIdv7doZGl Gexyfkugz0qIQ6skbbYXW+jNVh2W/SNCrwxI21/dyGMAj0ZrdUo3gJ1GG2QLiNsEEeaqSJ 8ZrQnobsN9Rdd9xAMjEZlzp3fHYnWnw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXpDO8c+; spf=pass (imf01.hostedemail.com: domain of ming.lei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682989448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ee9kbmLrY2Y7aS+ZkEL+0QK6onncfphaK4NZ0iubdi0=; b=SXpDO8c+0/w05s9H0Zuql3dp4DNcDzer7p4sGDRnQxG6oaZKhRHt1+9VtknT3Etx95yqdG JakP7F0neObPBn4/oksN30tcyiO9Bgx4yFrR4duFyb1uW7ET6jrTHJ+FqdoHImT341LseE VVci4gpIT2EKzuq5mLadJxzOdmQYvjs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-s2Q55i0OMv6b0B-q6gLVuQ-1; Mon, 01 May 2023 20:57:46 -0400 X-MC-Unique: s2Q55i0OMv6b0B-q6gLVuQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58E6E101A531; Tue, 2 May 2023 00:57:45 +0000 (UTC) Received: from ovpn-8-16.pek2.redhat.com (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9082400F4D; Tue, 2 May 2023 00:57:37 +0000 (UTC) Date: Tue, 2 May 2023 08:57:32 +0800 From: Ming Lei To: Christoph Hellwig Cc: Theodore Ts'o , Baokun Li , Matthew Wilcox , linux-ext4@vger.kernel.org, Andreas Dilger , linux-block@vger.kernel.org, Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Eric Sandeen , Zhang Yi , yangerkun , ming.lei@redhat.com Subject: Re: [ext4 io hang] buffered write io hang in balance_dirty_pages Message-ID: References: <663b10eb-4b61-c445-c07c-90c99f629c74@huawei.com> <20230429044038.GA7561@lst.de> <20230501044744.GA20056@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501044744.GA20056@lst.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Queue-Id: CDA1B40E6E X-Rspamd-Server: rspam04 X-Stat-Signature: dg3frn976upiy8zrtjwngfbmmm4ubkzp X-HE-Tag: 1682989496-714607 X-HE-Meta: U2FsdGVkX1/np6wnDQ5t2PZHUSOpfVQnrtpEaBWstWNjmzVNU7KylduuN65ljlbwM0FFbH9SGbyZbc4BbGmo4VT5GHBt8sbUHdN16aOR9/0z1A29zUGionwmTK3xgpNMOm+QE7uHZPWsAHtu1DjKu52WkE3m/wyGBmdxL9xfqMfHrgVlbRLo+eIpw1QU9bWVf2pv11IK3Rw+0X4QcHCmnWODPLnKhzGjo3NcC5h8VVJQi3wksIyGDPWlmME+UjhBbEoUcSiGLEOuPSS5A4X2rcO3YCO5hGWncFCI+yXn239Vx2eFp4HVr5k3HZ0vNyB7r7LBNEa2EzwL0OVqxKuS+Zq7sE2RYjSlHpmLrP434tX2+5HtzpSuYi+/kioaibFBw2fL6YsM6W1VJXReWQONAFOGz1Zqj9akjF2guHP4xzQlOriwpnDczoIe+Wwdno39dERNlQseVlEgqwQs43Fr4g0GBDskqpErE94hkAogTMfjB1If16e3FmlzRx0T1YMV53GMAQdHXK0mnvLd2imXbdf8s0pSoC7ZkbCpqkL6CQOglMPzg2GtgUGscPI/ScUecdu+gVl+dfBV1rMdnhkoqyp3LWRFWldzj8xhnlvv4/dbi1/8bBbRiv3Y+Wie1Sy4I6IUCx6wedt7vtNqdQTvtskb3uHGKC4g3OWOVCdKiiOTQbafmgMVVjZ69Rb3ZIq3c+VGlQi7HoqqJj3SmrtUx8cCx1+G5FXEPBWKFGzsnDYZQPHoe/Ye2xFcc4Fj8yrVBd6B2JgjdPptXgTJMEAV59+tNiZsAoRQ4/PUYGxTqTmPeBgu93m4Jt0KPkCz5/N7wBISvXti00Wstea4XctesvYWQyXAmg1WVRVy0hzIgJ6CSX0z2D4SyMdwrsQnhADwrYT1ejf1+GH0FSYITWv2bRvVOZCDbIAY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 01, 2023 at 06:47:44AM +0200, Christoph Hellwig wrote: > On Sat, Apr 29, 2023 at 01:10:49PM +0800, Ming Lei wrote: > > Not sure if it is needed for non s_bdev > > So you don't want to work this at all for btrfs? Or the XFS log device, > or .. Basically FS can provide one generic API of shutdown_filesystem() which shutdown FS generically, meantime calls each fs's ->shutdown() for dealing with fs specific shutdown. If there isn't superblock attached for one bdev, can you explain a bit what filesystem code can do? Same with block layer bdev. The current bio->bi_status together disk_live()(maybe bdev_live() is needed) should be enough for FS code to handle non s_bdev. > > > , because FS is over stackable device > > directly. Stackable device has its own logic for handling underlying disks dead > > or deleted, then decide if its own disk needs to be deleted, such as, it is > > fine for raid1 to work from user viewpoint if one underlying disk is deleted. > > We still need to propagate the even that device has been removed upwards. > Right now some file systems (especially XFS) are good at just propagating > it from an I/O error. And explicity call would be much better. It depends on the above question about how FS code handle non s_bdev deletion/dead. Thanks, Ming