From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF62C77B7C for ; Mon, 1 May 2023 19:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA4E0900003; Mon, 1 May 2023 15:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D54C4900002; Mon, 1 May 2023 15:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1D4F900003; Mon, 1 May 2023 15:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B499A900002 for ; Mon, 1 May 2023 15:36:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 708DA40846 for ; Mon, 1 May 2023 19:36:01 +0000 (UTC) X-FDA: 80742691722.21.C072A63 Received: from out-60.mta1.migadu.com (out-60.mta1.migadu.com [95.215.58.60]) by imf19.hostedemail.com (Postfix) with ESMTP id 85BD01A001A for ; Mon, 1 May 2023 19:35:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uotwq971; spf=pass (imf19.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.60 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682969759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hpWnoWbnH7XHW07GL5HN1fHIxDy9SUudHHmRHAQgRBM=; b=Ph3iJTkhUwURzxkmQ8NPHgkTE+ZGEIHOq+4OBDxfOXFADRNc8mFA7yRtJEmyRgY1cakKKq flfqC63zbUQrxLifiG3Bs3fBVi8kawYGF/9lBxpoQkm8BmUMzoTP82mr1IJI5nvWwHJEKQ t5xewgyNwHlMqWAGaPcgdWC3w9GcAJA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uotwq971; spf=pass (imf19.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.60 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682969759; a=rsa-sha256; cv=none; b=8GFAgeAaLU1Pjxuo0lDsuMoDsw4CJGCePRovhqXFKl2ZpeUck4WMW3ruL/EoAX2pJsWLTN vNh+0UyNGwQpjMG0oCCFeI0/7CpAouKcohLHWuE88JnzspGDXm1H+9ZW6/BwgqYtnGYYMD otHAWLf2PmtR2g1f2KBy0egZps8hBes= Date: Mon, 1 May 2023 15:35:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682969756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hpWnoWbnH7XHW07GL5HN1fHIxDy9SUudHHmRHAQgRBM=; b=uotwq971HnVfizoutRaYv8+Gg4dprWBpXM6BezfvimNLzl00V1oTf1QlaE+u3WeZsMeziK C5H1k4WMH14ItFz/9ogt0J+TmpRUyd43sqLYCT6f12j4Qtui1iRdfjc+eiHTz8nOyq/OnG 5EPIGqnHT7Xhl5AP2WMXcgnbqlqcl8w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , Noralf =?utf-8?B?VHLDr8K/wr1ubmVz?= Subject: Re: [PATCH 01/40] lib/string_helpers: Drop space in string_get_size's output Message-ID: References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 85BD01A001A X-Rspam-User: X-Stat-Signature: 7pjm5md6au7dss41spz3aztikgi36q1r X-HE-Tag: 1682969759-428615 X-HE-Meta: U2FsdGVkX181ov1fWKUB2uFZXLUNO7xTWrnKfBBHvZQ/b1joHXi3EMbn5rhuqSRLkyEo8sY+AFDrj8IBQTWZtmmvoPYSaSmMmeSy3U0ORNVZsagXe3gKKDYr2wbS5NxD2acE8F0GvQka17XOKqmKgv7JHibdqIi4HNWmWbZ7IRKBv4Nt4+THX3C6k2fWrVkv21NfL3/1gRk0t77tjzSYeqbOIQmVdn/0q1+Km6MBOSS4XN/a6E7+/Pp3X+PORyRQp9SJE5eZHiXyKmaVEm2f3GhZZEhhf6Y44DcHXX+Eqo1Zi9HTADoM1S5Ia1u4Q2kMdCm/Mu3Xrbs7U1eda5vneRMJUSWDgLEOpZsV+O071Sgf9mdWFfDBo9qyc9qJH5gh96TvykT7QydSVrKhCDbWOMIX8dbAXoTa0pbNTUXeZcHTkmTW8BTaElSkSbeiUIumKbAGKGGIkB3GDiHid+STOABxbmAxl/aRV0+/kNsyh1GB8DLk4di+FAKgf1XakpZemT1AbXK5VaEP2frrxCZKZ9VTJ0AnONkaS4Y4qELKnyr6ZlNLDOS4FoabiheDtoUL8fImB1m1UEtnkNOh5/temnQ6Rb1QAMetB6hCxVl3u562prpMCy6Va8HEH3A5gNnKFBHFjF0urzdAwC4aAOLZ6+pOeMBs2vwGQmwPhGAEYch0yTPx3K81Ss4S0GiDPc3SlO7Js0V5cig1MHcrxxpGz0Jlv15nLf6Bvbufi4tOBR9TXbhPRSJPZpyHQbIyCLrJpBtBN0aYr1ZODnIdaZFFlXKuxkYd3GAV+RfxNtTVVT5LVZa+4ffrFL5plT61ybCUmnZUAf90slIDzrHzmloH7E+mkvBrjbnm52Q42jfZAImM91huYObG9WqVWZK+9lQGGbc15vPg4ro2oPcDS5Lo0DNxr3lzl7jeb3wxrmEg98xJnHZEgjkeDjiyiDQTfBo6Z1AG1sNjf3nd1snMCwu 2WwBhO87 zdkppDv5CO77Hpdijw0qQ9C08dA8PXEmgsy3lGDFVEShrvDmuhDJzU7+EGYdf3ACVkVYT0yStNCwRmj2aQ6p8BQ1z0S6xTLpjJJOwDeRcZ5yJQOsjrqZ/wSRYyWcu1AHcblhDakxtch0MyKvmd2MuX+ZcCIn+kqBz5utf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 01, 2023 at 11:13:15AM -0700, Davidlohr Bueso wrote: > On Mon, 01 May 2023, Suren Baghdasaryan wrote: > > > From: Kent Overstreet > > > > Previously, string_get_size() outputted a space between the number and > > the units, i.e. > > 9.88 MiB > > > > This changes it to > > 9.88MiB > > > > which allows it to be parsed correctly by the 'sort -h' command. > > Wouldn't this break users that already parse it the current way? It's not impossible - but it's not used in very many places and we wouldn't be printing in human-readable units if it was meant to be parsed - it's mainly used for debug output currently. If someone raises a specific objection we'll do something different, otherwise I think standardizing on what userspace tooling already parses is a good idea.