From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAD8C7EE22 for ; Thu, 11 May 2023 23:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14D76B0071; Thu, 11 May 2023 19:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEC016B0074; Thu, 11 May 2023 19:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDB236B0075; Thu, 11 May 2023 19:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD80B6B0071 for ; Thu, 11 May 2023 19:33:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9EF47A04B9 for ; Thu, 11 May 2023 23:33:02 +0000 (UTC) X-FDA: 80779577004.22.785D9A7 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf23.hostedemail.com (Postfix) with ESMTP id D7554140016 for ; Thu, 11 May 2023 23:33:00 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=m1mTn2XP; spf=pass (imf23.hostedemail.com: domain of 3K3tdZAYKCMAykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3K3tdZAYKCMAykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683847980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nS6iEDTOVPKXI4+UjpZyIPwKEGgdgovZohVYNbQWeU4=; b=UgWF5KHKWB7dh/b3JPWKhi7QTNjC/pr8TUmbDXtU3pDsZCDajsGbxIUVFcM4tULsyPc8Zw oR3olEVFl3IutvJbvEcn+7WQkmf4xz+AYcfPgou3dwKz/BtW1bV5h51JO2HzbjwWetQA3G OP5BDWWZGSdSvJ+SFBRj1h61yXGeGlE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683847980; a=rsa-sha256; cv=none; b=dyXi4hI9W0XPMdjpYgX/vHwZeg97hjbg7maqhx0FKlgxt+sLql1+tQXdn0ymWnNpKBU5jo 14GqvAAiuFpLmOK5J2nyMpEgB+LMLlZPAUluDyR7CBUedkvIx9AXdy4LT+/GQLpPp8F1iQ L0OJF3OqaByJXHzaUutILANYYmU7T+o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=m1mTn2XP; spf=pass (imf23.hostedemail.com: domain of 3K3tdZAYKCMAykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3K3tdZAYKCMAykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-b9a829a3de0so20605703276.2 for ; Thu, 11 May 2023 16:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683847980; x=1686439980; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nS6iEDTOVPKXI4+UjpZyIPwKEGgdgovZohVYNbQWeU4=; b=m1mTn2XPoYvYXNYJmfzWbIDXWq4bYYqRuSCzsqBrmXOyn0iTSW1mGChChBz38nWBh0 /YSu9i0Bb6HmByvNbI7ZobUCRNgitVQYeYkZ28Olsr2kku2etC+KRSnaLV37gSC9NNoE J3UlQ9E/lehVq2TxQmiEHcWIyLQKKBpYYY+dBzQvNKqGITGF765K6JIP200Gg32JpwLO H+2eHiQq2bHEsJm3WaQW1ox9sUuCfjgkFLErfCQKAD4zQw1/4UOVGm8nGrJaI+HIZFdl 22Nup8SaEUuyrR8htD0XbmubnyMDg1dnO7tQPh1/wXKOgcuzyWMD1+1f2n3evlgiQJVg G4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683847980; x=1686439980; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nS6iEDTOVPKXI4+UjpZyIPwKEGgdgovZohVYNbQWeU4=; b=SnxTUMgFAWdhRLbKQkwxHj3e/zLQyYNkFxEWGDp2dfnyyHv/kL5f5YPOQ3AbbM6FD3 wWYfRM6oPBVdH/yjrAmtDoBTJHbnuyOQ02D/YnrUXxTDOCdKFRa8g7HMaVu9Xudv6fhx 64Pczp1AIvKqyn+MSqev8PHU0+kc4M6QsxD88au/86CdVs7chkLZTYRIfuKzuHeZU4Dr /kU6JCUq/QhhFLj0na5etCrloh+wanQYE2+LwBkv2aodV8wQPx8XJ4fnbTy+CVE4Rg4U 5NYy3SQ0GbZwKK3vO4dF0YGvaJOd9v3OaV7febxtFcxYlEDhsMNXYyhqP0kP5SF9o48j L+Kg== X-Gm-Message-State: AC+VfDxr2q8nVgRHXBd0NHhAGYR1s28adc8IRfgDmb4gbG7MWG0KPaQ2 hkLuZZI/78EpG75Mr9ffLhWdqqunoOs= X-Google-Smtp-Source: ACHHUZ6oeZZ4oIRO3xJnqGtROFKuNKUystxK+0hUJRXTtXXFtT43eUPsNAi2aQTXHdTD16qAMRx6ZKAEsJE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:188c:b0:b96:a18:1b4c with SMTP id cj12-20020a056902188c00b00b960a181b4cmr10800373ybb.13.1683847979833; Thu, 11 May 2023 16:32:59 -0700 (PDT) Date: Thu, 11 May 2023 16:32:58 -0700 In-Reply-To: Mime-Version: 1.0 References: <385016f9-e948-4f7f-8db3-24a0c0543b3d@amd.com> <55e5f02f-4c1f-e6b0-59ba-07abc4d3408f@amd.com> <81037a58-6b5c-cde4-79fe-3686d9b8a551@amd.com> <7fb25176-3752-1be3-66d4-a7f5a0e1617a@amd.com> <682c0bf9-ccf7-9660-21fe-925ef63c5fbb@amd.com> <4c642bd1-5f1c-292e-398f-eed699db590d@amd.com> <65cb8f0f-7e8b-6df6-6bb1-a9f1add027bb@amd.com> Message-ID: Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for SNP_GUEST_REQUEST NAE event From: Sean Christopherson To: Dionna Amalie Glaze Cc: Tom Lendacky , Alexey Kardashevskiy , Ashish Kalra , Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, harald@profian.com, Brijesh Singh Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: D7554140016 X-Stat-Signature: drkwh8pmfmp9nzpddnr7ydw43oqi4wt7 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683847980-149331 X-HE-Meta: U2FsdGVkX18ye69KNepwcdNmfy5Uzv8ZKEYwn5RD6Qd0BpumzbIhODIZ343QcnFrVhn/fElU7O6jhIIZgnCbLwlhsEwhXM42S2WDmn9679N9++bNhGA0uzc7LmEKYrgIQixxiOBIPr672DS9SRqvlxy7oxYhXkkh7/KlQcHrNmZKPrEr4pDJk0l0LuWsRBJO5NyCMj46eOfW7NhC39UZviJpbqckAFfMknxEIFtlagsUqXdBoYytR421vjFd4taiN1ce+LMTawNWEloRew8WXpRvkGeEsT1xIpgY2grKjgYNqAO4OM0/Iq7JLUxP87trlCyvwVfrAmXT+NX3ijc9OoMgOmCNzkOLtX1e/DBcXkjaeqh5SuBUA7tyrkV3SLuh2Q6a8G+IQ8dJ7bvbsgWQQxrJvL7WLGPjj4Der32pk+GAmeNo1QoxbkduU7391NU9PcTFBIK5pl2Pbg34JBRDRXJs3mqwPD3+FyLqQq5fFCcn+QvF2Kud4vHg3owADWfNIbPhRi3jtDm8V6JJNGfRtPgibJxZX7ZvPYNruVVegMgnaOW3zTCmFqVtfZZyz5sI2oEsa4zSsRoesx/nsNPcajery07psZmnoFkF9u1DUgoQTsePXj8CSV8n1X1KTWTC0XCODS+vf55bMsS5hJE5B9d/ucgSYkNN3POKI3/lc8efi35XbuKtkJu3mxVdOGZOxoY9BmamqkQDL2dpuAeWOTp9PxB5jMPWLJJAgvqnScpGahCdFwGOw5Oaw6t1gEtpudXbIVHYBezT6BJrNc/mKiH6QMQlOHbOQofyIr58aOLDQTBytNlDfSF9v47wLqOtdoSiBJliY7R7mtcAgLBI2ADBcXEui7WY6Ywdb46YS+GY8ko1ys2jARbI3JXZaeyAe6kQ5KhceyUtS/58kI8KgnWfC4ENBARQQhKPCGvvfOmqbN+0IxgjZ/DUih6OfqnBTfBZsiOSOXs3EOeiVCN FyT9xF7B Iz9LGE80N5dc3Q3hyqZPk4j/w8oKdcjTPfEIje0zUeYZb6fqUCBAXjIQ4kZRy0y+T0bpxmeXAyLdDJAdbe6DkwgIuUzIgz2s2QzgViqnT/s/70/LB8kCgKdTYVaLvZ9XDl+D5MEUbPu5U0k+LG+kKt4lbnOP1C6j3fxSfYKV676VO3NtGVnrNXxdy0303/YWO0jfcHhbXjudG4GAenYlrWVNGdcW+Qx9kct0rA8GDQOQC0J2qf1l2AEUIxcyXdQD3w7er/93L4Zc07KyA/hxL73L0BmzfIM5SQ7AwfefFiJJLsPGNVu7Ob/pl4dqSbFLB47gPQyIODK7WgOmUkV5//1V+h35ikrCGKVA9Ed5QNTNvq172Z4g/ktGOUH9O2UJMulDcmWcv2sBEgA3u9wROxK8mlAX8/NujLB0rmhPqxkSk3psHsI3BBhHn9R1hj6jD65o1UwHbGtMp/bcD0ian4L1l8SOvWdTgQWJeTopuE+h/Wk/kBxbU/CKAMk2z93ycIO4TMTXUHmDv4gUZRoj+wjnh1lducNxtaPqU7KX+PYRnNNr7XBfMyePAJ3skfHU0ddojri4pmqooSxzX5edQQjHOaWjrg0ARSebA037OLIYa7c1iVB5I7+4Nn8NISgs+vjFVr1ZvgaELuuxY3iKQk09fiGcnroVMhAlNxWpimmZOX0ibfCPaJHWCT/r5oyUihv0p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000092, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023, Dionna Amalie Glaze wrote: > Would it be okay to request that we add a KVM stat for how often there > are GUEST_REQUEST_NAE exits? I think it'd be good for service > operators to get a better idea how valued the feature is. Heh, it's always ok to request something, but sometimes the answer will be no. And in the case, the answer is likely "no stat for you". A year or so ago, in the context of us (Google) trying to upstream a pile of stats, we (KVM folks) came to a rough consensus that KVM should only add upstream stats if they are relatively generic and (almost) universally useful[*]. IMO, a one-off stat for a specific exit reason is too narrowly focused, e.g. collecting information on all exit reasons is superior. And no, that won't be accepted upstream either, because for some environments gathering detailed information on all exits is too much overhead (also covered in the link). FWIW, we (GCE) plan on carrying stats like this in out-of-tree patches, i.e. your request for stats is likely something that would get accepted internally (if it isn't already captured through our generic stats collection). [*] https://lore.kernel.org/all/87czp0voqg.wl-maz@kernel.org