From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA35C77B7F for ; Thu, 11 May 2023 15:32:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E436C6B007B; Thu, 11 May 2023 11:32:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBC76B007D; Thu, 11 May 2023 11:32:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CC96B007E; Thu, 11 May 2023 11:32:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B2FD66B007B for ; Thu, 11 May 2023 11:32:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 670921A0D8E for ; Thu, 11 May 2023 15:32:18 +0000 (UTC) X-FDA: 80778365556.26.C63C872 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id C374E140010 for ; Thu, 11 May 2023 15:32:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wEQNUTAc; spf=none (imf09.hostedemail.com: domain of BATV+80fd488dbb3c26046a73+7200+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+80fd488dbb3c26046a73+7200+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683819135; a=rsa-sha256; cv=none; b=IPzZkz7SDqPsL0LtKGX1IMlMBzQHS7OPrlY1WNZGacQ59TIfFwPUZ6mw0W7x9i3N5gc9HF FmkpBY9DZbkBB5Q9l6Es5aWI9X1MizLNfHLeaJ3R5KgWxiDU+qJKgdi17Q6T4M7J1FUFt2 167qfKNyAd5kPKP8h/oEnFA51GI0UY4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wEQNUTAc; spf=none (imf09.hostedemail.com: domain of BATV+80fd488dbb3c26046a73+7200+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+80fd488dbb3c26046a73+7200+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683819135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ukarEjrht7JhMJxsWUDK8oALIr9FUvFh7Sj9Teu/1Wk=; b=x6EcVptHZqX5lAPxNofukquiyGfNJjqwMYkVosrZxGDR0huitCUik39C0NOEhKYckE83cm KJYBvzcZlZcTyRCqZqVre0iM4y+jFS9GwUHFVTZlrUprtSmv0WNwbVq+lu9qGjg9HjoyDQ 2Q/Bon+AeeANa7KGEUb0vWS/t8zPGHg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ukarEjrht7JhMJxsWUDK8oALIr9FUvFh7Sj9Teu/1Wk=; b=wEQNUTAcDAM2o1nSwW8TRDfzef pR2hm2LdCvaF9/3/ZGKV4hA2eHkUo8SRHXan5JeOGeinnWQ4sztTfMDIqVB3bxU5coTLeVs4EKgX4 RyV1i6KPTSC0T26g1h1aio5Zkp4eV/opt7tCMpUOMUtZ+4yudzHlzf1bhb7XYWnHV4cPBSSIrpdcv r9Kq7LlzKTyYnYBPG6Yyf7FXiBlgkGMwPkIFStRNsNISQhY7lb7NaeYOBqUbYb6VY1ANG03l6g4CZ E2NQftm7xEz7YJ4dVuFR0I4WJhtLUEOodbkZ8WCNBdQalIL1pNTEBQKMvvNniuqegBmDKNLp2do+u eG4S7bmQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1px8Gv-009DVp-09; Thu, 11 May 2023 15:32:01 +0000 Date: Thu, 11 May 2023 08:32:01 -0700 From: Christoph Hellwig To: Ruihan Li Cc: Greg Kroah-Hartman , linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pasha Tatashin , David Hildenbrand , Matthew Wilcox , Andrew Morton , Christoph Hellwig Subject: Re: [PATCH 0/4] Fix type confusion in page_table_check Message-ID: References: <20230510085527.57953-1-lrh2000@pku.edu.cn> <2023051108-lens-unsocial-8425@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C374E140010 X-Stat-Signature: qzpqc6awfxu1moyy3tfnb3ypwdmbu5ef X-HE-Tag: 1683819133-351889 X-HE-Meta: U2FsdGVkX192Xa1tqmsSn5l/uGhfc0ZmxsIbhvEU0Qmb4YHKAdei2jzZXS1fQj+IVdoVQnUplSj+W6vdVWATEIUXmEB2LZJQSvLqQH227WnJxkjPzFVhlH0dXKODWEEWhgjNWGBT+stH57HTGEB7dDoxEGX1Yn8I/uts0dftRasOIZQojKDr4gTRzee8RWSanXTnsFshunhEy6zLhmWJHVr4w09mqYOTrUcLuF4iAw7gqx2Ec97KOxSb8sSuODk61vd/0OcQDGIlBEfpc2Ynt3JS6spHD4ZVEGPNRzO+Ytfo16+yDrJoymWpWyCgOw+ZDEDC+X6rwEc5X8IjIKFpGIZa7Nf8wBqgMxiq/RX5Q5wK83B9Wf8USt4DQTniqOjnsQP/Ymw8S67/9q58quFleeRuqhuk8Uy1HLWQKlbdIsd6C+6Kodr3bxPWxboOXl4ncX6GvoodGkp6rauXgFzTSiuSPh+9oKMvoitrg5538QKTNumLMvq0+i8haaIYNi0KELiRMiKoON9vJgNKKtBHyIF8LwGK8Q1zzdBF4NQVu+Y1bRAnlUSk/jfPdPh0rhR9Qrgp7w0Z0ng5ly7QS1flkd1W83vtUdb+OHOSQwpnJoV6uWJMPkx6MTsNVhYNaSqN47smcFezhkPV6AVYbvWJGr9HAWlkBheL2gLS18Z9K93Y+6ufFWypcUz5WaezOqFFXwA75eWvEXL3nYDuGLDruyqIIWnEcyNjNm7HNwLcnDTYo915pn8QKai8m9pa0vkAoxBk/ZYqCWk6qfB2Rzm5VsoRJKIfyBPh/SJHUqYoMJhJQ3TFr0J/tRteRofP7ISOPE7wG6jYWIO9vbIUobfGCwPLGNeAqs97rHXoUI247hq48Kz08kmnMcgYKXCTqmMSZybrku26n8BvFiE/dkCwc/8IPRE+Qmfa8tKcyjd/wEBIyawPFw1pyOYjcj+L4RCXlh4doOzM0buncfbSTrR 55KUAXn4 8IFLpJdf9mwvM+GEyO4GF6a38myRuoAA+4vo7GkDWbUS5U2/3I/f8nEsoyOCWiEPRwk2jVMER4XRX7HeuF30J62dnHAVVPxdhvaO1pQw8S1guYxSVpXIrAeZtapeHkdIMGOtrjAdUc7sqclIlv3xGFqIB9RLXZ5LmNovO2GFn2q99QSW18ubrapLjB1WrTHeQkhCdyT0JiDC5Ir4VMLrYuIZu6QtGpy0DdDCdF5U5g11IdqWmwKs7VKhFr5BjSqEUpmUsy4wltyaL66uuq+LJ/MK/4vMZysD3vkhTe3w6vfdfndLAFk++rBfQL/WxpciyeGTUqUxCGek3S5UR5LKDJwy6xiof3GT+rSqZKBgShMOGAqD/iBzWLYY8WxGN6PrZxy00xAZsixF7YoFusEBYCEr6BlXe/8A3ZI38y8/vugwKE2HayoaqtVsSRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 09:44:55PM +0800, Ruihan Li wrote: > Christoph's patch perfectly fixes _one_ problem: kmalloc'ed memory > cannot be mapped to user space. However, as I detailed in the commit > message, this series of patches fixes _three_ problems. FYI, I agree with you. My simple patch was sent before reading your new series, and is a strict subset of it. > I have to say that the original code is quite buggy. In the > gen_pool_dma_alloc path, there is no guarantee of page alignment. I also find this whole interface very problematic to start with, but that's a separate discussion for later.