From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C868C77B60 for ; Sat, 29 Apr 2023 04:50:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0E966B0075; Sat, 29 Apr 2023 00:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBF876B0078; Sat, 29 Apr 2023 00:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BADDC6B007B; Sat, 29 Apr 2023 00:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A84F76B0075 for ; Sat, 29 Apr 2023 00:50:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76D6A16022C for ; Sat, 29 Apr 2023 04:50:19 +0000 (UTC) X-FDA: 80733202158.29.956F143 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id F4165C000F for ; Sat, 29 Apr 2023 04:50:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DqzuV8AG; spf=none (imf10.hostedemail.com: domain of BATV+c8f27d1a3c8eb98f98b2+7188+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c8f27d1a3c8eb98f98b2+7188+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682743817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k/av0blLG68oYkF2krZftCjiJkXh5BqBmDIS1wQeh4s=; b=djk8q0+brhGppJuz8LHqc79hs+i6FQNartXMqdtWd26KoHSYVnSx85EiH2RaS4504+ihv4 qRTg8xvCS+fISLNVczmK0Jn50aahuX1RMxsYyMfIy9sIvAnHS6xaM6ph36nUcs5rb4jnOH Ymy58aldljvZVWUNWwQ3L+KviCM0an8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DqzuV8AG; spf=none (imf10.hostedemail.com: domain of BATV+c8f27d1a3c8eb98f98b2+7188+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c8f27d1a3c8eb98f98b2+7188+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682743817; a=rsa-sha256; cv=none; b=azsnmiq7vvp+n268wlGdLhMnmCkJ8gHtxQgBZXUUy/FJvCBf/nRRZfRcQKx4Z8hMf1j86P 2D8nTq43CA+4lRZD+etdt2lEoqCuW17YFVtBsKYoy6q2g4vIWhVnhIeayGKDemV8krR4Hz xUFw37H0qR55Qkiksx94URvEK/nVOsc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k/av0blLG68oYkF2krZftCjiJkXh5BqBmDIS1wQeh4s=; b=DqzuV8AG7dO9w9MAwacR4w9wdw gx5wDH+PzdLaljX4RnLeYSiVWI0K8RFvD6URj0A3RPUCwrCQpQG6z7oZm2wKp2blrh6ITel7w4LBt zMiXXYVPj3lu3EBY11AYeFIQR0ohd/uoQfyF1LKU3KATqI//z6g3CuDUCbqqn3upiIghglciq50eP FDZN1md8SrLe/Ilwtu0PYhfE/Wr90vlFe47EFFRBX8od7SyJB1u+AD+dADQHDIkcz80TecaxxO3+5 HhF19h33PaHv/oGQSrL13gHWlA5dcX6OyMB1EpTXMXrq6wOhxy2VWqr8gnHSWh337Wy2spEv5Hv7O rhsy5cbQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pscXG-00CEol-1z; Sat, 29 Apr 2023 04:50:14 +0000 Date: Fri, 28 Apr 2023 21:50:14 -0700 From: Christoph Hellwig To: Jan Kara Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Lorenzo Stoakes , Andrew Morton , Christoph Hellwig , David Hildenbrand Subject: Re: [PATCH] mm: Do not reclaim private data from pinned page Message-ID: References: <20230428124140.30166-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230428124140.30166-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 8o7pjuh33m65jy9nkabu7cd1ahxmr8sn X-Rspamd-Queue-Id: F4165C000F X-HE-Tag: 1682743816-2418 X-HE-Meta: U2FsdGVkX181YJl1CqSluHDXjcReY+a76V5UIcqsJuLpJKgLcEqI/kxEzA2Xm9ZbZgNZx3WLsGwPFDHNY5bmY8jxCOuKDUDd0/DdkAb3wJkcfGBEmrdSGBH4CWrzCNQ8ZixTXbEEIDTv+oMd7b57ySaFFAMnGylTIy1/PKqq7WSbMtQJyRPD+HK44O3HCG0iEZ2NPlELlgaAUMTP1VN2v0SsOyvVATZUZdW0FPxk6PafdOJiBwHZ9IEORnO9w+rRCtOu6FYtyk0tIXhRFjXSRJi8Wv63Y0p1iasu3Hy2LR0R9XDfo3sEFbErEIuJskIUbb76VtjYmuLjUuvYSWywsw/8lvmN5WSEO5SnulP5yjwwhKhK2Z4qGP3tlF9ZOzXUlj6LkZ3Wyp8TViqeq6XYmdv50UQxiY9q7JZokulmAQHVMMK1X8TKIiFGi0gjStEN957KfXi+1++MZv/4jQDrWiTGdFHrqb8EYol5tc2+Fx9CjhAgxA8COhilieV/J7tKepVMMShfO6zMiWfk8WPd1mLyYRo+PNDYlLoNUtHKbL+dt4RePtN4AFvSDvZccx4TLR2Zv0qmmyc7t3PZimeuMb9d74wSqoHDOpz6Bx3FqopKmWfMX3dnhslYPx6zRuPLU3zRcUru8aBrjHMMNJ0OfDAzqPtYILW4tyDVdqnB+I8EvyxK8J8y7Bgy26ll/LFeGt65XplEWjjHFnfzXq3o7wPTGNtsgKBSyl4HdgagI04oF4ULnMSvC5s6LUv+yWaxiWR3Z/YsdtPSFk4E4DUf0sdC9OsJYsIaBL0kMJri/kNhtifTLe7UhHusP1WHOfP3UNkDiKE4s2thMWXF57i5acaSNH5go/k4NEHWAqv0o5Y1YCgPN64w9L6Zj5iZGym2V4SX9NfwukQZI4NVEpOBNplu1aH+aMrKC8czn47k+uQpmcg1N+X0myNzmAcybSLUh7ivlRCWHnQeDBkcl4W ilpFs4Qc kTHxOdVYlm2g1oDxNiw7sHxjBndnhQl/sWz5WvN6adcMe1ujuL0TCGCDDFSRmYdCgiPp0akp0+QF27L54q+d2hWU2n5f9jLz4Qu6Nzm+BhVVmTzP0KtSQQ/OWegp1lD212E/LWPKg7Y/wmcLNvZ5RxVPYR86wlCuhKOgJMJ5xLJbAnCaA1u713AdCTc6m4Ib2x8CTU4wQvyHmCkQcaHMmhtreaZZWkAwsqxv3j0aV6lhjeiBXWijcwDGimwIhZb21q7TyLkKGZFRZ2a7Cff40PGdFUSScd3SSN/Hl6Y94jHSibsCGsuIKL3C8Oq56ZyA4lUXHM1ATt4Qz+DQMbjzGeOZjKsVPUm7dcM1eY1YofK0+FkDqwSzBWXW7UsgLobOFZmemnfakxOwnIjs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 02:41:40PM +0200, Jan Kara wrote: > If the page is pinned, there's no point in trying to reclaim it. > Furthermore if the page is from the page cache we don't want to reclaim > fs-private data from the page because the pinning process may be writing > to the page at any time and reclaiming fs private info on a dirty page > can upset the filesystem (see link below). Looks good: Reviewed-by: Christoph Hellwig