From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B34C7EE21 for ; Fri, 28 Apr 2023 18:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2CBF6B0074; Fri, 28 Apr 2023 14:50:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB57E6B0078; Fri, 28 Apr 2023 14:50:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92EA06B0081; Fri, 28 Apr 2023 14:50:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 80CFD6B0074 for ; Fri, 28 Apr 2023 14:50:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4AA611A0309 for ; Fri, 28 Apr 2023 18:50:27 +0000 (UTC) X-FDA: 80731690494.07.E69ED7B Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2064.outbound.protection.outlook.com [40.107.244.64]) by imf10.hostedemail.com (Postfix) with ESMTP id 6EA75C0006 for ; Fri, 28 Apr 2023 18:50:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Lb09JSGc; spf=pass (imf10.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.64 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682707824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mw023qHm2iwfXfoR3rKyX5syQLrvsUO6EuLoL5uoz7k=; b=e/5NAXfeRTqKyagUcNtCTnABcfEVsTmfIhHCbLrCIquKCGIiinlmbcfKD1bu8Owxt8lEeV VpZDAIPEn/bzsmF0ufBlo50WKRmASU8TV72MHjhHEx2Y2IWnd5Uw3JraP4WF8nJpQhNv5x C8lhT71NzeGS2pTJxu0qS/sy3CgGWhk= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Lb09JSGc; spf=pass (imf10.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.64 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1682707824; a=rsa-sha256; cv=pass; b=QOA+cnU9yS/2R+fxuCSOfZrSQUSUmIlo305wM8FlciVBqhg5ZlgUJ3ULfYrOSIMcPDCWl5 OBIa6TlVTCcxu3oWFkJt4iPpz/ZlHa15ftQ7UiN6b/bCuzAPIi2Rtw78s+C5lIpbWKw696 wDOavfT0jstLByJg8frV7QJSMd0MYPI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4RkCRDBe6vMp1aA+G45G9xmws1s8roMQU54YrAVW+ZghUWiGTphO+V4BFuD1haJ5Np14NcSqUkTYkT3f2yHheCk9lmrCCjc2QUV9SlT21gBmDHI5+gfjGO+acGCUn/AEaq/oZxHs/Bf8mi+BwA9SHZqNmZb3rabgDnVGrMBxqGnzw+iDOYYo+f1LrScJyaflq0zuph5dXf85o/Ttzf8QxhcMWVwsn5XZJ78Z1wDLeSfXdbVVx84dADeM65+3mXurae1qnJt1cVWJM37UEKC9RAefODeXlMD7Xmid/md5CqL+T/+zh7BttRG0O0MCgeVs9r+Ggp7j14PxaO/J49qfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mw023qHm2iwfXfoR3rKyX5syQLrvsUO6EuLoL5uoz7k=; b=CeIUcgN2jelYmluAw1mYToG/Sep39xeLD/8Vb8zvn347kfBgjAMM3EPXG7wMuGusj48XDVzgb2ugfk8yPr1IaXYazAPFlqGc1hHEMjs+K/8j6V53U44lbpnfur5Ry3ecEuG7c7ZYa9XImJQxUbj4tKOHei7VCX3ChAX5NjNYMFAEr6jMzg6tDy8FjdWxpcKtQyqDC2OznRIgz8t7PEMsaAaX4BsUU7OUNLZUW6FOfEefErLo8Co+kpHwp6Hz/fFx7jNKwFqllFSXGCspFqYvth0T/900zMXC3GjW5BrAEGiU0bxjQdeCYjemjMV5fRorcIgPSdo24gCmtrZqh1oiGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mw023qHm2iwfXfoR3rKyX5syQLrvsUO6EuLoL5uoz7k=; b=Lb09JSGcoWMN9lpOaAUwdqCxu0hjGn0RvY2Z6W5jo7S2uoAw+IcSBXeoBnQbbPsE+XWvhX79D3l0zWcgSYsTk7tlEt9URbSxUqsKrksPDRXgO7sThxQhfGoWzorEOvgnt4GU74oL1MEidS8vRLaiGeSw9G1g91w0KRzvvZ1Awb16nisMBWlW9H9nFL9G+qj5nI8/2blJcl1ZXZXLjzCMFRp4xEVV0D1TJj9AtJlIM4rR490OyH1VnDDQLS8B1C40glOSDngbyoEk4ZIp2OLbiHcbfboFMykAB1st8oK9R8iM8KfDSHYVOsLFqXuhUyut57sI3ZkfL4oZzbalGkyPHw== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DM4PR12MB6637.namprd12.prod.outlook.com (2603:10b6:8:bb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24; Fri, 28 Apr 2023 18:50:21 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab%6]) with mapi id 15.20.6340.024; Fri, 28 Apr 2023 18:50:21 +0000 Date: Fri, 28 Apr 2023 15:50:20 -0300 From: Jason Gunthorpe To: Theodore Ts'o Cc: David Hildenbrand , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Message-ID: References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR02CA0019.namprd02.prod.outlook.com (2603:10b6:208:fc::32) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DM4PR12MB6637:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e1013f1-8066-4797-5481-08db48196aec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5wwheoElm4hibrB0I7XA0C2mMlzrOjsd8NXmXmMHDBRBxMvuAoga+4eCzE3r7KYZTilutGAqPYv5IHy79vb7Q3azBhEQoS703HJZDIXRLKKGsyzjn2PWpPm9ixNC1ghEZFd8+ZiejJVDxgD3LGKlmeWAa8dH/S9jPNvmK3Ai/YqO7eS0Nl5VenC+LaE1MZV5Z2LXtnwKfpx20+BD4UjljToB6AOO8HbNtkgIzcqTI1jfpjcPbDDWriWB3p91V3i541H2SMuYXgSoZJE6rR742H9PN2QISEaHQaD4p/lSk5UFkdmD5/aVCcj3ROHb2ISsq/mYJrOh7YWzvqt/J5UnbkLI0NJchcqvWXBvlxR2hR/OTJMHx7fE5Eaxx8fPGTEAIO2grSykSqcT82GKHG6doeR9s4/D64YFXSUxAKgT15AaWPM6gAJP+ImQ+CKWX7Z9jFnTVTu0+cyYd0VZ0qiQ/IdQlrP+o2Wc3+0Hv1Dv+Nh0lBMGvrgG/ePgKtaaCK5YRVgEh0/K2mhf7V6qONh0Iyb0Oat3gzuK0WhGZMnn+G4P5kc+gKMu0h+JJm3SGxu6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199021)(6506007)(186003)(26005)(6512007)(4326008)(6916009)(5660300002)(7406005)(7416002)(36756003)(83380400001)(41300700001)(2616005)(38100700002)(86362001)(316002)(6486002)(54906003)(478600001)(4744005)(2906002)(66946007)(66476007)(66556008)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lpvvpoMKjBAVQsAiaqFnhK5VqRAC4zmQA4XcTaDvk7USM2JDCCPxndiS5Ik7?= =?us-ascii?Q?te0gaYJ6AVTgJJgl+CJTJyb/RcXG4nHUkWRDN6Kjp7HCZQxkXSo8RcMN70gH?= =?us-ascii?Q?+wLdoZ7R77YeRCYgR7DzldQ3gDTd8gWPon8eKU+0mNLEooLD7u6rnkf7w5Wm?= =?us-ascii?Q?aeobJ8LX27ahq844jK/Di4ZDtn7lcEWe48gjoOnzBTvAZ0eQg/V05vpzPUT1?= =?us-ascii?Q?yUmR1jB0sCtHqNIEyS2XOwPN0Bcyu4eQsyhmOkJG1ehsED0kYHJVPM5zE4Hi?= =?us-ascii?Q?rIxAh5EKoqUuSKHtWeqy4/tbcf0PdVoDjClZHHnvuEsBF78CTWW6KWN5vd2b?= =?us-ascii?Q?k+Z+Vg2KqA3ldElEX+0Dvl/G60V8q6Nlo1BEh3qV9y/egVgyg6IXTwmVx5WN?= =?us-ascii?Q?0aXNcIGYPxGJLJooiDo4o24y5vIm3FzSkKMeD6XjFZ3HeVQwLGUEGsOnzNW9?= =?us-ascii?Q?mf1ZYDWv7FF5QTKZI+RyqE9My1DppnvGhplerfp92Fly9Jr9gW79YYVYLoPP?= =?us-ascii?Q?EIEOv2bVVhjZGazXbmvqUT3CT5gvrtWfGOZ28Fy5/UD4jX5i1s4NEdOuNHu0?= =?us-ascii?Q?bQoNKTa+WrVd9hMqvvbK8E+4ewm4bO1Nh0K3c7AoPJzw8DQEh4a09tscHB6E?= =?us-ascii?Q?cIimipHy9dLd6HhRfq9K2Ha4ldR+3OfSxZpcIgCP5Zddmwe8Q1ofcQYjn3R3?= =?us-ascii?Q?dkPivvDDohnvrPC9+LDA16Cr4KS+Sqnw71gXtAIv616z/00U2Bq2znoZxQge?= =?us-ascii?Q?/LEF1N4ShUZGXYXw5iCpZFRAKznKGbBaULN52sewprS/22qB2tTHGE7Mr3j9?= =?us-ascii?Q?Sfxu5yAI6K6u495mnm4G+N+PV2s7Txfhu2OIluCLFrde5Kjlwi8EwO0udpQE?= =?us-ascii?Q?yoq8AaCYCNn0/8Ds6cpunAohrDF83cbbHYVPqLNuOIlvYIgc/O4fVPZUMRDZ?= =?us-ascii?Q?+ltNxNqCtRU7gP9oSJycgXnvoTXdDJxQY3pg4/8G//xV7odcSVIcLJt/Scvy?= =?us-ascii?Q?ej7gdAdQS8GJQW5KsTC16Fz0LUWsKbrSg3HQmk90DAZDlxUqJTF1ydclKs8s?= =?us-ascii?Q?qpmS+m1dpdn/hCdQpMkMZ72clWgCxaAPeqeTZ2dGfHOKITXh2KT9Ttq+h922?= =?us-ascii?Q?1Q/8oUySOEYQJBErLdUGWIHd32GcBIg1Hkhzlcae9K7aosNYcm6+yjibf8qS?= =?us-ascii?Q?u/IlufAAHbjVi0uvIZKbZWOFZdHGpMZIW6xeBrTU6USKRArPfTleBEK2TbGn?= =?us-ascii?Q?PvgAO6iH+8nPA6WD3UGn/xcCae5u7V0m52Ozo1oHWimU3NuvYYe1huKHEVkn?= =?us-ascii?Q?CD9yvcmfzRtmCbfLqpayoFuney72Zf9fh981b+vQ3ek1sREMuBneXfWgUmFl?= =?us-ascii?Q?M7oIVIhO8eUIpv+MDZyMgzRfNo1MufrNbxjRV2/iFnZNucMZGHN1oD00aJBV?= =?us-ascii?Q?twuUIAH38bH6TbPEGiAjW8cjjWk050ssMSJbUPk8aQoBrF9zahekKPxBxL74?= =?us-ascii?Q?evb/lArsjPWDnQWVZmVQmf71VUWYX7jIhXAQvhWaYCYp1OgJmmf5f8SdYpBM?= =?us-ascii?Q?ExDBFVfGy8SmkUypSs7vMKqScWjVoNxWeg548P7E?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1013f1-8066-4797-5481-08db48196aec X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 18:50:21.0104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sr86pnZuXaKvdhH5BdjB/Vh39hnF0oK/VH2mWXD5+40GyOwTz4E/OW4Wkh0GY31h X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6637 X-Stat-Signature: c7c8e7hbbqm7ue6u679df1kmr1ubacq9 X-Rspam-User: X-Rspamd-Queue-Id: 6EA75C0006 X-Rspamd-Server: rspam06 X-HE-Tag: 1682707824-824996 X-HE-Meta: U2FsdGVkX19Oreej2+hJPWnHCn7gWMDNTZ4fb3+fqaKXsFbeSLgrNps1MrxK7jqeo0u/WsvHHzfKYjy2IQ6EnmbaKEvdXVr2F7M6rmUbbHeEg8U6VHR4w0XPM7g3k4Ytj1iGyOTP4ZXmjCNhlGl2lCQrb3Gii+oh5WHlfgCXmZ6gz7TZy3ereqnrgrGh6SnCUtlnxEwN+EsuFHCPKXO9aLs27T7a3iSfMEVTUiOjUpu01/WMItOi3brVuqAortjAX2348pgTzMl4uxOdjSo6s//JOjIu9Wy+GYX12yLCBlR8jSlBxSkLWate1UyLKKitFeXrNKfkuvLxrw2rHi94I/ZYD7q5+o8eqYcY0jn+PNGC9WDHtQHPMexYrGkzjCynsUSY4ejXoXNUWWH+myiyZFhvH+KkOWKqY3Gh/OH0wKldZSeaBqiBVLEdLoAeIyB+QYwy41viN9C2sC6cJbmgcsgoA+Ng72w+lX6ro5QkFjqHk4smwHMI6bqJHiipp/wQXMrC4/YGNMXu2AJ695903PAWRWx7AkmeYB0ZoAQrVLvgI62tiNgixpYwWxVZ24t1tQRqLuhl6q8kW3p3e9h5ldUgK4FKkQD3cpUUBHX3LC/SirubUkNAqY/YTBaFTTqMUzwMEeVpAUHIfedNo4xUp6oMz60Z74U2s6ECmqj7RnJGp7lM3rTS7TUubI1ihq8Qk3m8SY6kuDu2GTxd778Sum+gnFOzrYLdjYCuHAyeUb2FLAr/3qT9iM3Bl1CCgGbZ95IlUDBIKnQU5K6iWyKY9oL/gQ0Z1N9kuiXGFMGOmclE1H2hd3A6LM7pHsXyBHIf/xL26/2f0eO5NUNkpWJ3c4yVFME6+36xxkOBgKeJYuv341ZT1sqoi9JrBuLFHiXc28y4iArPetoB4guNg1FG8JSEyOiKkbidVNAQCSafZpvaQv3ejhbjziNh6k08jW1GTI6XGvdbfOVTyhjyO7F orJwa+ni 9I+9LMQkq9nf5H4jwsx/TRaQhHi7qQja82WaXy9/kb8vN+bXWzP9SByx5llMlK122da123yVN+Arjwy1LssoKRC8nDCvH1s1WqY7n+hT0r3oTLVk6kgSdaKTldv4i7olyYdjtLrKw4HPZAvJiq+pKl1dOTv8BxLR1MRj0gDBZzm3IpqBGCziIMUzyWw5VKeWZcfEdYn0ooV4ixRSGUp93pJX+zS/txFsC3fEmYE2OFBGMs4W6idRsu6lbU/7S3AXaNBAHNJhwSRHt6OJYNV6bHsqKm1ee0rRpAconwOARYN3s9EjeARE+4CbUpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 02:25:53PM -0400, Theodore Ts'o wrote: > On Fri, Apr 28, 2023 at 11:35:32AM -0300, Jason Gunthorpe wrote: > > > > It has been years now, I think we need to admit a fix is still years > > away. Blocking the security problem may even motivate more people to > > work on a fix. > > Do we think we can still trigger a kernel crash, or maybe even some > more exciting like an arbitrary buffer overrun, via the > process_vm_writev(2) system call into a file-backed mmap'ed region? Jens? You blocked it from io_uring, did you have a specific attack in mind? Jason