From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C11C77B60 for ; Fri, 28 Apr 2023 17:33:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DDA66B0072; Fri, 28 Apr 2023 13:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 666AB6B0075; Fri, 28 Apr 2023 13:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 491A26B007B; Fri, 28 Apr 2023 13:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 365996B0072 for ; Fri, 28 Apr 2023 13:33:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0193F402A0 for ; Fri, 28 Apr 2023 17:33:52 +0000 (UTC) X-FDA: 80731497546.30.6EF37AB Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) by imf28.hostedemail.com (Postfix) with ESMTP id 21C46C0026 for ; Fri, 28 Apr 2023 17:33:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=QiyX6vi0; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.93.88 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682703230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E1Vfgu3cqCPPEyTOt1jyATDNwDp7qFRmohQV5JSOXAc=; b=qjx1VfejQghnK+rRHiHPkxfcv0m0dos/6OQIKBUtZJQsvk3v9ddMbqyl5TrSCcvM7r8Oni Sbij2gSl2E5VpYI7/W24Z9CfEwIK+cTVFRVFFpdechrL4I5eRQjQ9xnvNouE1QDadZGX7L ugH57xD7iJh6M56D40IaxSs3lkwgquc= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=QiyX6vi0; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.93.88 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1682703230; a=rsa-sha256; cv=pass; b=rTw6qFobdMWxIVERfzQGjDJFbWvK1Fg4EWyo25K5lSwmuZiLPtMzb10nhYWKVIoqpm1J24 YgL+DLYxDdN34JqVrDDjJAd/Ga/DO1BDH+VzNUN4aas3llBPdHgF43kRCvL/GaViQipCSV 7sOP1eb5rsbbaXpG/+FYbJ2LS4dRzPQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgT3WIM7j3+Kc6+TAShTIyRM4IUOAIARzSCUIR3zYTG9HokeotppAqqnbsXJeIe4LAga/iSG68gyhiDsDhCG/7XQNlT2usvAfnOLxC52xvonAnsQQemVrLOlJWb1WjxNGTh4jaQN2h9XMlGAchGO8CSBmu7dNZUDPq+gZwrcdZY+moSq2tQ4OkhKUhqiBq/+p80jcfyDcPVSB4qKObCd5FFpqb8Ue2IA/JQ82u7vvKuHporYtRZEUOAKomcXL/PSTqqRsgkCpuBeATQ577uF37DJ+Gt5Kp9mRPT/97tDx5w/B6JlDUkkyYksDEkH6AyHN/Xg0KhTT4J/SMaLY1H4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1Vfgu3cqCPPEyTOt1jyATDNwDp7qFRmohQV5JSOXAc=; b=Fodr/Q/8YTXMefndPOky7gzzBasS6lkH3JY3ns1lZLsguGZ+rXHvvxWB13fVImjMnnL3PHD3gpomiZN1R3oUcT20tAcaIlL7tIJTTu/jXHovGI5p1OZfRDSTzvijq5Db5T2wYboTLMr+4OpUVP3zz1Rt+wttU2EXqdgP71dUjLhFJCgLXNHR937wmSvlZIyNXwqSkYnaRUFEzS1BTel9KYXtU1Zi4dmadm2YHh83efpWsf3Yblmf7PhEryqdFSBsjqZG70Xr18m881JUo+UaYAT64JOeIkAw2Vs7WkdS70LhYWEF5JXlZKsLVjNBHG3uu/x8swIV3T/vUmjACv9rNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1Vfgu3cqCPPEyTOt1jyATDNwDp7qFRmohQV5JSOXAc=; b=QiyX6vi0UVtbHfbieKgUA9ThcPokZg8ozDPn8qRAtePc5w6GuPAkPNLnTUZTTMnt2vxJndH8TdjHE/2dOdFN/bOyjBdxAxMTk6cVPo6qUaHqaR4L95kw+A2izcdhdGEUp9vhYxLmumdTl65w4QBbXjjt//7Yec8uCkXQ/IBbuysGXBNI3VS/mbKBC2ASLteXon1qXasEtQ9gFENrDAnSxXEWQWCQWF7/YoJiz7Fg0Hq+NCf9ztFJw5b1Hs0PcB1AKrRZfS8EDoWVbUXqe7jiBmdd/PFG7CvFs5RioECIj9N/QB4W/hOdm57KVIVaxqLWf1tBFO2yJdDwDbRnAO8htg== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by MW3PR12MB4572.namprd12.prod.outlook.com (2603:10b6:303:5e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.23; Fri, 28 Apr 2023 17:33:47 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab%6]) with mapi id 15.20.6340.024; Fri, 28 Apr 2023 17:33:47 +0000 Date: Fri, 28 Apr 2023 14:33:46 -0300 From: Jason Gunthorpe To: Peter Xu Cc: David Hildenbrand , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Message-ID: References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> <400da248-a14e-46a4-420a-a3e075291085@redhat.com> <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL0PR02CA0078.namprd02.prod.outlook.com (2603:10b6:208:51::19) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|MW3PR12MB4572:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f9cba5e-00eb-4965-557b-08db480eb8fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JUcEFjaNrY7RIBySwyEAWv4dlsYdb+0F6yLHwPlDrHKdDzY2GN2ibABkha96m1iyA7GOcQOIS25zNwyaU+LuyM2mQtSjP1vMvYV+yY4UuJbpOuV+xBqzK1yRjKJ2tTg/YhmXgGKkQCVtQX3waCNMVWTkcg/rWAJp5dLzP2iFuUZdkTqd8bNdU+EmfykCoztkWVR5PCpZwgAhuK7RisVANvCX3JN03qsuDht8ooWSkO7fATrVqCVU7CQBBisfLWp33kvVyuAvFB51kpkDhpRrZfZy5YRVwfo9ECAy9pUU3g6X4X3BlasKWUAsSWfXw2MdI6BIzEVNWZ79A6GcnKZLpRj4ShBL7xytdznXub0cqCoixqcN4HCWeAIhWGUyiMiH+wFKlqVtrSMSULO/C3I1b5j0W3HcVZMC5oEQD5QG+CuEM5xTMQ1374t1lyucR4yGT5qHRwlAng2kpL4ptNj0JZ9mft4H6kBWoOe1pJNrfznzb4gWP00zwGVBAQ0YRinycsGH+0gYZY5ZmVs8sft7B6va/QaKcUVUMXQsNgu7ZAQwPZQuURoly+RcLjgrdlA7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199021)(36756003)(26005)(6512007)(6506007)(186003)(6916009)(66476007)(66946007)(66556008)(4326008)(316002)(86362001)(478600001)(54906003)(8676002)(8936002)(5660300002)(7406005)(7416002)(38100700002)(4744005)(2906002)(83380400001)(41300700001)(6486002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gCst05YJ2moqIhX9sX+LLoAStVoFy5D/7SBajLa2l8VZSYKdwbFsAcN34h1O?= =?us-ascii?Q?DB4pUVEawB8oykHQVW75+nF1KUU67oqKLf59MUXN14swmtScx5OpAkPW8+ow?= =?us-ascii?Q?mKHa+FuEoncdJFtU39aWcRZwOLOo7Xp/czWAAz/4rgV+Jo+0PJQLAg2GkAa3?= =?us-ascii?Q?4R6m+QP5YU9dmbEpDi1XQPtGU0DLtzbLHPAikbq8dhx6+aKAeZbiuFiv3ail?= =?us-ascii?Q?Gw6f52JAF15bLyp9BJ6GuuFwuZwAmyWyttwrdkAMPy9XZg3sDYfM62lbQsWX?= =?us-ascii?Q?woO5WuLjLw3H323xCKVSqdPpsyX1tZm7Tpx/2EqIOgINifxIcaacgtJdEl5F?= =?us-ascii?Q?X+UjmsuR5o23FLOMY5V8d+6f4BfjxsMwsEuiszHp+Uc3pCiIAhIQBQbDcsDC?= =?us-ascii?Q?jrmDqyJ3Kcm9F1r84ACnJ+dkjdeCI0rlKIjSpVBf3lg430sQaxazg1rvtC/A?= =?us-ascii?Q?Ej+f3Iu36amBxS2THziDgQNcRmi9MZuQ2bbL+ACq3smOnVcTnO4T1US4QnaF?= =?us-ascii?Q?8bEQGw1G88ZTFZSK5WYWSF0JnBoGCcfhPQl/NgYbFY/a0NjdJ+s0rAFgx5qD?= =?us-ascii?Q?756z8+Yq8/1qcpdlsr5y18Ms3lS2Tigb2nsdvn+3Q6TbMzVsGBeaBxoQVNFa?= =?us-ascii?Q?h8Tf2FGQTlnZCR6ppa1lWc3RxWb8Bq2igGgi4hfU5l2ycFRKrIfVLXGa2oV9?= =?us-ascii?Q?NhMTfCCqsnWS/2Y8w8rR1DDLaLHzJYmFNg/uuUHLloeUrDcVWxlyd6ARoYqp?= =?us-ascii?Q?RPfvpAAsG0rNzqHe4+Oa2e4D7ldkiho8OkUPX0QLOOKm9H/9Mmv+IaW75ng2?= =?us-ascii?Q?fDxXVTqpshaKZTkNRik+Kiz9dMwY/5ToXgkCLPzOQ9VZIXbHvBc4hhnOf0oo?= =?us-ascii?Q?rYNGJojOzF4rAdbrM5cngurcFEGvyqcgfkcdGD4Di3wqdMuq6m7vxoC77QnU?= =?us-ascii?Q?x3CGi4wjIfyu6XXPxSJJkFF+1s+82uN5FvklD4veJ7nOy6VXa04TLuixyT6f?= =?us-ascii?Q?LriagI9xfaMYfSPhV031pIH/EhauFs3AEHriwy06AGDee/9zPJoEvwa+QiOP?= =?us-ascii?Q?IsnoA6m37ylkIPGZFXh179wR7oHgPUqOrm8qZAwN37A1ixUfzLiDSqiBtiRv?= =?us-ascii?Q?uGhiCXTlLbW5oW6lUpANFbg+BLvTZAO4f2FxEFmFmryGcia/O0uyDo0qLhYD?= =?us-ascii?Q?LS9GplZ1gx3wVeKb+1bvna6+sZXTeWXXw2weTyn4bU51DPN1c/kZ5QkS/Cb9?= =?us-ascii?Q?1P1G8Geom/2LmMgidmkjdR1+cVrsMRSDAu0gI1j3bHocA8xz8gh13xV3Fn5z?= =?us-ascii?Q?qqJP768G8zzCYRLBGxiVimNu+3y8FK9sX3uztrLGsa7KvIsQEdA7SUDaFVi/?= =?us-ascii?Q?9oJsAJ7kVUolcelM6mcqRf/GpYDoGmLeiwfNVP8cfh+V8cQBXQdj5AyCFuY6?= =?us-ascii?Q?vZAgbu2GQ8duOH8fFsChNo3Pru4/e33iwmPsNSOnidryswEBIavFLNObHDZ2?= =?us-ascii?Q?YYQ0ELNO+zW6jZaV6u5jOKF38GPJ64SeFe2yxRKdTuoqmpylzv2U4feQ74sb?= =?us-ascii?Q?9rUJGu0qNrIlkmUZMM7Kay9FOUYuLmoys0qEcwp2?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f9cba5e-00eb-4965-557b-08db480eb8fe X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 17:33:47.5496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bz/XCfi9YFwdmbgjZW7VPPpHyDuRTAAxFr1u0cj67+WAMow5aLRO/C4IYW8LSFl2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4572 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 21C46C0026 X-Stat-Signature: x7b1hq15dujfe43h47ryxtqjbo9tmokb X-HE-Tag: 1682703229-525510 X-HE-Meta: U2FsdGVkX1/82xl1oQGuabmyz1GbEVPi1vUdYNTkQNv2oM5ZoPAcKs5LRGyXjgqRoXw8PvwLn2CeHB2IOqrClUqJ4XVt4HoXv8UzJ/b6lM4SXpuyXZ9AwGjcCN0wdsPCCDdcqmFHIAWUk886sGoHPFQ3YHS7YVUb8gasLoaiUSaNRYTnuvqxoM2BaeJex3X/dfBP3QIHFO0ky/7eAFYKF1NGRBfqDLhgVmrjIwcuTXTxlDQsTOAx3yBsgpew2t/RRzV8bEtUSq3OmrDSG2z6VTgKoueSUI4ZeEc0ky69yjqz9t+J+pDN6d65wlqWS0BjW+x/ZroaUf+k4KDJSPN8kX5QIgLwx0BwRt3PkfM8qCp+wdcprggeOU57nWLrSgCAW6lacmaSfLCmQa3/+PA0AVipMmJUR/d3ZIMJO4SlzWbPGjB88jWzBXHFXmSLgkUoEpavs850HD9y59snCin92ZBosHAa0cJvnINc0L11s6ryau5shL9P3KOxUOp22WHA15iY0jVDxbE17nBe16jtvI/G7WSLLFnMHn0UtEJhUGOSoj3xArnkvp/sQby0WlekTkna/OjYbFxo3Z3/2JUPbPcZd8Fh1oiCx/E1UVaiYGCG4TOlnVmWWTr+jIB/2Teph9UxoytrLFYnOSrCkvb1YN9jzwmPq8YfkFFW1+23RFNl/dcslCF0gDGdG0mGZVmMAL1mWXxASq8XL7ZdruUnRpfdtJgIl1KD+kDoNtQgIJm1G/Iua0b4q04kSGIXkvlKkNqi0egtsmNYDDY3a6/+0ufmLNNA+b7fvqxss45srVy7w3IqJUt62/WLJIow+WJGSXQb9WtuUFbLO8402MM3NDDIkhZAZaBzBKBHISXdb7Gr4P06lRmnMcL/9JWJfSfu60B/DaS70+EKOuwT+/C3hZfTxbzUhCB5c7qJlSR0tzKLJq7nhpF/RdiLSBs70NremdgNdssmhoU8fVAmEyK VIkpqqbG TzodW6SaPcMyVyQXkAz8vyT715Rzu4OaCdtkFa26kJrIWMFTbxiMke6PDeZIoM9HFZRBBG1SGuVTotJE9dEFS9nu1FZ9pV/UJbmgGXgeHVOOoi8pbGEmvPwZrs7XbMw/CgZaFho8rB46AqVwUVDCfc1v1i2GDjB5ZWP3byfu2rI6VNd6so5KnTeuGeWbjHNdL7JZ53s/L7PEJQyuY6z+EEWNxAGhGWutm8eb36sJeLLoAbnjbIugABQP71dg7iPWH+pdmdBKNh4MJ7iZHGsFYwc6FhXysMw7kPki5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 11:56:55AM -0400, Peter Xu wrote: > > PageAnon(page) can be called from GUP-fast after grabbing a reference. See > > gup_must_unshare(). > > Hmm.. Is it a good idea at all to sacrifise all "!anon" fast-gups for this? > People will silently got degrade even on legal pins on shmem/hugetlb, I > think, which seems to be still a very major use case. Remember gup fast was like this until quite recently - DAX wrecked it. I fixed it when I changed DAX to not post-scan the VMA list.. I'm not sure longterm and really fast need to go together. Jason