From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3D9C77B60 for ; Fri, 28 Apr 2023 15:57:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358C06B0072; Fri, 28 Apr 2023 11:57:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E1BE6B007D; Fri, 28 Apr 2023 11:57:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 135216B0085; Fri, 28 Apr 2023 11:57:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 003C16B0072 for ; Fri, 28 Apr 2023 11:57:05 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CAFEC120279 for ; Fri, 28 Apr 2023 15:57:05 +0000 (UTC) X-FDA: 80731253610.23.79182A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id BF0A9A0028 for ; Fri, 28 Apr 2023 15:57:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bJKb7A0Y; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682697423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zf2i3kVXtlVgFFMbGoUpKI0IDlebsU5o6nl1WehrK4Y=; b=f5jwHdTkeB3r1oIUFaxXUyHbN1ZbeFK2K2KZoPKvUx27ZEYlmfkiiM+Kk7XMbc8qGrxKJT t5xlrHSrYFmokHJJbkNDktws/6ljTdJN4qgpzXitn4JWB3klcsfC17n8M/3JEQCv+APRFt W92encOXImToaieuOHADKoYr8eWR5kM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bJKb7A0Y; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682697423; a=rsa-sha256; cv=none; b=NHZOgqoDqV8Mowqfcb1JHin2aIDafxVjVvqPR6Svs4wbEs88M8SBtbwNv8YejXmi5wTjKZ 6HF/Xnhm6cbm6a/l3qemZXvfj5sBDlFBXfjS2bAW67cLhDjniG9U8SnsExB1QT5gmtXBj9 nvHG92pUf2O1xkFtfTfENW+QXuZLhg4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682697423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zf2i3kVXtlVgFFMbGoUpKI0IDlebsU5o6nl1WehrK4Y=; b=bJKb7A0YG1bD+RPslggqPOaKq7cEi/DwenaiWa9cvrAOs1WE8a89w8z0GTQi4ahO7E17PJ Da0ramFP1nhQiZyk2qcW1d8n0Zd/RwYvCIsJEQRdtoeTWGf56gJnigoC62q48Y992UJ4B8 6jCt+Rq3mxdjsRb6ljWVI28fGjHa4iQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-3kJJwLr0M0eZgE4ZxFVNOA-1; Fri, 28 Apr 2023 11:57:01 -0400 X-MC-Unique: 3kJJwLr0M0eZgE4ZxFVNOA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3ef2cb3bfbfso47561cf.0 for ; Fri, 28 Apr 2023 08:57:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682697420; x=1685289420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zf2i3kVXtlVgFFMbGoUpKI0IDlebsU5o6nl1WehrK4Y=; b=FQ990iSdytaKHaQBS3QWRSXHsH2bCnm//oADtAYZ4lVf1A0vkdebcDHsQkwdsYTWAs QBlqJjhwJebVfmo6uhTPJCZl7gSItmabSk0E2gW4dDYAWHdue7pFMxAtbs/HlzaeoW2h 1IkvaKTNqEUmS93Jqdo+N/12T64mKAKoEr+hEyBBYu5OKd8vVmWoe4PN+BBSbt9i2Zvy g7S0D7knXqhA+Iob5g/2sBCIfmkEKoMjFmNZeoQ0XtA3s8OcptOq1SLBmaOujMsnXecg gTetQpGZNWX003h/MIlyICImnBNTnMDVpeh2vnPFil3KaJyAndU8Cs3cRhkRSZs20vLR F3Rw== X-Gm-Message-State: AC+VfDz2ERlFyG9/0RYkdIP8jQ3jBfUSnUN3KZcWLnL6xp7ViqucJrRl zGRyIyZZFVaQPgFJm65wvVzA3WytJclRga8fLvQmfvrcjKH/A0/81BJ45oYs3di2Ac25xIP8dLy K7oiS2EhZwKV0qXQ55So= X-Received: by 2002:a05:622a:1047:b0:3f0:a887:7d2c with SMTP id f7-20020a05622a104700b003f0a8877d2cmr5184809qte.6.1682697419786; Fri, 28 Apr 2023 08:56:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Ehg//He+hcp0mx8gVUNQ8HJe0s0NcsM4chiANUARw7z3NEuycfTLFrEHAF1k8Z5nqwT+zkQ== X-Received: by 2002:a05:622a:1047:b0:3f0:a887:7d2c with SMTP id f7-20020a05622a104700b003f0a8877d2cmr5184790qte.6.1682697419513; Fri, 28 Apr 2023 08:56:59 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id o16-20020ac872d0000000b003ef5ba0702fsm6392726qtp.7.2023.04.28.08.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 08:56:58 -0700 (PDT) Date: Fri, 28 Apr 2023 11:56:55 -0400 From: Peter Xu To: David Hildenbrand Cc: Lorenzo Stoakes , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Message-ID: References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> <400da248-a14e-46a4-420a-a3e075291085@redhat.com> <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> MIME-Version: 1.0 In-Reply-To: <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: cx6iqhkiyskiottixmot1imb3c76icse X-Rspamd-Queue-Id: BF0A9A0028 X-HE-Tag: 1682697423-543118 X-HE-Meta: U2FsdGVkX1+TGkPxHdolbyGwu3aZkMugCbP30S3sOkwJ/pTvGxpSFb/fxkxn1fb3ey9gS/58cV54z+/AcEtEH1Pas0nG5Ioo+aMc2txoknDQ/q0me6pKXIeuVcTLNjZ6u+FS4Mmgd2qT0Qt8OOpWcNK6O7L5+M41BMY0ltpzjmN3seV+u499KFATOdLjjj9hcPcAHmKpS24BunXul05MDr4zBKDJgLBaISaHCAlakqw4oRULFSwffXanmd2BDGk/3sRnQPZQ5xMWaQjqpLfpbrrthsi/haExbLSHkjJvFN808oXzQRz04dp/jNs972t4MJAAM0cGCNq7+WptMe4Lwof4v0ypZ+r6czWXTU2akcJca2aOiRez5c/+jIsGrx76cTWGpnr7vJuFxmH2pum+gIOb7JttsQeX1dvgbxRb8QCbmguyIQd+4ccZuAi2ru9KPGKoLu0jJAE4p15DDocXg0/+UrrcozB8bWpGrjEy94ldC5V+fiUT5Nuh4nMeVya/PlcVcb+6ffSb0jyhDuG28nZZCZxKkHL3G/Motj2WvpXXjGwgE6GqUv4tCPrNqtebLpRyAh6LLFdCceUexR/7vJ9HHRmTVZpeQLDFpx6Nax707OqWDGFbOSeZEs8kbLqlpCHkqHSBpWJ/wczPMASv3LYSkQ2MPb9V6AvsuIkojW+DUj+SRCVBfHhhjG1Z0dfRlTsqHk5T2U6bRKB8xDhcMQlbzhdAjzzbos7vnU/lDV0a8Fwhq2oCoxLaCHhqr0QMD3Ut2mZ2yorb0LX8Bxt56N2tCMRVexPqd13y6DUEbJEjkcQWRXel099EtjE+zQG29KPrq2R9haREg0uQTus1CPzwUaJ5wtJFpCR7esrpcp+wLBBCBuvSjfu4pV3iWc0Faa5GaNtSQVy24UJtZ+12DE1N0ylJUwxJSBnAMSgEvLAyHafnu3108BrBpzgen53N/JT8Wd8wdCe+UpThDSO FhFh3G1A tspy5oH/NRD+idoHOmCUzhzyepHgi/ThnsOoYtw3hs9fWE7J5AgzhQmQT+1HMFtmlpWWC9QRNXEdqvx3SiEVbiHt2+K3pKd9U83bg1Yy9r9g38Mpe/W85adVbk6gD0ynGJ4vOxR5g8JPWtwNZforgtP+qoA/RXbJe327JlB7SqB5me5Ro8cjmtyL/sa9q6XQr+Bvn/R9fXMYfzETBmTqlF5t2duWWc2SCxjwswWSIwFSRtoF9MWf27aMgwGWdLesWBkppNllhUAIPImTtP01JoAUOpDBnUOlk5hKdLS9/rdyXWmtFUhj3+BGqJZ3VxNGuiuZ+Qm6GsWDRpMTf9MNjSI/Xxr3G9EBo8sO9XbkaMx6k8dV/Q4bfZ9reu2h6sjSWjsixDy32aYHA5A++t+nWpE9kSdX5hk2pEdfV4K7ekBgJiPieNSooPSmSog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 05:34:35PM +0200, David Hildenbrand wrote: > On 28.04.23 17:33, Lorenzo Stoakes wrote: > > On Fri, Apr 28, 2023 at 05:23:29PM +0200, David Hildenbrand wrote: > > > > > > > > > > Security is the primary case where we have historically closed uAPI > > > > > items. > > > > > > > > As this patch > > > > > > > > 1) Does not tackle GUP-fast > > > > 2) Does not take care of !FOLL_LONGTERM > > > > > > > > I am not convinced by the security argument in regard to this patch. > > > > > > > > > > > > If we want to sells this as a security thing, we have to block it > > > > *completely* and then CC stable. > > > > > > Regarding GUP-fast, to fix the issue there as well, I guess we could do > > > something similar as I did in gup_must_unshare(): > > > > > > If we're in GUP-fast (no VMA), and want to pin a !anon page writable, > > > fallback to ordinary GUP. IOW, if we don't know, better be safe. > > > > How do we determine it's non-anon in the first place? The check is on the > > VMA. We could do it by following page tables down to folio and checking > > folio->mapping for PAGE_MAPPING_ANON I suppose? > > PageAnon(page) can be called from GUP-fast after grabbing a reference. See > gup_must_unshare(). Hmm.. Is it a good idea at all to sacrifise all "!anon" fast-gups for this? People will silently got degrade even on legal pins on shmem/hugetlb, I think, which seems to be still a very major use case. -- Peter Xu