From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E21C77B60 for ; Fri, 28 Apr 2023 12:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EE776B0074; Fri, 28 Apr 2023 08:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 150806B0075; Fri, 28 Apr 2023 08:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F446B0078; Fri, 28 Apr 2023 08:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E4D736B0074 for ; Fri, 28 Apr 2023 08:58:21 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A0ED8ACC08 for ; Fri, 28 Apr 2023 12:58:21 +0000 (UTC) X-FDA: 80730803202.23.E68ACCD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 6A8B31C000D for ; Fri, 28 Apr 2023 12:58:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vf/e1aJK"; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682686699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=doUPR4jiBjU2axrzOq1H1BL7/MBEaMu//BnwIvYAJME=; b=HUUyRrDf9PWB83HkUewvFJaVNaB6BmF7LP/7JYPQC1ViYoOgQiFGVfw3jL2V2oPN2qw7v/ h+3usj7RAwuFnW9+Ga+V87RyZmfNmY2UUdbUHrFpBckAtXc3LUYeL6F4TTqOmCxOXKtsia tR/ggT6iHn3WdcUrIZrTqdQCxwxJyyY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vf/e1aJK"; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682686699; a=rsa-sha256; cv=none; b=1ywQeFJEs44AyB6XXHz/zRMDjtjjU/zFgFZNJVawClnZUTvMUeq9D5xj4GSCovLY77dfeD wQPPB7xoBd9Pfcg5whaooEtXX1U26JAkgIZuVCMhPcn8jSHUNtYtoaw7EcIvqqRAYLooCy 7yJJ4Y+eKqlk9oanRAl+k2oh52iH5ik= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=doUPR4jiBjU2axrzOq1H1BL7/MBEaMu//BnwIvYAJME=; b=vf/e1aJK6INHxe6xyWbASfVrkY KjhAzaKwaiYzeNrbhpsO/847m0fo1dJCfReOgIkPKLU5B9n8TBS6kRcq9X3+qR0pEIXEGoHh3HRAz VNB5RflGruEzQkZ6UKFIqh5aZ8/V2VwS5s7i07Mee9egv3xFhuEMr1x47clsvC/0gjYrjwG9rsSQ/ IridzaWz/vXi7Ovwbwx/uATQWpb/Lga50y0FIbb/8phOyOS7LDTCPM9HSTGrRIOitdiHAXLSlGvf7 0qYLT14FiMLl/D8phuNtpvMSu9nk9lfq/9oAylnBEq7zOBBgflKh6g11IosPNf2GIse86PB3QPahg AkR74AlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1psNfv-004bd4-9C; Fri, 28 Apr 2023 12:58:11 +0000 Date: Fri, 28 Apr 2023 13:58:11 +0100 From: Matthew Wilcox To: Jan Kara Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Lorenzo Stoakes , Andrew Morton , Christoph Hellwig , David Hildenbrand Subject: Re: [PATCH] mm: Do not reclaim private data from pinned page Message-ID: References: <20230428124140.30166-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230428124140.30166-1-jack@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6A8B31C000D X-Stat-Signature: oigpey97exxfjfq5rfspq376hjkgr8na X-HE-Tag: 1682686698-54093 X-HE-Meta: U2FsdGVkX186MeZS52LsmwKprk/ErCgcLfJSrV3rPf9HOCr2X6XsS67tn8SfZ87yk7icLqQ043xUH7ePZ/zNy0VYrlk4jGoUgPcP76petrU/bX7iTTj6TY2hpGAGU5cUxbJF51UPziu9F5t4M3m3oUu5l0jw/e2E90B7i723abMW92jxyATxyV2XGO/TkMyC0gViiqOxqPgK69JSJwMupDYaPLc6/ORzgmxepcymVG2LnMTEUEWxAHJjqFLNzL4HphNyR4giseNhStBmcr8wh2o7h2qwXsXxER5j9LCekOfQ6QZ8XHodkKAsKyuPq5BCGKUmjClH+IWONPZ4rW5We8l5qN96742Hgw8xZt/Sio6zht6IAIZm9xTuzYne+NbJSlmvMrqahgm30+NwWxZAEmYZaY7tEXk63HVUgbNyKvwLzPa53ddYsGp2gPco49FOCzEr+ywqaut8UrARg9KOLtSqdSqvM0sNiSgmncUoWyhXugf+LmC2VCXuqPQyYRIur5fCPyUGcDX8zHny5N0s1kWEgvk2iUwAHwEnsVSgYd3wLe1ReeF/+A44hxqD6PQpYW37dpMcp5Mr/zVGVMrlJUKFl2yj4pOgzcXdPEktgBpEJlogIUBp1I0PcS3rbTtjNK1ReYhX8DocZMzTTjo0OHMCqneUnXjGprEwgZ2WTgTMHw6UYw7fLMHnLMRaGjoMfWL0y4dCRv/8/2gQf4jbrd5BD6O10RC/m88LcAg1ADRb28PpLKd6Zx1HHzX7zlbI/miEiK9d38MwhtLcYmXB8HiEpXV1FrJdOrMh/EN8cDtAksW2MXFEAaXJJ27fU5YPo1htvDnqBB1v63ydvmNS4JlVC+ZOWRFF/NtfXiVO5FbTJgQAM9DUo929sCasHAlbbFqwJrmSfSUG6BhrDfZCBysBiZR5p2BhRtjP7HCrmR/R4xEETAnR8Ij5MxP/Kzi4xfwXvM9MuA81DXBwXE1 q+BaHNzb CrSYxRLXdj3OcyTiEZMm0/iMSKxwQvPHRRG9YzQMUx3WVOdOL5Ww8dbFgEkDQYKWmQaA7oxKz1jmmN0rz/ggEAHWhnst3g1rj6yzz7KzS/IcqvQ6h59xez7B6rnixgEt4xE2H8lGxK+SApqIgs6TTXqN+JqsCk4dCYRwazI6bnU6tkXTnd1ZcwCDCMzjVCcxX+QkD220RfLFG/aeoPOM9XWUnWIoqyrNsCWXVRs5JlOxQIuGoQQYU90OC/x8VcMKBwk1r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 02:41:40PM +0200, Jan Kara wrote: > If the page is pinned, there's no point in trying to reclaim it. > Furthermore if the page is from the page cache we don't want to reclaim > fs-private data from the page because the pinning process may be writing > to the page at any time and reclaiming fs private info on a dirty page > can upset the filesystem (see link below). > > Link: https://lore.kernel.org/linux-mm/20180103100430.GE4911@quack2.suse.cz > Signed-off-by: Jan Kara Reviewed-by: Matthew Wilcox (Oracle)