From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DA7C77B60 for ; Fri, 28 Apr 2023 17:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F606B0078; Fri, 28 Apr 2023 13:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50DFC6B007B; Fri, 28 Apr 2023 13:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FD4D6B007D; Fri, 28 Apr 2023 13:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 36EEF6B0078 for ; Fri, 28 Apr 2023 13:12:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0397A0143 for ; Fri, 28 Apr 2023 17:12:01 +0000 (UTC) X-FDA: 80731442442.27.C0BBB20 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 5AC1914001C for ; Fri, 28 Apr 2023 17:11:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682701919; a=rsa-sha256; cv=none; b=qlhnU3nKW23Iex7EWJzqmiqgJ16D8bfNn7NNE8YKC+g+u04GGryBEGyzAPUQPg30wdsIao eIkl1EpKvruWjZ3PBoLewOnljaFnsrd2WA6NTE1eeAYqFfn6YynDg82TF1hcSDboDlEDId EPM2NWPZPTbWVnEv9G5ZP+NKl5kJNNE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682701919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dv4VJUZKnl4kkF46naPfmIUVcZoylXdHGW8K+eCiq7s=; b=kndVo7FFzMJ+QX4S1txUGSF2oypFsNztmd6XCIr6w3kKLGDkBug656wzk0pTUBa8FlYwv+ BLgd1aFSULHIia2QGRLt8lZLNGgOP78iKUEY9VE8K/wl0rfDs2xihuKiFRfZGtLSiYu7xa 28PYMkCQj9bmdkv1bAvRBARkSsRxcWY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 496A16198D; Fri, 28 Apr 2023 17:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1627BC433A0; Fri, 28 Apr 2023 17:11:56 +0000 (UTC) Date: Fri, 28 Apr 2023 18:11:54 +0100 From: Catalin Marinas To: Jim Cromie Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] kmemleak-test: drop __init to get better backtrace Message-ID: References: <20230425222446.170486-1-jim.cromie@gmail.com> <20230425222446.170486-4-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425222446.170486-4-jim.cromie@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 5AC1914001C X-Rspamd-Server: rspam01 X-Stat-Signature: msj9j8iue3uqhe94c7yesdirn8rmpski X-HE-Tag: 1682701919-870738 X-HE-Meta: U2FsdGVkX18CObVj/A2QBrVdg+GeG9HXIH4nA7/zu+vnjpen/e1lcWvXDmaSYAWpS5cgTEci4wR0A7+oel14JJb44qe7+/3U44JSqrf7LiP+up7ZZvKYBQ/xywtHv5TW68B/yg5OfsXqAl9iFvZ7FVBhuAP0J/imJ/ZMg/ZUREShWcTkyw+wZkkpz8qZmLn8YnWqjwkimq054GF6COOmR5PYDwbuJ6EiOhmJjWPgH3zeA6NQqSOzXAlskDsKmexP9zHzgCi2kpvXX8jyxwplTYBBl8a45HpPVuzBzBMO9kfyXDdsHa4Dk+f97yYQdZafgt7jOk6nuQl68Tn2sza7ZH0Hf7rJgu0zxmTREkEfq7pSembIhwy9gdRhLaunFXgPBtbaVrnjcA5AEd4h5sId5kTSnh+bNZ3EMn8gEeqAZkQm+odrfes6L2jrK+AE9/DvSFXt2vY34pm4nhBWDYbi3WJ0OFXtfUPR78WAPtPQQvJIoYGhMOkCMyzfqZkq44jWIT1TqbOT1eAwOKjlTwDN7uuhtXTOX16aI+5z+DA6n1u5ULE7fgFLMS8oZfJzHHyTRi7JD9gKu1fKduTFU9co4nJo9dr3onlvTrt6c0ftgu/Sp99+zGmRX3Gi3HMNxqGLHAD7h3K9G3Ji28H0INYMLQg6BNIB1JD9VsgxxAiXaei6EAHgyE3Ut7opVz4QGS/v6jCqBU+ZRVQyFzg3j2bEDbZhq3dyMCuWW9RCYAV6ihdS6w6Cwz1ckBmykkIKaKfWaDp5q8EC/5QLbKWNmAIZjzDonrHXuNSTfT917+9KOjQXngB+BqOHXg7zl9qS6slTbQUuKpt4q9SvLv/IsgZlYCZ994iXSjfLKJp5nd0D3OlhFaRfsrBUc7QxMBwy7qtGkb1gKGe9UJiEqIuAQfbkTf+o0uVpyjSQzwjj9DNArEsZTr0zRZJJEtzlaMTC3eFJsYrK3fpQ3xNUnIMDd8+ bXhTltHf tVv7AxlxBYzzwwTXsoJ3cdvJ5wXqS3eyQuWZWccJTFaLXMPauSUM4R861s1z0Wi9U9yJZy2k8Y1HSWzhuIf1H+xX9hYopnnvL+7YPlEsN8IzESD6Uv0riRaPZoJDl7bQMXlFUeLKc+5FsaRPwg2DIPrYNnem1/sNMe1IVpIOn4dZOjLCNT2WvUoLgBK8JXOojE/2j9miAcRuwy+uY/2BZbYnBUVwVuBMygWwzc/sEUcW6npCY9pF0+1KWmVz/T+yax3WkDTINQ5ko9goE4jWvhad/24PJWdc38TL5NPTW70yl1j1+oApyHbZPtgoS50ug4ggN68Vcp3UGQz6uQdMz0HOTTQDN5nM4gPJqyuxjxWPTpL4UVOgE4gRTFR2OkyDbwILEiEI2VGN/G+4pTtLXSTv4nKEFobeJvaId8oUjW1aBY9JrD4PLjTPl8yfY89kQDCcd7plZKLgHT1HVxD+2hKWbPAX2b/LXAKKiBVXzU9KVwI8gaHG9MQqmo3yvHJ9jN7qUTqcknxX84dhAcQYPNXnn32Nvo6EdgVVN2t1vLHOg8slRrTpaH+kayGme56U1oPwBSd5iaqxQfKpPbekTaZJrSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 25, 2023 at 04:24:46PM -0600, Jim Cromie wrote: > Drop the __init on kmemleak_test_init(). With it, the storage is > reclaimed, but then the symbol isn't available for "%pS" rendering, > and the backtrace gets a bare pointer where the actual leak happened. > > unreferenced object 0xffff88800a2b0800 (size 1024): > comm "modprobe", pid 413, jiffies 4294953430 > hex dump (first 32 bytes): > 73 02 00 00 75 01 00 68 02 00 00 01 00 00 00 04 s...u..h........ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace (ck 603070071): > [<00000000fabad728>] kmalloc_trace+0x26/0x90 > [<00000000ef738764>] 0xffffffffc02350a2 > [<00000000004e5795>] do_one_initcall+0x43/0x210 > [<00000000d768905e>] do_init_module+0x4a/0x210 > [<0000000087135ab5>] __do_sys_finit_module+0x93/0xf0 > [<000000004fcb1fa2>] do_syscall_64+0x34/0x80 > [<00000000c73c8d9d>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > with __init gone, that trace entry renders like: > > [<00000000ef738764>] kmemleak_test_init+/ Acked-by: Catalin Marinas