From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1385C77B73 for ; Fri, 28 Apr 2023 02:56:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19B4D900002; Thu, 27 Apr 2023 22:56:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 124BA6B0075; Thu, 27 Apr 2023 22:56:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2DF3900002; Thu, 27 Apr 2023 22:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DE9D06B0074 for ; Thu, 27 Apr 2023 22:56:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9748FC01B9 for ; Fri, 28 Apr 2023 02:56:24 +0000 (UTC) X-FDA: 80729286288.13.02B5068 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 81B24A0030 for ; Fri, 28 Apr 2023 02:56:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=seHWlYgd; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682650582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEdI3Z6CTreItykU8veCrx/99eYfpK8Gh6SV7amEBi0=; b=JkYSXN+qF27HsY4VXOm8dQVsmeE1CXvW9berDjiYz/k7u8bROO9x4CnpFlKVlorGoW/jRd ky7Xe1BWKkp/QfbtmEVv4I5hsrCuq/uGVJQSLe0OSSJ4uqYYmF+Fr5oDxlyTu64wRMIoUl x6TqPzhGMTGOea+OCnkL3cY8AwocS+o= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=seHWlYgd; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682650582; a=rsa-sha256; cv=none; b=X6qDBoaUH6vIi1GSqNRt4OgCUAyGM1W8afwhtkQ6csCk9cI30fP8S8+yqUpfLDemHw+PGM W7OYYZfe2Oo4JvrkUQoolCLXRO6MIHKLBONp2dXC7zooBF22FTLkJ32FSGsXOxlv7Ggioc eN8RLtn+bicYamjKYZ4N/ZUXcXehaiQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mEdI3Z6CTreItykU8veCrx/99eYfpK8Gh6SV7amEBi0=; b=seHWlYgdjaUbCRl6TG4VMh99ch ec4Fp45TlwMoxnqctUCZKm7uqeycSIrPUi5fz5wUZ31MHTYGMGR7f2xsaEknDSsz9hyTFOl0WfLog B3VCyrkETgv3yDQtGBTBMKEJi5JdJhiGx7qrFRvTyI713pGaXWUGi/v4tBBuJdTMaJr4uL75bRDsE MRC0tgp0I8cwg5AQrfy0yDVG6E1oJcOJJjDJ1PT8TF6+CTvCgxqv/8OXhgifrnP2jHbqnAmQvQUjy zpmbKaSPq6pDZtbMCwmeGBgJLvnEpCRab+pCkONDrx7ORrNZgJ1WCdZfCRBt8ieIRhfWSqwFaoGpk wV4sSxqw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1psEHN-004Br5-Mi; Fri, 28 Apr 2023 02:56:13 +0000 Date: Fri, 28 Apr 2023 03:56:13 +0100 From: Matthew Wilcox To: Dave Chinner Cc: Ming Lei , Theodore Ts'o , linux-ext4@vger.kernel.org, Andreas Dilger , linux-block@vger.kernel.org, Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Eric Sandeen , Christoph Hellwig , Zhang Yi Subject: Re: [ext4 io hang] buffered write io hang in balance_dirty_pages Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iju77wfuhu55jgsujyw9ajndko1868i5 X-Rspamd-Queue-Id: 81B24A0030 X-HE-Tag: 1682650582-901998 X-HE-Meta: U2FsdGVkX19fQ8fE1x5hlnpRn0R+Ws2dJcHEqBGUOQqtnd2/MN9I2XcV9asiU4eAZ4YneaCDuP1+j+m2wgOApRVFWsV83vGDSC1E1hxJmZyrl4sC4YNn+7+bQZ+qDX4DG/M5uteDnOA+kdCv2PYn4rUCDmWXKVIyW8zWeOHGsXmVqZLgsU3f7LTflab9mHcszO9FDfY2/NX0lJB7mRrfVMSw1qHNBSzDNwtvu6yfA4COe1kQ0rJX7iJT6AmvJGpwzndSpf4rrZ2GjNgf7pcVhP40G72tENY7v1ioEIeWRCNG5bDCRlHKiLkTLcpDIOu712BNbsiBzNdu3by11Dc+ByrZqyrLKcezlVkFlor3t0s9wRHpVrKSsSp5lqL1gmMNLsRiNJ9zzXYQ0htXv6EyIFCG6/R4mfXXrN2JTPuKDq5b6j2iMkjGki8OjoHF+89KinJo5z3+MUt/DwkMDrael5DHMaTi7e/gvs1I5AGJ8GmRsbov+t6lPbyjMXFGASjiSHtluZLfC49k67D1/LfEJi9ZEpso0Ya3YRbmqWuazk2i4xgu453pyO+p3sL9ahIZLMD1koX57OK0ESaGbb8IeUnrDYe3pKYladZHrZw++U2ITJ9FyM9aXeyzfo3H5xVLHVRax+SpiriKINZzOotS+UMQ9ch2iw/E0FCukHX+RTDsyHPBiNwhLsMiJR/NgIJrerSYwPOb5ZpQW6yn0DbGi87ojEshkj8RsSfC1v//fRpVk4kGpPp6vPfhX/6eWcAfWiYy23e0ThpOfjV6LUjGx6u/ZCxnjriqWtXRz3iD+YFG+iTuI6X/Qj0g7J3DA92EQQIXrSR3KMv+JumTanhzKDkQvi9wK2iGZxCUuEwWVYUudph6c+RscDdhqbtBfbx6N1YtzTWbXGKn9kYnbaFdnQLULbFZ7lwByMUSorUpZnuhnde9hLD8oMCiPb+k/KwxyqClRW2kPCrj7lgLv30 I/D/XzMI SoVtzg9RxriMTtbPymFil8EL999uiW2Zcja4TuvNvLw6cFvdEJZe62CSEM/AOqtG74Qr5d1U93VledWp/wIcOm0v3yQSyGi/0/JowuDu3Qwh+tWOvL68gxLQRvFXR0FDI9g6XeZeSw6UxsuFY/kMqxdSWLkH3ms/WkXbYFCi8bFU5SxBA90+bUAb6IQobtoS0MFYUljFj833cORk2j1h9i0X2j/nh154254baJKaCyqfrSQmClvKc2WMN6BE1tRHwxdC/H6jdyP4x7yL9xOdyqWFlWdG6ll2adyyg5Tbn5h0/rzQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 09:33:20AM +1000, Dave Chinner wrote: > The block device needs to be shutting down the filesystem when it > has some sort of fatal, unrecoverable error like this (e.g. hot > unplug). We have the XFS_IOC_GOINGDOWN ioctl for telling the > filesystem it can't function anymore. This ioctl > (_IOR('X',125,__u32)) has also been replicated into ext4, f2fs and > CIFS and it gets exercised heavily by fstests. Hence this isn't XFS > specific functionality, nor is it untested functionality. > > The ioctl should be lifted to the VFS as FS_IOC_SHUTDOWN and a > super_operations method added to trigger a filesystem shutdown. > That way the block device removal code could simply call > sb->s_ops->shutdown(sb, REASON) if it exists rather than > sync_filesystem(sb) if there's a superblock associated with the > block device. Then all these I think this is the wrong approach. Not that I've had any time to work on my alternative approach: https://www.infradead.org/~willy/banbury.html