From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EABC77B60 for ; Wed, 26 Apr 2023 23:12:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2B26B007E; Wed, 26 Apr 2023 19:12:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C92B66B0102; Wed, 26 Apr 2023 19:12:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A776B0122; Wed, 26 Apr 2023 19:12:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A38296B007E for ; Wed, 26 Apr 2023 19:12:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 67761804AC for ; Wed, 26 Apr 2023 23:12:41 +0000 (UTC) X-FDA: 80725093722.09.905C787 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf01.hostedemail.com (Postfix) with ESMTP id 638F140021 for ; Wed, 26 Apr 2023 23:12:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=mit.edu header.s=outgoing header.b=kY28SrgC; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682550759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a28AE7O4X83WWFRQ6/mRv8wwHivs9drRMGuAgV2hNZk=; b=F2Ldz8vdBidZbr9tDxzdh+fQ4O+I8afVJ/EYTt4qsLTwbIBU7Vupe2nY8AEZVlXeDAkmYL mxLEONyRZkYNucoml35mNCEG/eivvaDXQ6Tpv9GLQv+W+fwpjMs1+iewj9LJ8s1+JA/dC2 Gu7LL2QfP+fV4sh+fBN8FKd8CnL/xZE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=mit.edu header.s=outgoing header.b=kY28SrgC; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682550759; a=rsa-sha256; cv=none; b=awK7aNv5Y4de2lbN7lHI84iWGVm6yIVjeUJiWf1UTOECQzPHMbRiLcsyF/t5aZPboxBN5B 9bNyahGTwwN3TgnDBgOdqAdANDhsvIEznX1mVRr7ZScLaJHP/Se7RrOp+WpmkqnE36MgOc A2O1vIIpUH/B4g9/nX2CSy8pFeAFz9U= Received: from letrec.thunk.org ([76.150.80.181]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 33QNC4rL018996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 19:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1682550727; bh=a28AE7O4X83WWFRQ6/mRv8wwHivs9drRMGuAgV2hNZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kY28SrgCLZILV53+lsfg5h5l4QnFMhzMkUbS0hwj0iZDGfLlswNTyZ2M31mmjDvJw ifLN2AaAgKQKDA43ZILHlq2+tJl/xEC/dGageHbtWrvOC8KfQvO+IxJngJPeudtbD+ Hx86xFyGSUkznglbZHZWlImznZY2MWZ2L2PZ2gxLUMsnOb/h0Wm0c5JacwJcwM8yE9 YZRpbkgG6hL56MW2lj0/xLKMntGZ74EvoK0mNviWl6fPbfpJ40lteUNViJ+bp41OA5 hmTCRvNC32iQoOIpTENMRjv9qooe7XZIzYMDmh5dG43++p8qTwj3zryE1WoDQs3uUe +nX8+YLtZSWaA== Received: by letrec.thunk.org (Postfix, from userid 15806) id CC6718C01FA; Wed, 26 Apr 2023 19:12:03 -0400 (EDT) Date: Wed, 26 Apr 2023 19:12:03 -0400 From: "Theodore Ts'o" To: Matthew Wilcox Cc: Linus Torvalds , Nathan Chancellor , Nick Desaulniers , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dan Carpenter Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window Message-ID: References: <20230425041838.GA150312@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 638F140021 X-Stat-Signature: 181dpkhtf6nm67say939xo7mxwit161t X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682550759-986057 X-HE-Meta: U2FsdGVkX1/y6YvhWMcEvB0Fsd7IOSSH9A5ez99qpJFxLqVfh7be/Ex1RLHKUmY4C/48/9eu72z+YHwvFwL3lD3Me8MkmRIye4yNgJulk1YTApzq4XocaQGvqvMPNzxid0Ms5rjQwW0BOA9vMbeXzL2y77xZE37k0IglHZf9TRP3jI41N64Qll2DtKIKMncfknQSutsLR+Zxx4RwqhOyrMikqUKYA9DyJ0s9sZiIKtEK3zALO3C0k91M9A9+BL4z74lyu8icQt0GF8lDh/Z4xPBL3Mhpt1vYy8jN0z4i6Wt5stRHxpnKa7sz+5tRSDVKNV9crDVZnlaI/VdxWBkyScFD47R3+/NMcWUaoUNyNGL0o5SzVZEIuYbzBbo3o8LIzMazhcyM1a+3HHkfTRKrfWAz4ZKFybRcFCDQA/at0Dt0XXDZoddwy1X5B8UPkrajAy9QunqxzbMM7W1kAd1tEeyV6q/9B+NKKuUbixWm9VXRxcg31p0gWUUrWj/s1Jq1+230F4uLEhMfsrFj9+JWaznw5oaLIwgyHuGK20reOODfCw05hqB8xUlM1cUbmjqa0R3oh7K+POeSP9AfFMo9BqE0fJtEsd1wX+lVOsXZl3s4qL9pwZJW1XmQleTc+EqDn7fV1q4ac30w8cyO2NDPbLM0ApKZbHvtsMaDUSLGnybRlFzskKeXHvwOqREg865Q/W1gd90W/5/nyTiN+eaDJBwwzgwAXxHionY4X9k8zNAjrI41VBQTRB3EkZ/26sle7GdTJ50aemQMXI0g2ES9i22drMg6XOH+XZV8XiDhp3AMzDz+JEkrKoGTVx07/XgqUcHvtEoi6W6/rJBP+B56SolaYqVl84kobBHohKZgOu2qlk78pRw3zaQ1pVNkk0azzhE4oiBRBJOEIJHmu4IAO+H+CVnJVA3la90ycmOdFt2MtEAC/GZmAi2GLx2NtmbSDNK00ctapSEas/m85R/ qI0DSPOT lsCcESkM8ENUmihZp2yNtbup0AzopQqwmx2dH3Ftvo7HXaj6ici0lVLh/bT5YI2acBZF3M12k/VKDtIpLQ55xsSRNCB18RYHk7LyrCN+adUpyZlCIdf6+eyFkYyX6uEonBzTlNvWmACGnnCmwTzY5/YGuBZzE52kWKGahyQOGqRZCC2Y8VgLY1+WMiqoyXiWOh4lXmo71hkM74b+mCzHSYSuFAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 26, 2023 at 08:10:58PM +0100, Matthew Wilcox wrote: > > This feels like something smatch could catch. Adding Dan. > > Unfortunately, I don't know that we have any buildbots that run smatch, > and most developers don't, so it'll always be an after-the-fact patch > to fix it rather than "anybody using W=1" or "anybody using C=1" will > catch it before it gets anywhere near a maintainer. Well, if we can ask Mark Brown to run smatch on linux-next, we can catch most of these things quickly; in fact, this would have been *only* caught on linux-next, since in this case, we got caught out by a change in a function signature happening in one tree, and a new use of that function in another tree. Is this something that we could teach sparse to catch? - Ted