linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Dan Carpenter <error27@gmail.com>
Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window
Date: Wed, 26 Apr 2023 19:12:03 -0400	[thread overview]
Message-ID: <ZEmvw4x+M+4kgENG@mit.edu> (raw)
In-Reply-To: <ZEl3QmF1PYXKaBTz@casper.infradead.org>

On Wed, Apr 26, 2023 at 08:10:58PM +0100, Matthew Wilcox wrote:
> 
> This feels like something smatch could catch.  Adding Dan.
> 
> Unfortunately, I don't know that we have any buildbots that run smatch,
> and most developers don't, so it'll always be an after-the-fact patch
> to fix it rather than "anybody using W=1" or "anybody using C=1" will
> catch it before it gets anywhere near a maintainer.

Well, if we can ask Mark Brown to run smatch on linux-next, we can
catch most of these things quickly; in fact, this would have been
*only* caught on linux-next, since in this case, we got caught out by
a change in a function signature happening in one tree, and a new use
of that function in another tree.

Is this something that we could teach sparse to catch?

   		       	  	      	     	- Ted


  parent reply	other threads:[~2023-04-26 23:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  4:18 Theodore Ts'o
2023-04-26 17:03 ` Linus Torvalds
2023-04-26 17:34   ` Nick Desaulniers
2023-04-26 17:36     ` Nick Desaulniers
2023-04-26 17:43       ` Nick Desaulniers
2023-04-26 18:11     ` Linus Torvalds
2023-04-26 18:22       ` Nick Desaulniers
2023-04-26 18:32         ` Linus Torvalds
2023-04-26 22:07           ` Nick Desaulniers
2023-04-26 22:31             ` Linus Torvalds
2023-04-28 21:02               ` Nick Desaulniers
2023-04-28 21:18                 ` Linus Torvalds
2023-04-26 23:16             ` Theodore Ts'o
2023-04-26 19:10   ` Matthew Wilcox
2023-04-26 19:38     ` Linus Torvalds
2023-04-26 23:12     ` Theodore Ts'o [this message]
2023-05-03  8:03     ` Dan Carpenter
2023-04-26 17:06 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEmvw4x+M+4kgENG@mit.edu \
    --to=tytso@mit.edu \
    --cc=error27@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox