From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0054C7618E for ; Wed, 26 Apr 2023 15:27:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7293E6B00F2; Wed, 26 Apr 2023 11:27:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DA156B00F4; Wed, 26 Apr 2023 11:27:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C7696B00F5; Wed, 26 Apr 2023 11:27:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4CF906B00F2 for ; Wed, 26 Apr 2023 11:27:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 067F81C6778 for ; Wed, 26 Apr 2023 15:27:23 +0000 (UTC) X-FDA: 80723921166.08.C5EBC54 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 3A0EAC0022 for ; Wed, 26 Apr 2023 15:27:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QDiaNXkK; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682522841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PxTXn2BTS1MgLfa6uUxx1IJIGot7tRzMX6mJKeRAOU0=; b=sEK7kMgyDTZZr1yKcBdb96feseGT2n2JR4xzWbN5IQK/kytIk5uFD8nJmXRfG4r9dwyEy8 Oj9E7nYxhiZZ9cqviea3bOoUpweqe0jqpRVbwdcB0SoDjptZ8v6IvAeooW+8oNCJxEXWd9 Wzh7yxvOHqZBc/0mHI31jbsgnCL0bzg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QDiaNXkK; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682522841; a=rsa-sha256; cv=none; b=IzNEY5PpOjeZM8g6sL5LD4bRMH+qhm74aPSJdpTsas0gTli8Sll7bNUPJV24mtawGbZOrS FCaEW5Ayy47TfC5AN0V32meGARfRjeF4WnHSS9lrTJjpPpuhCa/elm3Z6GAH22Y414r2YJ m9tjf5+AmTw46UXAoP3jiGsurZo5DtM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D86A521A17; Wed, 26 Apr 2023 15:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1682522839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxTXn2BTS1MgLfa6uUxx1IJIGot7tRzMX6mJKeRAOU0=; b=QDiaNXkKB3uTdY6B9oH8hNNCSYV+uqkT4a1892oDrK572lszPhfddPLLMre1CgTN3Dsf5G ScrUsE1jjfCCS9RdneK3ReDxQPcYS0UeDH/7UrhHe7/jwYuQBWILAIQmwaaDfjMZvTqx/I Ekl+fSwPwceAjY3EN+9UF9Yv5eHU6lw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF9B5138F0; Wed, 26 Apr 2023 15:27:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YNWXKNdCSWRPBAAAMHmgww (envelope-from ); Wed, 26 Apr 2023 15:27:19 +0000 Date: Wed, 26 Apr 2023 17:27:19 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 Message-ID: References: <20230426133919.1342942-1-yosryahmed@google.com> <20230426133919.1342942-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230426133919.1342942-3-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3A0EAC0022 X-Stat-Signature: h5io4gpynu9ipp7kbuf4m46dwbpjf8ug X-HE-Tag: 1682522840-819789 X-HE-Meta: U2FsdGVkX1+umuPGRf2SuazqlboHWNZ+ndNQzqJ4br9MRlpv/QKr7AaoS39Nz7YAvWdRw9ONNozlRzU0dTei2Q7i30XStL5WugsPBeqBEqm5gd1XwmIbUEleObQ4kZ+xHEgxXA0aGmaLXBxEvXawcCJ5bUAfO5FrNxiVHaQR31anmNwGTnhCgzR2AUWIov9ZXxQckej/bO1VJWTpUbk+bx9LEV8FogiqnHA38jz3/WPPEBSLpkBumXW1uyHLoLzGB0mOtrGPjfoUig8ag9X4xdCDx2qyw1bqdbOZtDlCWDlGPcwBdQk8QyR3d0mIyVH4FmPyzlsVhp53UEZ3zsK8QAcanhivPjyQL2TPi4QCl4Bi63cLw/79r6ijQBKmen1kqLerwEzMHP8NJt3Q9ZM80dxDbdEApBc5OamrmNGk9u4jy/Qh6iB5TxS14vPeLeFzmwRsG1U+FNVNv4ae9m8ykWtlnhCREzVvoVX0pI/avw1Iikq69BmRm2kdk/te/j4gwFmpNe/9ANllO/xSA4ZqWo1Qc5hK4fY9nxyNYSKaYtBV/20hujRn9HF47z7l0lTAEA6U8RZTZjVMn1fURJkFH8fPv5AgBiH+J/1odCy6S1LZ+O1wR+e9nVkI3Z0y7FStN+ctJ2htuOa42CM0gZ59S6FdwyjmX6wilvMTw+dIoQ1Z1EfcxJmXLFC/8fhjgr3pTYfVHgQFa8s2QVT5XxtnyAuCQYfGdQ6WqqwWYutVbw+d8weQx/xx3leQGPF6FqP61eamyyCIinaIr3166dLnK59y92Pn5iXFaaJiW/8CL96fX2ukRfI5+xhse2shMNtg4ZTpu9p54prge1+2C5/tVViTCfWXQf0pQniiKFsUp+JjnKIQ5VIYScPjwwTzbWxDL850O0pxTJjTipMN83mvnMujKugsxpu2l13hG0Ea73Qsa97ta2sMRIf8guaD8pF8cnNuXDiDRlFBaHUxx5U R50SoyrR ZmX85putPSxJuGs4jxfkVPCtSz9eFDxQYtet3M881lKzXqNohW7I6K5StJ8AAKIm2Bm5Z74cTC99R8R8FEC33LbMiwkszoOMzLy0w4SXbVDVopYIVJCFfv+Jexkbz+PWPbHYYWZl8mBwT1lXRi9enmOLfog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 26-04-23 13:39:19, Yosry Ahmed wrote: > Commit c8713d0b2312 ("mm: memcontrol: dump memory.stat during cgroup > OOM") made sure we dump all the stats in memory.stat during a cgroup > OOM, but it also introduced a slight behavioral change. The code used to > print the non-hierarchical v1 cgroup stats for the entire cgroup > subtree, not it only prints the v2 cgroup stats for the cgroup under > OOM. > > Although v2 stats are a superset of v1 stats, some of them have > different naming. We also lost the non-hierarchical stats for the cgroup > under OOM in v1. Why is that a problem worth solving? It would be also nice to add an example of the oom report before and after the patch. -- Michal Hocko SUSE Labs