From: Michal Hocko <mhocko@suse.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>, Chris Li <chrisl@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1
Date: Wed, 26 Apr 2023 17:27:19 +0200 [thread overview]
Message-ID: <ZElC127xlU2NtlqF@dhcp22.suse.cz> (raw)
In-Reply-To: <20230426133919.1342942-3-yosryahmed@google.com>
On Wed 26-04-23 13:39:19, Yosry Ahmed wrote:
> Commit c8713d0b2312 ("mm: memcontrol: dump memory.stat during cgroup
> OOM") made sure we dump all the stats in memory.stat during a cgroup
> OOM, but it also introduced a slight behavioral change. The code used to
> print the non-hierarchical v1 cgroup stats for the entire cgroup
> subtree, not it only prints the v2 cgroup stats for the cgroup under
> OOM.
>
> Although v2 stats are a superset of v1 stats, some of them have
> different naming. We also lost the non-hierarchical stats for the cgroup
> under OOM in v1.
Why is that a problem worth solving? It would be also nice to add an
example of the oom report before and after the patch.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-04-26 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:39 [PATCH 0/2] memcg: OOM log improvements Yosry Ahmed
2023-04-26 13:39 ` [PATCH 1/2] memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo() Yosry Ahmed
2023-04-26 15:24 ` Michal Hocko
2023-04-27 0:55 ` Sergey Senozhatsky
2023-04-27 0:45 ` Sergey Senozhatsky
2023-04-26 13:39 ` [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 Yosry Ahmed
2023-04-26 15:27 ` Michal Hocko [this message]
2023-04-27 9:21 ` Yosry Ahmed
2023-04-27 14:06 ` Michal Hocko
2023-04-27 22:12 ` Yosry Ahmed
2023-04-28 9:44 ` Michal Hocko
2023-04-28 13:05 ` Yosry Ahmed
2023-04-26 14:19 ` [PATCH 0/2] memcg: OOM log improvements Steven Rostedt
2023-04-26 14:20 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZElC127xlU2NtlqF@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=pmladek@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shakeelb@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox