From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08635C77B7C for ; Wed, 26 Apr 2023 19:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FBDF6B0121; Wed, 26 Apr 2023 15:11:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 684636B0122; Wed, 26 Apr 2023 15:11:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525106B0123; Wed, 26 Apr 2023 15:11:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3F9106B0121 for ; Wed, 26 Apr 2023 15:11:15 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 007D3140311 for ; Wed, 26 Apr 2023 19:11:14 +0000 (UTC) X-FDA: 80724485268.12.2B0DED6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 9DE328000D for ; Wed, 26 Apr 2023 19:11:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V4rqb9Gj; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682536272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Wb/P2xFQ0qJOYrnBz5Avm9fdE/pWEgv5HmuVSwHTpI=; b=2WsrnGldYUL3JD30ZB9BLv8eqkLZnUqeuzv6/DLQFsZl6h5H735GWLIwoUJnOmPk4tA1/v x9mcUDBGawxjkZULQIq8qZH5Nzl9kf3qm8adbqtGD+TKcTpjglxLyMkx8HZwnT0o0NgAAH /CCMMe9kHHFkw/DOF1sdgh2CbbiTtZI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V4rqb9Gj; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682536272; a=rsa-sha256; cv=none; b=b2Lj4IwtJg3Q/0FeFTd1NId2+YmqmRZbhSdOQK7w1SAGYmCVYgnbfA76d+/I79s05wDBgz iAaIZ89rAUC2oC0C5Pfk1ueySBfVO4VQAhCKj1/79HL5I8XeovhjY5YVgJzvvhm8jRiit7 O9+mrO8eojqMyI+XzR1JAzZZT0HeL2U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=8Wb/P2xFQ0qJOYrnBz5Avm9fdE/pWEgv5HmuVSwHTpI=; b=V4rqb9GjOm4zKDRpmbAXaNJpjY VydQTVOOuTDmbvHN2RjHvHJD6cUB4bH2V3fKV5D2sPe8kh4pdOLzKjYVOlKhBidPuLBgnraL9ciHW 3ngB9Re3osHIEHSxnnZ5VSo/5M/H0k+z3waSO4qYM93YXuL/XXpJZToTDFlqL7uUy0LRhw2H6TWSy 9xzFUA0U1332eNelHwm7RiBcov8XC2n2PTOQYiRqloZKrpxHloYa4tw7p3DJgBifFvJDst97g7d7O RVFOFirHYd3dp9oCqWMpeC2SdOolVLuVceSHB9YJ3AlQ14IYNjtwV1PyCNb5sIngIpaVEq8XSEDaa 9DkDLAng==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1prkXa-002lf7-NW; Wed, 26 Apr 2023 19:10:58 +0000 Date: Wed, 26 Apr 2023 20:10:58 +0100 From: Matthew Wilcox To: Linus Torvalds Cc: Theodore Ts'o , Nathan Chancellor , Nick Desaulniers , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dan Carpenter Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window Message-ID: References: <20230425041838.GA150312@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9DE328000D X-Stat-Signature: z4nu8yxawfnpa31ejo5m9z3hf4wyaufs X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682536271-939000 X-HE-Meta: U2FsdGVkX1/ysTndxRNUrarIRFdOSSa3T4U/xJzbSq54UlTT8JRl/ZIFYr1ZuOMWUFsME7h9/gEmroVimWegpdt2zZok61zE1yCyHg5VtrM4fGo2d9Nqpn7H0D/gSPrGPL2gn8wa9/+ufn5QsU/IKnAlQn+eLYzbYkYRHbXYax487Z6SPtI7hfKowaRS2WO+Hp4xGK1Z7zwv/vkSv+K+zy/UgsYiOSOu0DnI+orvFsEAeYN7CLpkAybaamtHakqTxnIVXutpKUabQE7owFxmzGjV33PUxjpjwnrNztFVKmsmhYfi+c3X+h+NlxHqnbcEd2YixZlWPkPZJE0nLz/QD3sQFBt0wbtmzxyoQB+0dJ8i35bYwHaBhj3poaxIcduEQxB1qj3oZowsIwKGzJScgJiO7MhoBSGXP4YtojvFp1kfZsatrEVOEkpzAuhPFG/SdtFmi7h4cv3NTzfNKPjXxufm3ZjyQmQVIvDKlo9ucvkgSKo3uNSRSaw951uNqQy/o/6U9j+n328qxAOZlGG/0hSDYERfthcLLAuxWgvIydGaMhKzoiQjy2LuCAxKpGnW1UdhfAPXcfWvpnSsTaV2U2+7LX7cTG5F6Sdlld5aHn2ga/FhHuQEZgndwZW6DHbB5glCc2V8dpddSudDrfD/UlKJm0umYcUNsHYZde65QX3Z9kLsPqRid0vVHMyIsXqKXeMoSrZg7d/Hp8ElTjdnq0H/ZehxynMnWIhRXS4TcVDlrEY7tpPmTLCGSC7WJGZ0uQfsiwNQtWOVKEIbrts8xiegpWBNC2fzdUKo0xqxn7p8wlzXvNaYEIsVPoPmbRRqsnT+vXV/4T/BUeWJ67LiujXnExIe3Q5Pihckg9RojCvO420b7mCzFQESl4TD6f6tBRU4jFw2RMTU9WszW1l71WzNW7wgTbnrxL6XQ8fyphHeOnq1fvuEgKA/xeYI3v7ghXtfunOblFCeC9uOHJR EGBs3H7J dQGJYLoCpPlDrsl5l0uxdsrgry2mEy0dmGY5DZycmCFTWr6kanwoetrIxLM8LbtfZaB0mUde0vDjTCSgdVwU1sY3fiMOBlBu2tmVvL1PZMAoEe5qREtry5NUoE99y6Cvh62LgwbCXoEx5SU3RUWaJiZ5fGYaJ247/MsfCOF0NlBDFqpv2R451kmjuJxD+HJ0ERstfGn2qNtWg7lP838f3J47BCv7VcGIyg5g4bPxdAgVjQlVBsj7Ofb6NPtnQWMxGZeUN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 26, 2023 at 10:03:37AM -0700, Linus Torvalds wrote: > On Mon, Apr 24, 2023 at 9:18 PM Theodore Ts'o wrote: > > > > Please note that after merging the mm and ext4 trees you will need to > > apply the patch found here[1]. > > > > [1] https://lore.kernel.org/r/20230419120923.3152939-1-willy@infradead.org > > > > This is due to a patch in the mm tree, "mm: return an ERR_PTR from > > __filemap_get_folio" changing that function to returning an ERR_PTR > > instead of returning NULL on an error. > > Side note, itr would be wonderful if we could mark the places that > return an error pointer as returning "nonnull", and catch things like > this automatically at build time where people compare an error pointer > to NULL. This feels like something smatch could catch. Adding Dan. Unfortunately, I don't know that we have any buildbots that run smatch, and most developers don't, so it'll always be an after-the-fact patch to fix it rather than "anybody using W=1" or "anybody using C=1" will catch it before it gets anywhere near a maintainer.