From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58639C6FD18 for ; Tue, 25 Apr 2023 17:56:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E14556B0071; Tue, 25 Apr 2023 13:56:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9E9B6B0072; Tue, 25 Apr 2023 13:56:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3EFA6B0074; Tue, 25 Apr 2023 13:56:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B11FE6B0071 for ; Tue, 25 Apr 2023 13:56:50 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 57BEB8029C for ; Tue, 25 Apr 2023 17:56:50 +0000 (UTC) X-FDA: 80720668980.20.9A55495 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 84EBF8001A for ; Tue, 25 Apr 2023 17:56:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sXQiIYjL; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682445408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IKbCnwH1TA9yC1TlMAtUgmaVJ8UiFakjRZigpfu/WWw=; b=fHaxuj6tUNl8ZvL6JPhXlSpfn9uQSf0cJ7yzd0/moM7QqozS0l1uer0BVsI02hdhMyv74t u3p6XGjGNvMLqqiM2N2aB7t1S789Pa/dFXom5uNN9eJowmnvEToW6PWDuNQDGWH2EqKemT WM0QUe7HdV8Qxv5/ERR+nWoJ7ZBvjjo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sXQiIYjL; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682445408; a=rsa-sha256; cv=none; b=V0ngTee9gl7m4IaAwCMRAq74fHKAaO5AjoefVl8FaCPzhc+s4ZyPl/v5lzRTaYRGZ2byzW WBnDpsS8ORJdq9BJlTcqVUn/jDpOdxBZDa33aTvANFjzzEpbKO9322ECQajhD6eRtCr3p8 HgCdcJaQEub7jNuQsla7bpGy4refNdg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IKbCnwH1TA9yC1TlMAtUgmaVJ8UiFakjRZigpfu/WWw=; b=sXQiIYjLiJSgyDqdSq/d1YZKWD L3l6BnDrkdUFl2ESqbJSTxoL5yVRNLcVQZjMiBHtAl7Ttr/bHLoTQBYuWa2vdjnLeKLoREp/y+wrs TnhOd56KWkGSiTrT6B5tM3gQ4KSL3AvaTDRIA6YIOMnIv3Eh2mhF5rnV0wmqrojojcW6i/UKni/6E ubwEDSgB6gZLTq9zh2qr+1joEQoKXYFXZX2KFzg2hz+/75vIC/hOwbpFhXIrsaUHCp+mSJAa59OJb TrM+qirgTXCQM75S2eYwao9jeUo/rCSOlXPFlPrDwM8tpsmh6xrGtBwmddm1b00/GB7mbzAmmxwS2 wgbKU+Pw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1prMtv-001fb2-Nb; Tue, 25 Apr 2023 17:56:27 +0000 Date: Tue, 25 Apr 2023 18:56:27 +0100 From: Matthew Wilcox To: Jeff Layton Cc: NeilBrown , Alexander Viro , Christian Brauner , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Dave Chinner , Chuck Lever , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime Message-ID: References: <20230424151104.175456-1-jlayton@kernel.org> <20230424151104.175456-2-jlayton@kernel.org> <168237287734.24821.11016713590413362200@noble.neil.brown.name> <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> <168237601955.24821.11999779095797667429@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 84EBF8001A X-Stat-Signature: 1e1yz6isq895j7mmnwf4a6cbc89qtnk9 X-Rspam-User: X-HE-Tag: 1682445407-861073 X-HE-Meta: U2FsdGVkX1+zSJaq2XEWApjbvWOvIyIuZeZdFrKyTaifjO7Su09v4cv77oAmaQHjvtCkwystQcLd3s+MC1aGQEU9Hjrh6LdR0C6sV4xwRAsYXs+K+D4MkSL/AZntJJE/w6Dc30QuPUa6xm6OMXqJ4gb7RGGVNR8/NU1B8yq9YSYqBGWgdCjElfCMMWxYegWuASgd2OLHXVDJW3DIzT/oIps010+meosZMMBkfa6y68sJLiL/OoXFKElCOqozPXr8aeyBn93eX14rs1PXf53kMfNKYatel2Et4NVoYfkZcWDIgw63vgZtmAn2tIUdqTaAAW8Jy0z9U1cnTDFft5pvM3TSSywR3CpZoiNg2sYmv41Yuun2DZew5J1qQU8tDSusHYOmrH4vJodtZ8Z3BM9aEFvE4syWZ1+b0v4jA3SW+G92NLwa834G+tL902nI1HXF7KLqDA+BfroggCTMaWC0tOBDVE8Dks9GwirvxhHPHAVGo+2Oq04nRrE/JIBwhAgg8qOeLqOqhWrUB9Vk6VrOY+M2ZBlQPTgBLrUouqwqobDJt9rAGlWrocJxbSR8QlCyyM4Sk9N53m9HjEkxSvd5gM3TQuOb5JhCHNwvFYMJMMFXC3fJl2Sf+TsFKGTwk0qGyTF/CstAtPTXCa2Ev5ReokERh61hczTJG0sg2svvSLbgt8qsQGV6ZVawg4rPL47g3USjWX57FZJ8JPUR77GpM8rV4lKSJ8OZahTBT+JECxuKQYRXrng3ESYYzYFF/j9E4Go3lFNmBzhtpp7Yd4NO/7eb2ZYhXRStc7fERTg7QPpcUncI8oJd4XkhDIj3jftMthCC9hJaynkDo2gpu3mhyQIDGPMlXkALV1MRIxELBP65N0SuNxY2VgtpvVxMsS+x7IK06PMsMJLa/f2kQ0tKUxDCnOo6emueT8T0C+7P05JSiifuQNvKMWyZPbWz4XXsjiqS79XAOByj31KqMDC /983+bfX 9iaQ750qvxXkPc+BRFsFlvpnLmHwhPu/dhwdRKKPvcA4l8Hz+msUW1qH3p1tRTUmlCOnS/LN6z1d5H3qupjVB3YKQOsuKvk1uOuiS5lLY2HnwpJpYJm7416t0XImn6d+be0afBlrqWAVDgvnB2FreUUHWs5nAnyBPKig2CKh+y4LVg4AUsNB6fAhzpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 25, 2023 at 01:45:19PM -0400, Jeff Layton wrote: > Erm...it may be an unpopular opinion, but I find that more confusing > than just ensuring that the s_time_gran > 1. I keep wondering if we > might want to carve out other low-order bits too for some later purpose, > at which point trying to check this using flags wouldn't work right. I > think I might just stick with what I have here, at least for now. But what if I set s_time_gran to 3 or 5? You'd really want a warning about that.