From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E35C77B76 for ; Mon, 24 Apr 2023 19:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780316B0072; Mon, 24 Apr 2023 15:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72FBE6B0074; Mon, 24 Apr 2023 15:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61FFF6B0075; Mon, 24 Apr 2023 15:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 53FA36B0072 for ; Mon, 24 Apr 2023 15:37:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A1731C6633 for ; Mon, 24 Apr 2023 19:37:25 +0000 (UTC) X-FDA: 80717293650.29.6CE5DA6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 4B1734000F for ; Mon, 24 Apr 2023 19:37:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kDBWBxcR; spf=pass (imf04.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682365043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DknphQW7x+0bWNmQfJrKAi+J0Jdik1T8XR/fg0Woug8=; b=XE/4hVfG7xmFPd7pnajAHs8vJgBxB+2h7JTRKmU3hgW1mse1Bn97gTP512JpBUZEbtcbR1 KCRkM83r4qdL1t0uM1o73Cc6zqmjEQa9LnI7NlZ9XEqYVpDIppTwcHtEjfVtJrU+WHDBxG qxVqS9WcxLhPDQnXhZehGO6RV/nFbcg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682365043; a=rsa-sha256; cv=none; b=mH5TemRPqG38UH5rUaZ5M+ddPMM/57GXse5nGJ4RakwYSXJJ5HPCCMWiLKjeKYl2jk3xLc QkMpeynJwQdUl0bcVtFPv0Nim+j/sCkTc1hgUJ8j9VVnfvTrgPvIMRPZzdS56EreISdSJV ouTDMg4YpSEetirorh3lO2Y1j3+Gmz4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kDBWBxcR; spf=pass (imf04.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E6F961EAB; Mon, 24 Apr 2023 19:37:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 566D4C433B3; Mon, 24 Apr 2023 19:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682365041; bh=YWbSyHY7pUE5AOb/3VWzPWd3sWsQ69Y7x41HE1Dt2f8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kDBWBxcRX36vIRCPQdN4ZUSdbSHX1O4Pd+ZO4nc3vupupBHzNk5Dk91nuDsIQ1rOH TqW+/Qd/EiK0dYyV1/5FLrIBnUSpq7xs31OE+7UwRsA5LpC1j9OwF7djbzyJxgWSHk cTzUpSzsdO3OotdRptYWv3/TZvD6lEfUf01ojwlUPWNODt2ILOz0Uec1W97Nv2KpIK 2MP4gf/Xry+1mHMPMV0NAd9hTZgWH4WczEdoc62VroOonVWQQs1erBn2kICiokJEP7 PLFzocQ/KEmEsnnhZ4aDYS/btGy3oYDzDHqf6NvUrV/g4vv33mYH1BCgXtB4Gbp2FJ D0frIKzhrqALw== Date: Mon, 24 Apr 2023 13:37:18 -0600 From: Keith Busch To: Randy Dunlap Cc: Christoph Hellwig , Jens Axboe , Miklos Szeredi , "Darrick J. Wong" , Andrew Morton , David Howells , Matthew Wilcox , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] fs: remove the special !CONFIG_BLOCK def_blk_fops Message-ID: References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-3-hch@lst.de> <5f30b56e-b46b-1d3f-75fb-7f30ff6ca3e9@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f30b56e-b46b-1d3f-75fb-7f30ff6ca3e9@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 4B1734000F X-Rspamd-Server: rspam09 X-Stat-Signature: ecuj6ks3a4mnbcmxdunzempyxaegmnx1 X-HE-Tag: 1682365043-554039 X-HE-Meta: U2FsdGVkX1+5p/L7l/LlG4Vt04dP75Q3im8+Sy1FFF+uurwdUIF1q9sD2CfgH1sxsbPJp/+RUp20DlErZY9AR/BXrwWNTq17JuXWprkO78ZXQGe7GNIXHuHeEb7Dk+fXE3EjEaz8zMJg/k3J9QnNxo/g8hZM3p3dFoWByjdQyyBqTr2UX+5PM1cd8flBkw4QHZGmhTUHzS+3NGpnLaD1Y85zneKfrteomAZbb3uK7eWR7p33TnBkUA6bafCdxe5pxwcwyjFCkrUXc3KXfk6sq6TzxnJmG05kF6p1PlmX1AoBSiqYFlvYF88drLy0y4uYe1djc5LWwaneUaG/UYW0NtTAD6mRmDV98BmAvn0roxR16HpbeQqfVHB5J8C48Eb80yAKseAOVRp/1w9ZRxx7oS41pFsjko1xQU1ywUGrxcG72KmYsJXlsOnJ7Nvw+FwqTqgdOFyDbfRocqG6kpLBltBKOeW/mMpxXStGJ0/uw13WW4Eyw2PYHwbGHz3Qo+CFW0KSDFFqXlJWDVOX/HB03lIHa707rOHBaCOg7L9xHoyTJm7GWhs97Vs0i5T+AlY0W+L72xKxeS0L1rFrEjEqm+iBIGa4XiYuRJ2z43LI10iAcYv55pyBSiHnt7UtthyUrgcjihNw6b53ZXbnq1tAmkAubDok5BzHGxeQmoi2EW7e7NY4nIRqSr32FGCCIg4XNZEmkgCgBX+HKpg5wKl3zpwqcAFYpwBmRw8bKiUkTJ7xVwE8NbtvRExTkL4NlXxs7OIt8Rk3bt+YtOMXC90EmKGRn/sW+dqO1yGTEE0B0erRWI4CIrOm2OLz1Cz5r74eX7Y0o6yushedGVMo7bjX1hBcy9x7byLsQLKJ4SWykSCXUEdTP2urTb1fjMd2GhfmdDOmyQbtmpB8UGgun71CiM7JlllGxM8WHBKcSd3ZjoLw53ikRrNvvtRAxV0LyS6OQhELHet0mJ9pkVyXeBC AjSpC6Me 1o6lH4Io6cJRt2+qfQcs8/MDoRTr5oq6kp6ZNDbHkRQQhcQG98RotT0KUOP3c+cjho++plxdZIMrKbMlySdNM7ng0pbIfkHHjXr2urDuQH0jKJPynCDeV+9z8U+c3ngjulooKlO+5nX+9kgGhaLmxqdP8Wdp8U+6+2MtVfu61+rkF71fUCocVn8PUzTVd/DxEyDPQ41zynC1jgEg/HEHaiKb+k5fhaj45Y4vAzqZ3tPz+VREwkjo0XCExtI39PPpgcXPl3ueKoEzpDX9aaHpr1GYCjciLVsrZtSwfRlIen5wnm7R2abCDx9pkHkq06ywizKRDXge4Ww4xddXuUqC15Tb+bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 12:22:30PM -0700, Randy Dunlap wrote: > On 4/23/23 22:49, Christoph Hellwig wrote: > > + if (IS_ENABLED(CONFIG_BLOCK)) > > + inode->i_fop = &def_blk_fops; > > It looks like def_blk_fops is being removed (commit message and patch > fragment below), but here (above line) it is being used. > > Am I just confused? The def_blk_fops is removed only for the !CONFIG_BLOCK case. Its usage is under a branch known at compile time, so it's optimized out for that case before trying to resolve the symbol.