From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5098EC77B61 for ; Mon, 24 Apr 2023 21:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAE526B0072; Mon, 24 Apr 2023 17:37:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A37516B0074; Mon, 24 Apr 2023 17:37:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D8B76B0075; Mon, 24 Apr 2023 17:37:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7A4C66B0072 for ; Mon, 24 Apr 2023 17:37:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4406D40363 for ; Mon, 24 Apr 2023 21:37:20 +0000 (UTC) X-FDA: 80717595840.15.578CD90 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 23179180009 for ; Mon, 24 Apr 2023 21:37:16 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BwNGtkc1; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682372237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6akZipOgCyOOOmc4me7AVkravhWsWCWWq0gvxN0yJCk=; b=A58NHqC/xa+/hIJ2qrR2D9wXHUCfmHIwkp68DUixkbybi7GccODBykbGWHcHUfL5VmBkhH Hjk3m/8ETkFLVrBZWm8v5d/1InL4AHbyIJPL7uChIIUkVHSqHz/UBF8Utpwrv+vVRst2ww uMfuVzYrY4G/BDUWD4XL3WTYmCJnRT4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BwNGtkc1; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682372237; a=rsa-sha256; cv=none; b=ab5WGPrxt5rolV28qiIZPrj7wNSZNAmP+UWDXPTzcriNbZ2cHh7uDStG1a3+6GbHmQqCq+ ydLQsSM4cPtElr398/3coqV0R9g0OWv4JfrjEH3w4tn6WxD+ErtPTQtZlbwVxxnAM4tBEi sVeXrHi6oySY0xf7bVHOhT2WG0KFzhk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=6akZipOgCyOOOmc4me7AVkravhWsWCWWq0gvxN0yJCk=; b=BwNGtkc1It9/hiYefg9W7TUb9h VfrI4CpsywE7Cn23PP/H+pPg3bB4/+XqhDSzTzI10kylqbr0zUYrtfKH4fpF7jbXmzWPR8BKa9Qxe XKxCAxEZBB/y+uegoxqkP7ZVmyZEuO4MLF+cXj0OUyaT/6QvMFZsXhVhD0pvTwULWA5BBKEMhyFpE BTpcpzIdLWw5WK77ADuFBGsOP69VgFKamaSs8CInuYF6h37pmVVgHzuNh37CxixhnmfkAH4AYXga6 fk8t7IeW+KYPfCqzANDRiQXYlLExFCV1eAmYFuyx79OSf0axdIfSK8XcySzi8tnI5++ujeiHIjSga xmHQOXWA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pr3rl-000pf0-Kd; Mon, 24 Apr 2023 21:36:57 +0000 Date: Mon, 24 Apr 2023 22:36:57 +0100 From: Matthew Wilcox To: Yang Shi Cc: Luis Chamberlain , hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison() Message-ID: References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 23179180009 X-Stat-Signature: rxy15jrezxjpabiio1y1pbp9z8a49uo7 X-HE-Tag: 1682372236-664612 X-HE-Meta: U2FsdGVkX18J0/Mgrc0rbD6H5wGu+RaEcHwGipjkAuM8c2MLIDu3DLARCBqCWfgBieyFKyngZFOGD4ev8wHGiELncyStavo6MtseCRaJV9P3jugtPnNGZcGR1Hd3bNe0rlPFMJ7pg9ba2XR8M1Ebzwp0h2JUsvc2MDY9DnpBmv0+F6kVsatxLPr+VYyVgE3MPfYlEXo8BI9KQ9ds7al/OHGJNKdRJUK1zfcLF+vjQBCAdvtehYy8YrmLuSGQ61U5wTFPALAwGoCZ7Vdcxqazh3ySR7fhYl4p/DWWXqkgqMqS7oQDq1+E7RSdgd6KEym5E5ElBfCG8JJ54hulHjEcavccCKecG8afbErYUM1yO3Xv7mNEPJBSxjXsTvpnXT4VIjkMZ4jzRlArhyPuwBx8f4eVgIUqLcaqiwU5POh6JFWbEmD/HMk2dJbR8MX1hFlVu0tN8x9HAI+TOojcmCPtGAW3vP6Pm9mrld+pih8kpiY555lQ6bQeW6FMs557Ap2moYKwWIaZv7DAqnt12zSASB6c4INoeFjDoL1fiEVaaCJJqdR1CaOrJ5e/ysGeJs5kY4AvW2qI02LzKcUIEJowX1rtL+sCrAWk2pEVwonigORk+VBfdl7j2bAGII63ddFw1s5FibiosZRxH6jVDC8VZcp9MEFC6A7sEtyYSUuPi1p5k29PUzxuPWPuFZI7b9+95HcVaNrsEbnUJttVZBhweYnrwXLEml+WmhkHLYGMgeqR2hCr7MjMmhwi4prlZiMhEoI3ql30wGG7K6UWsLlwuwzOWFSVum4+8vBbYxR/R+bLdOfk1111ILsKpBCLyk2S3gK1pXEaDJPVp20/k/Ux3Z0jw59QGl0cFEOayAzi/9RD6/YFusR2AfoHLFS8+8ardRhCaJ3NuK+G8ev9plzMJpsAJ06Ugc7jF2j2/GWwdwGR7VIFE7o/WJ0z1gk1igxbFlZB+fbZOXeAzC187aJ 2DL7JU4g oyP68Xya2DNx2SMsLA4fm0LOBLoWJyAXPRY9OxuIy270SxqjJS2pBWijOCmxEhKfeH9dQqbny1nYe+6/M9GvUNWfh5YQwBXWabryD1D1Jd4AT4Fd/JlMYwC9I1J7DPhAwXnDn+w4tJmL56oSuEQF9aHKfcy23yGP/lAMg7zByp8zCoYDv8aOF+yo6teo29Wt8S9VcJ/X71ofEKHGUuhci6zQpMCU70l4ZqHllacAiHHwtKTLle5syW9ljEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 02:17:12PM -0700, Yang Shi wrote: > On Fri, Apr 21, 2023 at 8:05 PM Luis Chamberlain wrote: > > > > On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote: > > > On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote: > > > > The PageHWPoison() call can be converted over to the respective folio call > > > > folio_test_hwpoison(). This introduces no functional changes. > > > > > > Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense. > > > > > > Individual pages are hwpoisoned. You're only testing the head page > > > if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() to > > > test if _any_ page in the folio is poisoned. But blindly converting > > > PageHWPoison to folio_test_hwpoison() is wrong. > > > > Thanks! I don't see folio_has_hwpoisoned() though. > > We do have PageHasHWPoisoned(), which indicates at least one subpage > is hwpoisoned in the huge page. > > You may need to add a folio variant. PAGEFLAG(HasHWPoisoned, has_hwpoisoned, PF_SECOND) TESTSCFLAG(HasHWPoisoned, has_hwpoisoned, PF_SECOND) That generates folio_has_hwpoisoned() along with folio_set_has_hwpoisoned(), folio_clear_has_hwpoisoned(), folio_test_set_has_hwpoisoned() and folio_test_clear_has_hwpoisoned().