From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748EAC7618E for ; Mon, 24 Apr 2023 09:50:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00476B0071; Mon, 24 Apr 2023 05:50:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB0D66B0074; Mon, 24 Apr 2023 05:50:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C77B86B0075; Mon, 24 Apr 2023 05:50:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B99416B0071 for ; Mon, 24 Apr 2023 05:50:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9192EA02E1 for ; Mon, 24 Apr 2023 09:50:48 +0000 (UTC) X-FDA: 80715815376.14.4FA80AF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id AF1DF1C0007 for ; Mon, 24 Apr 2023 09:50:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=DIdAluO2; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682329847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ZUgSr94Jx/J73nPOpbJJQSBYtauxCEgSgnwexVfHok=; b=e0gwfz8f55jt4dBJdjIvITx7zOZn+6cMKW4gJM/tsc7Qw4AE+D9Zb7wKAVmeZNKOxzMGgN y0jGA9ipeCq9Ne0dCZbXMHc0ATbbQZiNt6+J8MAplj9u9XhZ9Xzu/Z01tnMLkh9xsHFq13 NvRA3Z1bfWi3grvoOsi4CL0cAny0teM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=DIdAluO2; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682329847; a=rsa-sha256; cv=none; b=o1mJgoqnCRrH0dlplueObrLJ+k8YbO+Rnk1o4UKmgUWmaXnj5NRqdymhP62xXFYwmcEign /FpMk75yOTEKjJzzdE2LdZGqsA/q2nku/54K9FG5IabXNd23CnMnWjsFWKcpALaQwFCuaE bgN0r4NM8F1Tv0o9YZ9No+Kk6RpRLp0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5558021A9D; Mon, 24 Apr 2023 09:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1682329845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZUgSr94Jx/J73nPOpbJJQSBYtauxCEgSgnwexVfHok=; b=DIdAluO2JRmmSp8fUFz7lKfg4S4uiUzaNgWmv5moUiA/xbIWATn03d5WBelqL46BV4D6ZI 4lnszhrQH0vM37FJEBF4J7OsE1klxfd+mq+Dv+HmFwM/t5JZPOiPChPdF6rh1mh3pB9HmN gGdDQPNjN+6LWKxycPua9LphFVz8tf4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 358F61390E; Mon, 24 Apr 2023 09:50:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lO/ACvVQRmQjGgAAMHmgww (envelope-from ); Mon, 24 Apr 2023 09:50:45 +0000 Date: Mon, 24 Apr 2023 11:50:44 +0200 From: Michal Hocko To: Baolin Wang Cc: akpm@linux-foundation.org, rppt@kernel.org, ying.huang@intel.com, mgorman@techsingularity.net, vbabka@suse.cz, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/page_alloc: drop the unnecessary pfn_valid() for start pfn Message-ID: References: <9fc85cce8908938f4fd75ff50bc981c073779aa5.1682229876.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fc85cce8908938f4fd75ff50bc981c073779aa5.1682229876.git.baolin.wang@linux.alibaba.com> X-Rspamd-Queue-Id: AF1DF1C0007 X-Stat-Signature: m891u55owabuipdduyk1q46umh8y5yof X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682329846-868897 X-HE-Meta: U2FsdGVkX1/ZpHcqCxro9nuC74H76blFN1LMvpj81kBfQX95gagnzQmUDuy3w96+hExEUgOC2aWt7xKd2bfQnJvS9Z9ReiW+sA0MlqMt4+XP6mtNA/60BtYa2NuHvf/ZpYVRTcZ8Y9dLThxCyn4WTgm7lJJTX94M7c8FMEN/JDSXR8fTzvMzQu13KELAyEvN4IeJofdNIeozNn4XQdvKmjh/I+jNq4zxJHzFyzZChdU+dtyhaxkHsI7u6m6PpFiDntJhkkVEwvhCCx/2d2yLZZ2G63xqGAJCcR+1Z/zTOiYBwgZ+3/zyW2/V8xmbs827+94euFcdtTei2JkqhI5nMhMpWAwQ3eZvFqVZOMEQPE82toUfaATwXPFGSyKOvMnr1pJHBCGyJPI11lds8EsKdXZ1+HPYxfr+uHhqvQCrEynjVn205HjJbU1XnIRDjgY9H1uYcJ6haCdLYoo1emioY+fAWmFjpQ0zfDufJaD6+1HT+FyUWS5Wb3DCKZBdk6ZdKE/b6ilFi+Dbcsg/B8NnNyHPrsya5Zd0JMISCFU8x5KKiNTCmW886+jX1+qc7iZjLh0r3A9XqnHKmo4KD+VaWuCLiVmvNgSMGkGckVDNi5TA5tYs8auPNl+n60wvMno8HGl/krJTC5R3Hv2sR/ISjKmKWde96zkcCh9NCG87qutM0/ybb2B2GQOE4nXNpvGmBni5KZ/K/L0ltE1XNxXg1n5XgWII9WIEV14BbAev9EAFSg8PMecFxC1zZtpI64xsQ8mHei1AbdLeMix05qK3LANmdQLMdlyhs89sGaaWoG/cVBX/3D74Il/DVc5wWl/DGidFHYeC9ndaR7V49eKtVKvjCVLDmbzBXNvoTjoXIuOlK05h7AE4oGFFBSZg42Vy/LUTtNs5FyKuSNCzFR7RNusDQpoFUouWrakMOu93BxY9lsJUbwfM7VkOpQYhv/oT3cyIGP0yQsuf+MKhcdd ZLTNU2Fx qlvgNh2FRmq+vvAuLfE3qWJD8JAR2nrBdE2UP4rTB5J9Jsy1oZHFoBiG7U4/BVRWJRBmYxIBvtKpQRxn8kLRKkovHhnGeaStQNDERTSirHPmGD7lHnkNnWd9Grl3JuAflaSiOkcOtW2U+Cct6sjDWvz1Zy0U8FtxBHJlc8eZrMlrKdjFIOe41HAYNYICojXs3KSEKJMow/xjccge1BFS+8Tl/JdlhrYtdgmJK2H/PXOTg2BQ7IQga0YwMnDrvozo41HrMuNrjs39FMxU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 23-04-23 18:59:10, Baolin Wang wrote: > We've already used pfn_to_online_page() for start pfn to make sure Who is we? I do not see any note explicitly requiring that start_pfn has to be valid for __pageblock_pfn_to_page. > it is online and valid, so the pfn_valid() for the start pfn is > unnecessary, drop it. > > Signed-off-by: Baolin Wang > Reviewed-by: David Hildenbrand > Reviewed-by: "Huang, Ying" > --- > Changes from v1: > - Collect reviewed tags. Thanks David and Ying. > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9de2a18519a1..6457b64fe562 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1512,7 +1512,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn, > /* end_pfn is one past the range we are checking */ > end_pfn--; > > - if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn)) > + if (!pfn_valid(end_pfn)) > return NULL; > > start_page = pfn_to_online_page(start_pfn); > -- > 2.27.0 -- Michal Hocko SUSE Labs