From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107ABC77B61 for ; Mon, 24 Apr 2023 12:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70D186B0071; Mon, 24 Apr 2023 08:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BD686B0074; Mon, 24 Apr 2023 08:31:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2E96B0075; Mon, 24 Apr 2023 08:31:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4EE136B0071 for ; Mon, 24 Apr 2023 08:31:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E7E61C617B for ; Mon, 24 Apr 2023 12:31:14 +0000 (UTC) X-FDA: 80716219668.27.BAE49A6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 05ECC16000B for ; Mon, 24 Apr 2023 12:31:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sjx8klUb; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682339472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7hQoBJfzkfgPB29S154KGrGt0ixs3oVFi/jSX9Pzms=; b=DZEWn9O3uH39Kji/KGRUn+Q9cqq0S3H1zNz68HSWgXeFzfNcEH/3pmRMmNuB2YEX3s8ybC FbosQwRRzuHJKHcR58LXo7iBdyOHV2uBp2f3r+L0fWi8N+fHu9QM7/jJhn3rkchEvcs1Fa +eBernC9O4HxcwOywDMdJ5pmtCYxRSY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sjx8klUb; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682339472; a=rsa-sha256; cv=none; b=FCjCHcQ0jSF7I7NuHksJ5Vr493oX/Tju5C85wfP0x1veb5ojaNUOEu8/eyvCt/PEF2GBbt OonwdJUaYR6CskD77ruZWhcOYlayiAYfVUR7mCjPHm558AlPwUNuOt1fgdKAcOJFE4+Gnm sAfSBl09zf6S6TR7ykOzwhhdA4MAay8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l7hQoBJfzkfgPB29S154KGrGt0ixs3oVFi/jSX9Pzms=; b=sjx8klUbwyW5poG4vtt9GHne3M IuyC7Pa8loDQwweiLoc92ELtPUZyx8Y42tUlRWkmi+KS7dfAwluiV36VnGBR2M/SrIGpjbF22vMJA fCM1/e9rmvocI23ApG30mhO1wQBkljHUh+CKbIyl5bQDqXNwpBmyu8qZgNeWIQrzDN6H755jlAs0Y Toyra5f2h2BCeN8TevH1pz8ysOh3rTJ7JqmgtPqbuOBunT5NfKQYVe6DXf3nr/uzVcn3ul4X5UhcH HhvUG30dtGsHbTs4kvAre8IQDSsrz8oZGgbcBdRNHAlnoc53J7ERcVSRH1P61KtUHQOB4hTGaITiV nwQQzrzQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pqvLM-000RHP-Lv; Mon, 24 Apr 2023 12:30:56 +0000 Date: Mon, 24 Apr 2023 13:30:56 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Jens Axboe , Miklos Szeredi , "Darrick J. Wong" , Andrew Morton , David Howells , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] fs: rename and move block_page_mkwrite_return Message-ID: References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230424054926.26927-4-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hpzn8frs5rrtyi4ytdbicy7axz7ng4zb X-Rspamd-Queue-Id: 05ECC16000B X-HE-Tag: 1682339471-157606 X-HE-Meta: U2FsdGVkX18LxByhrib69++qK3YPNoM85avbt4b5TrpmHcTuGfmug0NFRR6GYsnIZa3uedodwgb/dqBsc7PK8r/u4JF9+qpjcJ5oDCtIrkLRF5CtCeW3+/JT79CzyzTbXqp/TZjBkQ9+XS2c9Dwiwcmk4igHLYbkbqflg+wx1hbHnaCqwRg4rNSJxccVdKz9DglK74dFrcjv6y912uZ9yJlstt2rLkjRrqzFBzOqizhgM5KqeKbHeLzQW25OYyhZJGE5hv0hVAGK2ePUhANGpkV9Osd73nw7hgkk/rHvjKk3STJzsEwrmYjjkubxwnpDvqp0VIrorpOHD2IqFjRb+DKLYg2qSkHL9gkKwllzJus3UIWyuRBT6MGpxn6n0Rn1FImlEEtPxeDHOMx6VMpdZToRk8U6+EO4/QB8ESDXJeamCdvWsTaWTfDKGFt/sau8t5Rug+zvks0ap+ZrvnRrYEO9WaaVnuFhi4uZ2NKxyNiYGAGNCSuXh/Y1WnujUA1x3PIQh83a8HduutgzK+BGofXZb9jVtTM/SRDLPyD3gqHHIBBymmzMrCvOFqIt4S/UfanJd3y5T3mfnwoXhirGjmaYWJzeeb40/940wHug5LftSRY3N0vcgck3uRKbb24eFQKI+ejsjFOm6gOFVx7wRRqD5WWfXVaKX5UHvdptZoAFbwQc4JRaIIZ3IEU+ooasboit2YX8/Dr+T6jHhXHJ24zHmugZ72+smMywsyFzbuxGN0nE8l54HyTRITu22vOFracmZGA/SDEDRGZA69EK+9WtrIq5tIwts8JRJDQeqYNoaE17CZ6KRS/KuFFJs2UDL3pwfvgxi75KX7l+pT2u+XxBLxvLuDQjdlFjW7KkdTZ5nxwZeyKwoMnXkah2VBX3jZTZc/BID9qvLkcYPGtDqJdx5B34bZiwvJO+bajZE3STI2sD/epZMas4lWewJzA56WtQpL9bh/ItHalO2HO oHnYToXE Yc4C4z2flbD1hG0FqmrcnIA5YAiI1l6j5AoJLr5aw2KAO6IXuELVHOPgR47Hk3mRtwIfLv/ggO4JFhGeKT5kqu4jExwxoFpp/eLE7FEB7dyGB8MteYj507ySplwOqp0pRBddSAjkRMQ+TVqyV3INLmEiSWzbxjcnmuUyaBsSxQi8GnSkDQB/WQZMFUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 07:49:12AM +0200, Christoph Hellwig wrote: > block_page_mkwrite_return is neither block nor mkwrite specific, and > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > errno_to_vmfault. Could you move it about 300 lines down and put it near vmf_error() so we think about how to unify the two at some point? Perhaps it should better be called vmf_fs_error() for now since the errnos it handles are the kind generated by filesystems. > +++ b/include/linux/mm.h > @@ -3061,6 +3061,19 @@ extern vm_fault_t filemap_map_pages(struct vm_fault *vmf, > pgoff_t start_pgoff, pgoff_t end_pgoff); > extern vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf); > > +/* Convert errno to return value from ->page_mkwrite() call */ > +static inline vm_fault_t errno_to_vmfault(int err) > +{ > + if (err == 0) > + return VM_FAULT_LOCKED; > + if (err == -EFAULT || err == -EAGAIN) > + return VM_FAULT_NOPAGE; > + if (err == -ENOMEM) > + return VM_FAULT_OOM; > + /* -ENOSPC, -EDQUOT, -EIO ... */ > + return VM_FAULT_SIGBUS; > +} > + > extern unsigned long stack_guard_gap;