From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A7BC77B61 for ; Mon, 24 Apr 2023 05:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EC8B6B0078; Mon, 24 Apr 2023 01:55:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9760F6B007B; Mon, 24 Apr 2023 01:55:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF526B007E; Mon, 24 Apr 2023 01:55:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A91E6B0078 for ; Mon, 24 Apr 2023 01:55:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 317DAC0183 for ; Mon, 24 Apr 2023 05:55:57 +0000 (UTC) X-FDA: 80715223554.03.8659D33 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 6BC7F4001C for ; Mon, 24 Apr 2023 05:55:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qBKmlBP0; spf=none (imf01.hostedemail.com: domain of BATV+e16e2fc4419b117693a1+7183+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e16e2fc4419b117693a1+7183+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682315755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=edf2YE6tOjy5o639pmoNCDDnqNTZQ8NPmup4HBvbC60=; b=1M9kKcVHQG/DGE7wTPS+zwCfhgUqkHGNsMV23kYlv1Eu2NbDiLqGK+uztzF9KV5lS8JRC1 8UH9q7dNkbCbLLiMhoM+Y5lIyBUP0ZYNWGJ8ZQH8NFss9VajwivPOM+7xE83ExOPvF6U0R AMIME01Ml1cFVkGjm443wuN349L0+3U= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qBKmlBP0; spf=none (imf01.hostedemail.com: domain of BATV+e16e2fc4419b117693a1+7183+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e16e2fc4419b117693a1+7183+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682315755; a=rsa-sha256; cv=none; b=xmiYt5c2+p6RfLAEgyG+wYAIQjzqX3vTft0WnxIfYPgkBlG77ZqtjUmtWNyojajX+ogouX BfDwybzz5Xf1EQJ21Xw0k8WUpZjr4Z8+FVouu3u3KbHSMnnBPtA7HtEe6KfLDnSYKcEVUM YtVmeybss+VXZPNsEL/Cg0aCSFyr6Tk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=edf2YE6tOjy5o639pmoNCDDnqNTZQ8NPmup4HBvbC60=; b=qBKmlBP0RbumDgdRWERGFEVbSD kDf8Kr5lk5aB2+nWak9xt17TfHD2PupAuPb1mUJmwaPm/dURvhYPVWSPaaOFCU9vr679O7rjTbCXX FY14jwJ6foFME5jmhn6hiaV5cvLy3w+4wiA9HOCqY9FKPUwzVOJnoZoumJfKXe+j3dCSf+I4DhyyN meS9IcfszZYuw8bakpryb8WeNnXvLqGFAShnlXlum+ZdAx1uWAgWfJ88JFAJBehhF7KCT0OC/pGsx saWH2fGCCZFbpsAwVDoLKGMeyxz9Qo8euhIsqOiC8WZE42QMSALorud5SvHI394LQ9T2HdWzjtMUM uj/muRvg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pqpAv-00FPys-1e; Mon, 24 Apr 2023 05:55:45 +0000 Date: Sun, 23 Apr 2023 22:55:45 -0700 From: Christoph Hellwig To: Dave Chinner Cc: Luis Chamberlain , Matthew Wilcox , axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> <20230421223420.GH3223426@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421223420.GH3223426@dread.disaster.area> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6BC7F4001C X-Rspam-User: X-Stat-Signature: surudqf64eeazrjgnneuqd5y4fkzhjw7 X-HE-Tag: 1682315755-935125 X-HE-Meta: U2FsdGVkX1+Y5HtqXrfwWZ98GuX0ocOg/jfj2eN8rxZxLW7N33KtYIk5gBNXVum2DyZ6e4X3sndYZkdYxRt4EuTbx0SOgK8+jJJI7rEo9m6hL0QV8GlSj553j8YCpK7Tqr5W2sP/FsTaVuGwiBlFZ7YrSWTpzjC+Cv9DmvyEuBg2z4R+kqp7WyfG+tJIvNJlpr5N3b34sgDJz2mFovzgoYqoqnDcmSuudJG4SENTvrOjAq1qQmAwRwKYXS8EYyj6uUHyAbIN3VydT2IHd3huMcEvIR8sLpakqID0UUpNB7jxPnvnvHReCyPvTZvPWCkbc8Peunl5FIvMfktNfMxvSVRYuCqIaBTlAU0UkxwoX34ryL4S8unnDzF3J76JkkPMJg/fA1v90c4Qd6nK02Hm7QzE3FT16EnNqAne/q2+FHoE4S2gw8YwQ0mAbKa3kfkb6TMH72slcObmhpzxkWQkpD2HyGdVBnVW7Ylg/zSWT0uOx3y2p9F0yVs1MoAaw29QMIs1JUTQh79LvmJEgTs01ceBD0Pmu7biHKl9UkxZuzQ/OZjHKaAgA8p9UdeMgS5fE5+U8oyTtI2DRKilvHIkqAZThTUZh5pWLnj2upm5OL3Q05dr2mpbM99zxrTCdkjNypG4K3o1pqkBDf2Y8zxOIcukaKWk/tmKdrIRknFSZ93MlWa8VL6VcoiOOc5IY1v487fuacPDSHi1Z5937P+57h847ncJg18K0WBitrv4ljPs/rFb79CM2WEJ6iaRa55QbjT/1wpUxuLxt5gQ9BhIenUletYqYGE3PYZmnMbSMmiehGcA6vUgNdXytY6gbc7GyaNbqfJkwb9iWeOb4cRY52JdW3v7h1Alixe4HOSLJ8Zca2ZRxDMejhOlkeK3naMUxDoRyRS2Q3jaZCrg+ajdeTSxYfb3m69tOlD5Nz1S5PbVax9arsKMGWi0rVSpLynrw5V7WcPeAOhFlEzi3Zm 6il9zh9Z UZFLUOXRTPyELYp1TjjYRfxswro3Kzd9IYDBt2F5I9Xt8bnRjrOWuA6xjl3CQMpHRQMGHJbwNhJySioO45q/WxAc7ATiNj+J1mq1yVLYEHjmpwHUm1FrH80aMXlyzY0TfN47OUcr0CtiWRP+0ZxXoEbxKyW4IQclsCjjcLZYhLVTidu0XGK1H4IysXsu8iV+XSSKuJeH62QdOoQHU3W18oJbm4oCkhHya9yvQLzLVpm3IgBtBoCjmmcfWUBjGute+SALi/n7pWF9/smRDHHy+BeAQHLE/0OCPQaYjheG9AMDnCc6ql5GmiyWlNiL3PzFOuW7oDRtzpdOq4+YFtsHejsKhnmNS5LmEAO41xsM2sYuKfpFriTak3cchJ96Tb4RGGaICoSAkY19O0r+AZIN3ghTRr1B1ruFklaLbYD2W3CAbsJv9D42qYwKVDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 22, 2023 at 08:34:20AM +1000, Dave Chinner wrote: > > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS, > > Yes, please. > > > The shift just seemed optimal if we're just going to change it. > > Nope, it's just premature optimisation at the expense of > maintainability. The compiler will optimise the multiplication into > shifts if that is the fastest way to do it for the given > architecture the code is being compiled to. We still had cases of the compiler not doing obvious multiplication/division to shift conversion lately. That being said: 1) this is an initialization path, no one actually cares 2) we're dealing with constants here, and compilers are really good at constant folding so yes, this should be using the much more readable version.