From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78FCC77B7C for ; Sat, 22 Apr 2023 03:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3189B6B0071; Fri, 21 Apr 2023 23:05:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C83C6B0072; Fri, 21 Apr 2023 23:05:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B69E6B0074; Fri, 21 Apr 2023 23:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 104DD6B0071 for ; Fri, 21 Apr 2023 23:05:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF6AA16069E for ; Sat, 22 Apr 2023 03:05:22 +0000 (UTC) X-FDA: 80707536084.28.BEA6BB3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id B3ACD20008 for ; Sat, 22 Apr 2023 03:05:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t5z7h+1l; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682132721; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d/drIpsV3nVkI3AWmke+ca/OYDz5JWaoOhQ63wKz7tg=; b=Lmj0nq3VaDKg/2Xvq7hhO8P/QWdOTwVBQqHf+BVz/Uf/L6FpcUdPUEno8QfcRmGtwPAxMg JX1BWQEZnJqPwpgLiYuMp0fkeDdwiSk+i6m4udhRwXiTYH/0umPsGK1+nfuefRj8Kj/5pp zeaHLB5MTDRjesqIGt2c/GcwCLgiums= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t5z7h+1l; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682132721; a=rsa-sha256; cv=none; b=qWVeKPCB4qhgFlbrfvGpXBeQvndmHWaZ70lfAQJuk4ywnRX7cZ2o3Ewpaq9yHBr3toPrV1 M7DN6UHE6yQTeewF7krOtRlCdn66GGyLbKRo5ifHB27Gy6CPmhhRmQXXE3R9ROkgVGFkHJ 7d7dqO0L2gqno9nAF7P/owV62ZqLpoo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d/drIpsV3nVkI3AWmke+ca/OYDz5JWaoOhQ63wKz7tg=; b=t5z7h+1lNmQrXDkWpzx1/m5Gej XWRSmJq80eCVKtUu4NvPpX0IljSWYYX70YWBIMfZUHqOHWmbJHZyiMNO4Jto8y2JcR/+ANy2OURaN xRrA5kySnWRi8l0RD2t5bcv2w9p5OaP9mH5/5Ft4XedWVuOghAF4GAl15lRBazm5bSya8jIMz0VnF xXRfnfa9LYquFCqzBffOdnpRk58AlUQSlC24kSiMi5pnzvjuVzHTuHiJNLj4gYhmEoxo9X0uy6X6R ggjHKxy1Ctsgv/bs0xuZW8ENhxyLvHPdMSVVlAibXhiM0OZCo1wSlec4K+rzwM/Ve8yqQFI5s2tNN qYijGnzg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pq3Yg-00CHMA-1V; Sat, 22 Apr 2023 03:05:06 +0000 Date: Fri, 21 Apr 2023 20:05:06 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison() Message-ID: References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B3ACD20008 X-Stat-Signature: y47a4537dyckdouu8n6ngg5cxckiuo1n X-HE-Tag: 1682132720-150858 X-HE-Meta: U2FsdGVkX1/jEOMGF6ZQ5Wu2BYCb11yA7UTr/hTk+CoTA+3GK5jmMxrZ7A6a9+1mKrEN0L9cPxVgepU8MmnkYhSxchigIf3KpzUYRhpfTpCBvm1UsD5Ew2raWq7tv6R2bP8kpNYx+mjJgv4Z2NzAiw3Uhqv7kUVMfq2ffrDCiMwx+uYlLhJnOigKtW7EGoUdshxJOSK3JDgeQzkntyg/eS9MYXnXsHzUcAC5OKItDw64YAeIgN0hz178WXB/QuwLzGKbKHutoQZSqFCexoWqFSMEs1FspTb0jYTZ18J1vgEJ3SbVx3Q0UKcLS72l90v4DA3v9xBSU9udn3XvmtykCd/PDwDX8XntG25MdUVw/2o+wJGY3da/Ul40+urZb3wY01JaqgxdujCd7JnAOJcC9vF6VtPyb+/5BF6/Tdv2/ao0sCILiss7183dyUQXgOqQovckmatHo1+Y66oUp5VCxxXAC8Fn0E30twVcJEb2r2Yd0At/raIeYSpV2UEa4TjtqtbA5LLka9/un/DWdPM+BBQfKUev7eKtbShaOe5E/r6eF4lvXGw9OB9ECgXRjsZ+qHMzEddi1Fi9mOilxKbeg5tVBb/sGCUVmuXx+mI/3kUdBSvevJJ5vww6vbR7O+Q2JeREJnhxuHAXK9eX6IOpMlHpN82mtI6eOBHT1CIiY9DfCsOg3LBiIeTW8ocPpvadj12SYFXlgv2b4FAMPMAZlQjanaIdj3BV7GkxdTAaBSto6YVmz02z6PjIwbDDoW99oxOFeG+VnrcEfV/OGEbczW/4ZnGlHDwXtyHRa71g+hPeLSNYXETAlCLbkWd9ooK7Da5a7jBhA9pc0gkjc1C3OyrW/NfqoOPd/Vdx3XHHrhKa/q93btiKlNPgdIfHtv8ZBtQlaL3v8WnhSiDiV8fEo+fyVBOp5fZHb7JvYQ3XzE5fuJR09cZpkEJqqtAvDs00AOra19P1EcquRUua7xi AcMPBpsT j0t58CZ+ab6E+60/P8k6RoNK4+yjRUxWAOWmdTp8rTEEHHRKzQc530H+PN0cHaDfKVv4DXq7S1d1hk9HZdH/33L619MPwsCq6AgjTDz7oBd44cnhmQ+SYB4A9KHHlengyT2vJV1rdn5Fk4LGP64vyB++ise/LNyDqdJPGrdHAY4JbkFtN3+XXD2kQCzs9V4By29vl1B3CuvrCWBMtxJ14nvzbSZmrnO1qs4pr1X+jxejC0TwbAUNr50IGiCCGExRqWOmO+o7jkVN8HFA7Mu3CjhCFjbjfs0SPFs6x4wweTNDEaqAVYms0d8kzF5udk6qKag2D3IXNtYdaQ833jWETvEFKGy1PpT7QWurduwl8p2gkG54= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001459, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote: > On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote: > > The PageHWPoison() call can be converted over to the respective folio call > > folio_test_hwpoison(). This introduces no functional changes. > > Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense. > > Individual pages are hwpoisoned. You're only testing the head page > if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() to > test if _any_ page in the folio is poisoned. But blindly converting > PageHWPoison to folio_test_hwpoison() is wrong. Thanks! I don't see folio_has_hwpoisoned() though. Luis