From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8503C7618E for ; Fri, 21 Apr 2023 22:50:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4892F6B0071; Fri, 21 Apr 2023 18:50:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 412776B0072; Fri, 21 Apr 2023 18:50:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B4416B0074; Fri, 21 Apr 2023 18:50:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 163C56B0071 for ; Fri, 21 Apr 2023 18:50:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E2BBB1A0604 for ; Fri, 21 Apr 2023 22:49:59 +0000 (UTC) X-FDA: 80706892518.12.D038B59 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 4D2FC18000C for ; Fri, 21 Apr 2023 22:49:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EDk6d+sA; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682117398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rk/OYWhW/XAI/I4YNvgkI3t2ZA+2S6o9dTT4l5mLGUU=; b=UtnzWMtMzDFoR/Tq92JHM78UiTjoFAWSH9f6x8O8DFpUZPps1x0/cfe01Od7vtvNgqwVJj vaBwPoQrTqElOGyIyASdccmssXnhkcdgyYrzeoa+OgljxEFkX/XoQZLeoyUo74tfZ7bRVE j2VIgn28fkbfyR4vfg2CsRN/vezMMRU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EDk6d+sA; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682117398; a=rsa-sha256; cv=none; b=HCXTb0TWkQZ/QfyyGRAf1vkmwZ5R1+38ksXZXK0cfVsMNR4boXlBztkzV+j/E72/CJh5SN RSrsOuETIkTG62QiqHHqxAvrI6AEkPlahW+H+D9gF1u8+ERJ4SPXhiTbR1y15gX//DlZfS qJ0ACUTA8Ccc7MuUp0t9e6OuRSCyIYY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rk/OYWhW/XAI/I4YNvgkI3t2ZA+2S6o9dTT4l5mLGUU=; b=EDk6d+sAzT9ozbYKqvEeLRubE3 G/qot7oj55X3AiaR2lLLm8yBh8BW3+E56dNXdljzVphWA+lV6sKfQ/0It6JkKoIFogYP5TAtrtu6q i/jd4HkFuKTz2kKi+bKR2g2GByNuISpDskvAbg4Wu/XE4Xgah+lEdR6pdxWq/7QHS0S2peABzdybd qBl9BTxmUjHUI81U7fNU2PXG7Lx4Ef2yGHI7lJZuKxQ/uAYWGjxRoBo/GVDRjTt5mwSwWov9aQBKO RBhTRZHrRSxSccSeyYa41TlJt/1dnR9ZVebBspme9XrLyJMAmQxfE5qxmCe2/UjkutydDYtGSOzYH WS6elVnQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppzZX-00FiQg-N7; Fri, 21 Apr 2023 22:49:43 +0000 Date: Fri, 21 Apr 2023 23:49:43 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 4/8] shmem: add helpers to get block size Message-ID: References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421214400.2836131-5-mcgrof@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D2FC18000C X-Rspam-User: X-Stat-Signature: kzwkodiq3ydim3sbkdh466d9j3x9mo66 X-HE-Tag: 1682117398-196815 X-HE-Meta: U2FsdGVkX1+4X4bNPz75hMKljNrgeLnN05JVbg2BVzmXAOBxAewpvLT2nYdG0IhDT90wqCXJ5Fx1hf95qRrPupHMZJxOGJTLsb5oSu9VF7qWtg4PZodIJWJnuWAfDKWKDvur/RIEhBgNzgydnsSC9RUVCqnZ+792LpURkYzOxo5n4+RQrQblG8gCk0j5W911jDLIQOpchOb1dpnKkRlfr3wcb30iUJlW3pf0GOsH/F/0U0/yAKGP027jIm9sLApov7fIJL0ymt3kLK6hUoqhlnax3JMyFkrkyA/ahY+3PyHV4dXjzpdfQW5fn1e31KQHCSCebcVFHJz7b+kBRLfqciIqoWndIKM6Nvy4IkfL0vRBd0JBXoaOoG806veoXJgJp36vGvwXVtIy0S46CjJbSrkLCb8rCrYzUXnf8blwTzNxcXhbRABbAjCHs7CQjGHLLpjdkKpcxXhKOkjqTiXfPw3mPlKKQKTPoa3hBXSdH6zBbyDoHg9OCNoB23wrAGWWa0By/C28dLqhBNUcw3T10A2RGRLy8jWHFUHyxnw4+G9HXz3axXd64o4/T54XRkqEMGrIPnsSzc6HZ1YcNWmG0AQq9eHyOumMr5JKKTU2mHZmanBBbOFsckRCC3PMUzsGJE04OmD1pdXeHQsDu8QIEoOg+UiBw3HapTWtJgyftEfh+2S9Av+T5Adhu+rHUCnqLylAe2wMuWGOIg7YKVG3GsClc4z1tz1BB7ykMFyWGtOxfRW8cTo6nM9p4kmcPinJob3lq6e0Lz2k8VVuKD5ckroN4yW8O4fGHAIRmjLHwpRs7bg90gNWrsRbuE9Xm2RPDeGdkwejgduVmU/xB8PiJ3uDGlPZw1gtYSncX7DrJuObNHHHppQZp9clYlI7e1Lvg6A9aeiqugCCAIqulbib/afSE1wUMk2NgvZPo3A1LcaryYqyZqgBdW5jV20GvuKxBmswzzn+1maCav/UX6q uKKrpbLg qXc1XuKSLPGu6w3zFEQwqSmxli4iTjNW8HoZVjkB0A6sAGvrm/RpllL6+ft8oewbVs4jGt30AdmbBkzS10WjKuMMs+5PwZRo/fwnYl/eEsbcyjc11QBbozDgRaO/NTd4P4NUCZvUVX9OoSVU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 02:43:56PM -0700, Luis Chamberlain wrote: > struct shmem_sb_info { > +#ifdef CONFIG_TMPFS > + u64 blocksize; > +#endif u64? You're planning on supporting a blocksize larger than 2GB? I would store block_order (in an unsigned char) and then you can avoid the call to ffs(), at the expense of doing 1UL << sbi->block_order;