From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD66BC77B7E for ; Fri, 21 Apr 2023 22:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43B996B0071; Fri, 21 Apr 2023 18:47:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EC486B0072; Fri, 21 Apr 2023 18:47:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301B26B0074; Fri, 21 Apr 2023 18:47:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2245B6B0071 for ; Fri, 21 Apr 2023 18:47:13 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D090C160549 for ; Fri, 21 Apr 2023 22:47:12 +0000 (UTC) X-FDA: 80706885504.25.A0D8941 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 250A480012 for ; Fri, 21 Apr 2023 22:47:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rgNlBrbB; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682117231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VcM5hqe8ohQj2y6ERa1ukw3ufFJS21Hh1hq4I+TYzSo=; b=Wd6waGri8RUpVglky0eTsSRcnqugGcm3D1PVR+ODopu7eG8clv4JpdB9dPtLJMzah7OKE6 7uSdqbY9SUJKb0JJZjzyYu5c7KFYFkxPEWxN/Rrwwp8lC7QQh9vpqocFCkg3JHQpOEFQ8s uYeiXeNOlye2QFuw4DH/+FXAgYkIVUg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rgNlBrbB; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682117231; a=rsa-sha256; cv=none; b=cKsWmjwjw6LFIqF+BR/egxc2zy9+OJfBaellKhAjooHkcLZyu5SyxM2sO4WHiEPmj6IgIj zD+uiSunPIxB2Z2eoYKiYutqadZ0Wp1bMiMUoK62WnncqCSpD1nWyD7jhoW08wHoClO40p IppziIwH3fSE7pVaf3jSiUAhJWL8chQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VcM5hqe8ohQj2y6ERa1ukw3ufFJS21Hh1hq4I+TYzSo=; b=rgNlBrbBZQE/jPeLix+D0ilI0Q 71kmRlZ2+T7aKhtBX4TmXZ0BiGQZ6bWSHN2OzBeUMgbJLMrI7CQn70w0LvkZZGKGUJujkqTXWkWCn Uh6eKQlha9lwPIMZE0f1gWoEFMdo8DN/1Pxf71MEA3Z2VCdB/1uMtYEpQ0H1m50J90mZqXPHNOXGx bSzD0JUSBjwZItHuHF9/l21almvKizFj2XpMdsw1wY4wRNpKrGeRSwNNW62/pJmU8cPHf8nq6R41+ wt8Sfq2bTDEup+WZg0StBdVV64q8kbX2jTs0APsYWtyNZY/6fadEMw2ddReaCFvGP6+6ykleJrobe Sok4SDkw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppzWs-00FiFo-Cm; Fri, 21 Apr 2023 22:46:58 +0000 Date: Fri, 21 Apr 2023 23:46:58 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 3/8] shmem: account for high order folios Message-ID: References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421214400.2836131-4-mcgrof@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 250A480012 X-Stat-Signature: 79skswmau3ey73kna5mdbgkuchmdy74s X-Rspam-User: X-HE-Tag: 1682117230-103780 X-HE-Meta: U2FsdGVkX19Otq0dQMnenYNnXMepYHCIhgNpdadF8ewRrGYShMGjtR4hUe/crD9zr6NYm4lBTknDezx7C6x7TU8/0Rw6zQPJFaA6QHEchegWgsGSbc0v2K07X0csNJbjpcssTGrXGjRuScpJnkk6D+CCm16cHMbs9e4l/KX9+bWyLaG38Hk1a/LEqzYA2PjXCkAChwD2FpOamvfl1ydzmdtoKZJjGjvrbr9gpu15ZvEWHw66E3PEOZrSaDkd7OQ2uN7TDMHgMg/WzE0eK46YzV2I5KuB7x9kM1jR9aFERWq9fxnUq43Gs8dt98o7k+8H91ycr9HsueaaaG+hMfdQ522JFITQsB4xvjj75LDJM7QeDlPaz5JimTvvNskPXNJnakzmO8Y1SNauz+yuM7X9Ime1unCE9bXR95UsBHw/yvgyBsI/j5lZwEHR+LvdEQeMKJcdVBnlgbj+GV3B7jHhBNXu6hA+iq5wRtVdaJTs7faPtVJP+YQpoHsiDCutN1SUWl1qvQG77UTNaEhqsurQ70j8ofNt87yi1HY1pWouvBeba6dwwEzUm/5XTv+3s9DooqlZToizrpZoIRehosLwzKlYrBsSvuK13wRK+bc0NfuFzINSjAu0EAdmzdMpwygXKTBq4t/brxT3nZzNeQhjTv5pq0OaeN5hw8k/GxGXoY7jJouwh073TYV2cB0RnYQA2O4sHKtN60WpQSHfwLk+1saoAyDxvgwdcbL0dkgTAvtZgWaY8pIYReiwXboLWLMnaBmFis7G2KN+0sksaTkbcrmYyE0NTjjr/e+VGmuGKBN9tYBqKT1Zv6/jsIoALbEnEyJxJvLbQfsvE0mbotN0Xpgqud1HekXE4FGyeEwtN/+qC4Xzi3GaNpvl8ycD0qyjyiARr59gT1I7ke0ARSfrFqb5rkpuDb464FMyrpI5S2OFKjcUvFZ3QgdtE2IaqqkW4P6cUlG7D8UyFuY0t0I ejtenN29 uHY7aZkzt10K9T0yGIMXXVEJLzpfzZh3rnA8Ccdr6vrWZBkmSaP6Zsr+yDeSI/zfb8Y3lSexxIM0RC2P4btFmiV2ko/UreZN0s7L6UjxVNLIzP1N0FSAPzJ0oYsfQMAEHVgE08FMpMVyVqYY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000104, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 02:43:55PM -0700, Luis Chamberlain wrote: > - if (xa_is_value(page)) > - swapped++; > + if (xa_is_value(folio)) > + swapped+=(folio_nr_pages(folio)); swapped += folio_nr_pages(folio); > if (xa_is_value(folio)) { > + long swaps_freed = 0; > if (unfalloc) > continue; > - nr_swaps_freed += !shmem_free_swap(mapping, > - indices[i], folio); > + swaps_freed = folio_nr_pages(folio); Why initialise it to 0 when you're about to set it to folio_nr_pages()? > + if (!shmem_free_swap(mapping, indices[i], folio)) { > + if (swaps_freed > 1) > + pr_warn("swaps freed > 1 -- %lu\n", swaps_freed); Debug code that escaped into this patch? > - info->swapped++; > + info->swapped+=folio_nr_pages(folio); Same comment as earlier. > - info->alloced--; > - info->swapped--; > + info->alloced-=num_swap_pages; > + info->swapped-=num_swap_pages; Spacing > - info->swapped--; > + info->swapped-= folio_nr_pages(folio); Spacing.