From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17613C77B7F for ; Fri, 21 Apr 2023 22:43:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91F886B007E; Fri, 21 Apr 2023 18:43:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CF7C6B0081; Fri, 21 Apr 2023 18:43:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BEE56B0082; Fri, 21 Apr 2023 18:43:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C4616B007E for ; Fri, 21 Apr 2023 18:43:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3D2941A0540 for ; Fri, 21 Apr 2023 22:43:12 +0000 (UTC) X-FDA: 80706875424.17.A7C94E0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id EE04EA000B for ; Fri, 21 Apr 2023 22:43:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Smrt+UFG; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682116990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m1e8oWBFoE6cQzJQhP6tkmJTF5BRaTgWrs55dNNPGgw=; b=mB8Ftk9YUy2uf3fUUL55XyfpyQSaq742gndnRPsV2u66q4/LblhbSiE7jFVltwyfbxpB46 M0yk0t/jqi+a6MxemOkwm51mIg5ll1QBZZ5pUDZSxeIlobJb0oUBR9RVYWpKM45nDH5LBN 3deobCgO4CSa7P38Zcu2FHdjnk8MabM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Smrt+UFG; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682116990; a=rsa-sha256; cv=none; b=XZcWogM5sQXstrm83+AwdDjyCX4JkJbEd9t2oeNE6JWXXcBwu5Ens2f79xB9uqsEBPW9tA fARgIBHnJRmcs46AaMY98kID7MxGDrGpb0Pwim1uGCNbqTsEPoPdeyKCJ2tAG7YE0qKiWO JRXzhL+YDMQYGbBj0M2P0nX2Snn9yf8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m1e8oWBFoE6cQzJQhP6tkmJTF5BRaTgWrs55dNNPGgw=; b=Smrt+UFGINhHo2Xrc2HQAomUpt KdADUqVFMhwxbRWcmREvw1bQBiMRmv7u1VHSLfO2r5em1Zj/XxTAmw7/HcUR9ttQaF8d2Diefdw5D uoOtzyqYMfwT0U2ruXS6u6GrihqG+LVtt0vIr5CDhAK044jw6tnpZR3cyj05xH1uyLXFnDn6VrPEw gDyQonGbIXXkHeEJRLBmWe+u9G6HvUBs46RoibpsVWVWM0htT4eotGxHKOtZ4TZBsk9CJ3yt5Prei aviVAba62+KGLTyAuC4pZQGaPad4uPr+wnbwU9BXDzPk/txPucorIgTpV2x7DbBnOHFLXUIBD/soV vZjX6KMQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppzSv-00Fi3h-IU; Fri, 21 Apr 2023 22:42:53 +0000 Date: Fri, 21 Apr 2023 23:42:53 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison() Message-ID: References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421214400.2836131-3-mcgrof@kernel.org> X-Stat-Signature: zrf7r59x7jd8u3u5qao8ekxc5i1odx8e X-Rspam-User: X-Rspamd-Queue-Id: EE04EA000B X-Rspamd-Server: rspam06 X-HE-Tag: 1682116989-501278 X-HE-Meta: U2FsdGVkX19rMFVlC3fgODlfKxgqRO0r0+ZqqybI4EPEfPAy8J5+jMFJe3UapHzJv0UaaxToxXDhUpLUYZmFPuKT0ulEfvx+nCGI3w1b3jNLFs3Fai1N2F69BRu2Y3WS7mkm6doDTtgNvI4QZt1U9ncGObyjqmgOhSSevpNOgh+VGTlV7yf3KB1wsrUB1T4dG4y/IhtE2Y1THzmFIrne/UlnMT/RVYro3s+5E2oviaNJIMaS0+KcZEHmDEtql4P2C7qrD6LMI1QV7JNc3KBPKPDpWMMiSvcktyonqj+7681hDytctJ8FDzqWZA5omvmMMHnbAcdpdJd28xhE2FLTOKQiUA/JXduS7D5H3MkUzMZH7q809VIjHRVCMMyCwUw2kWHpn5o4yLVfNlky6tJWV0XLajp8yB5OgGJ8caTJuMah/EsBBIMC+XjCEHLLx3FrHcb61QEKCgCYzd9I7n81/lYzr7ncf1+txed/K8JViGcN63JaQSh1V0ZOF/uoWsvyCF/KA+zfBc4OyBNFh3LmbDRUWhy/xs/+EGGn/4kmH2zlVC45FyzZIW6dXN5eiJN2AcmC+fBX+sYgYgW70XLtwcASnNQUsTGnYrLs5aVPaUtBwGLoUi4lm3E10FXtNckWXVlarZayscUFMeQ5WWVk9KCH8KkyennRQmuP08+JT0YWlJols5qn458ifKaehHC8xhuJFVwnB7g3OdOeQhRDbznROL9nob33hh+ANUC1EWGPKT3Sn+RPwTHfLjyriHI/m6P0xYkxaeZE2l6Ivwi3H6Fryir432s+FB/1qnnnOBXtpwVqDx2Gzh6Zz06KulEwZ4IvlWrHw/ie/9cDYGOdDYQG9kUklP+oKGmol7rzSnen7Otuizxvtk17vaY46vZnHnBeisuqYd65DYepTghOZOemwcfFuGS+lpDvV4XOjEAoa1zVgM/OtpSDBKT+1ZJ8FAj7YtjFTf3nlWLlp4X YpFFAj+d T0bk7bLxX4OlYrYbEQS0EPSCf8peVgwddLZI8LUbLxklO6a7L/de/RM8LJO3IOVzjWlJ4oneLRKWq7mttNK9NHxXpqq/+GNnrJguaBl6p6qXKPbBcoYR5EYJnVm31NcvDhSe7Qckb3svvphmPVUsG4cpnVo0yUu/Qcsyfablyus6S4YQdP21VwAUHu3Hd0fnR8K/DnYOlXdjinx0psclxDR2KUSKYOAqg2CXUSrT4N0nuGzCgV+4vO6qegw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote: > The PageHWPoison() call can be converted over to the respective folio call > folio_test_hwpoison(). This introduces no functional changes. Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense. Individual pages are hwpoisoned. You're only testing the head page if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() to test if _any_ page in the folio is poisoned. But blindly converting PageHWPoison to folio_test_hwpoison() is wrong. If anyone knows how to poison folio_test_hwpoison() to make it not work, I'd appreciate it. > Signed-off-by: Luis Chamberlain > --- > mm/shmem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 5bf92d571092..6f117c3cbe89 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3483,7 +3483,7 @@ static const char *shmem_get_link(struct dentry *dentry, > folio = filemap_get_folio(inode->i_mapping, 0); > if (IS_ERR(folio)) > return ERR_PTR(-ECHILD); > - if (PageHWPoison(folio_page(folio, 0)) || > + if (folio_test_hwpoison(folio) || > !folio_test_uptodate(folio)) { > folio_put(folio); > return ERR_PTR(-ECHILD); > @@ -3494,7 +3494,7 @@ static const char *shmem_get_link(struct dentry *dentry, > return ERR_PTR(error); > if (!folio) > return ERR_PTR(-ECHILD); > - if (PageHWPoison(folio_page(folio, 0))) { > + if (folio_test_hwpoison(folio)) { > folio_unlock(folio); > folio_put(folio); > return ERR_PTR(-ECHILD); > @@ -4672,7 +4672,7 @@ struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > return &folio->page; > > page = folio_file_page(folio, index); > - if (PageHWPoison(page)) { > + if (folio_test_hwpoison(folio)) { > folio_put(folio); > return ERR_PTR(-EIO); > } > -- > 2.39.2 >