From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E99C77B7E for ; Fri, 21 Apr 2023 22:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E06276B0078; Fri, 21 Apr 2023 18:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D68436B007B; Fri, 21 Apr 2023 18:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2FA96B007D; Fri, 21 Apr 2023 18:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AFF526B0078 for ; Fri, 21 Apr 2023 18:30:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 85B9B160589 for ; Fri, 21 Apr 2023 22:30:27 +0000 (UTC) X-FDA: 80706843294.18.C6DE1DB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 31B0B140011 for ; Fri, 21 Apr 2023 22:30:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4FAhsMmp; spf=none (imf09.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682116225; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HB77AFqGG2aBz+Earrmv/XakHzRKihV+YVKN5AMto9w=; b=xCS3dDhetghsrnAnvYUqEsvDQnSKbnu5or1nfJuFZlLD27x/MJyvnXHr6SDGJHMj5GgPSK hVgBwRKRuPlnDjU3amFi7CWA3eLFRAUfG2xnpni9ic0Aua0rCtWRlg//Q9N9W0oAtdfuEB s2XrnbH2RNUyAmOHWLcLvhQ+PH/yjNA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682116225; a=rsa-sha256; cv=none; b=a5FmI36peYC/Zbc2sJXnBI2R4tMfU0rYqzZpBCGXqbonHdmsHMv1McOyD4pMQ3F2MbZc50 tXRzSRGNTfoBDSmEZRpVlRLsMBjhick8sTjGdOAdqjtx3kcXU6T0UwoGmRqaUrpv2Stob1 8uVNrxtLoFlhUMmhT1FsRWcTxSJBJVs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=4FAhsMmp; spf=none (imf09.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=HB77AFqGG2aBz+Earrmv/XakHzRKihV+YVKN5AMto9w=; b=4FAhsMmpd9R2NNkxWh/EOySpZr 3xMTf/cJ0+PNnJ2jbCGrZ6Gm69S6q3oAJkQ5yxUgkzhcpqqnYZvVCHMRG8Q44ftomMGgGmtsv/8/X hLnbhCDJuUrYaDwBuiiHWOQXrGjbspvupGp/eN9bsdk3b24WwsY/XkPvVT5hwOMnBBpGjaVdxENjr JoSB/n2YtzxQjl7qJQXY3ceKtXXJY4bChFW37Up6awJh/gBfz/LWtS/CSRHQfrPbEyn5NMMZ8oBKk 1goaCU9P4Fulz/XxFCHiY4WPfQQd0fy3A/4pu1F6QjPYE6VPjaXVeuxuTCdmZo1zkvy/1rmg6rqcb /nt47FEw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ppzGj-00BxAj-0p; Fri, 21 Apr 2023 22:30:17 +0000 Date: Fri, 21 Apr 2023 15:30:17 -0700 From: Luis Chamberlain To: Jens Axboe Cc: Matthew Wilcox , agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> <47688c1d-9cf1-3e08-1f1d-a051b25d010e@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47688c1d-9cf1-3e08-1f1d-a051b25d010e@kernel.dk> X-Rspam-User: X-Rspamd-Queue-Id: 31B0B140011 X-Rspamd-Server: rspam09 X-Stat-Signature: ptznrenfqbwp1cfmxx4hnd33jizweh81 X-HE-Tag: 1682116225-125996 X-HE-Meta: U2FsdGVkX19wZIqJlqmFfUtGWZ/1iHvKvnTW63LTNq2GseX6m0wMMzv/x8RZTkInUYD6uOFGyYjQvZ3dcUs6I1MlJ/bD/FOx8DVyPTGzghgeZgt60Lwo8b1D7+yVC51kSFJIv/AEXuQg+OUIb42mwrc+CUuokQuVMZLAEIOsfNJVjag2Ihim3esW2DmkgBNa1Stz5upShbrIXwNiFFgHjlObT36DkgLU4d/x2hxjbR9q2fqRQtVPA0KonQ004aQksYHh+ObE1ZyKRW2Zi7vecPiCXWJrjRp2IUHI9SROqvjI/AH9jlWm/n0JjauqIo2YNZP692GYOPaHVZ/oNsgBy8fqBLQcbKE44Lt6+MdzLae1MaHkeYNJhbLXMtOxtgZZKb3mmgecZpFAHUx7h2p5FbvE/Ta5fjhMkK9ArP5B8mN2b8qNz9nEJ51krW/pEdNb/kcEv+OB7qwUYLVHP14vrGK7Nnm6HLVIMTtdK13alUTsgEgqKHahZxoH6b+v08yfFFSu7vkB03u+jGSDHshNWdZ2r6GyhevWqlOg8wdXXN7oLvZ9ompo706oI6zQee6IIDqO84F7TJMjUDb6xBWJVj2MrPRkHS6nYCOfhqQ9BsFkMmSz16Z4y/ZWFwoe00iQOth41+L0SQE9+P99o/hsXK9P6MXThWkj/9S/AceA5q1w4rXlkPHJltOQkKg9ZbBUcl8hwdFIFzgnR9kRnlqJqCehvFg+WXh7Rpz/9fr3rZcsVi3sBvfi/36MV2Gb8h3JaBnmomY4IUEFuK7UtLKXz0pLPpgeNb9KY1NNK9OGED9J8hAKYVE8nf6i74J58D8HLf3iAIIVx+dMWOsF0PlMTekIaZVLemnC88/a+P/mR/4vHghNowVOqbiNiF9sK+fIEdu9TbekAFgWT4pz0OJhuTWQWd2sIU9NvCLlfshv0f7y1BFIucBiO0AjxwwyygLup1T49sLPIxH4+vRTyIL 3YjYWudD N8/VBOidJbJATg6Bsu0Jm6kwiFwpHs0rmgIwFajuC23CS1vqmRs7t5mEQy++HwLUZx9nd+HAUF8P6oFBJH48uO4wQ7GkEaRzH6TmjrgLHs1tDB8ZIVxq5rCaKsnHrorytknJfE+m9QbewieYezoBZgQeIPs/sC+X+M/mANclnOZgHvQxUm840C1rMwRAo6B1drIJLM9jYnHpYPkutH81kvbiDWDIDCsOPLxoOR/cjOf1DK7t3zaVc1yqe6AYA4Iqe5tUKO2NMm7OYiGJV0qXa4nK6D4rBz3o6hyLbC9yRB4W3T71F8qLA9OU4U2M53YyvmGYKh2FWjuxox37HhHpDfDnSHYdnyYBwf30WxfP9aA4JIdo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000096, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 04:24:57PM -0600, Jens Axboe wrote: > On 4/21/23 4:02 PM, Luis Chamberlain wrote: > > On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote: > >> On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > >>> Just use the PAGE_SECTORS generic define. This produces no functional > >>> changes. While at it use left shift to simplify this even further. > >> > >> How is FOO << 2 simpler than FOO * 4? > >> > >>> - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > >>> + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2, > > > > We could just do: > > > > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS, > > > > The shift just seemed optimal if we're just going to change it. > > It's going to generate the same code, but the multiplication is arguably > easier to read (or harder to misread). Then let's stick with the 4 * PAGE_SECTORS. Let me know if you need another patch. Luis