From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD456C7618E for ; Fri, 21 Apr 2023 22:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50FCE6B0071; Fri, 21 Apr 2023 18:02:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 499436B0074; Fri, 21 Apr 2023 18:02:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339B96B0075; Fri, 21 Apr 2023 18:02:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 219C06B0071 for ; Fri, 21 Apr 2023 18:02:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB515A0531 for ; Fri, 21 Apr 2023 22:02:40 +0000 (UTC) X-FDA: 80706773280.05.26AD85E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 154B580008 for ; Fri, 21 Apr 2023 22:02:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="TZu/Zi5u"; spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682114559; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zJtElQBBcdjQLKuTgcAUU6SVKeCB/u/2QO+HYPXJ5yM=; b=mk+OucJgWJ4jS9OfR+NTt+/ghX85+5AMjvOt/SeBTAT9qBtYkbeYU6ntrCiOTN0lgq8MBu DHNk5xsLKY8QhO/GBlU0BQwDhglOaiPcnN48iOKBiwVl6mR9tv0pKzTgEjcxQ+g+JZAMKV J0Yy+0+WElhxVxHZTlWEeMIzFU9NwJo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="TZu/Zi5u"; spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682114559; a=rsa-sha256; cv=none; b=OUhVv88c0WCCAk27tJC4ksT5CHKepOVYTHvC5FD7ivnYY+a3hrY6ER4aPsignGZC0nvVo5 K3STEKZlitxXd+0eq1vo1vm3ixu7c1OSKMjI76YJh1WsyegL4NkbsJZoS1okDKXskqz7+Q ifI14R1IONWdOKopORYdEOl41ssWKTM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zJtElQBBcdjQLKuTgcAUU6SVKeCB/u/2QO+HYPXJ5yM=; b=TZu/Zi5uyNmtM3AYC5F+uKMVsg hHiw+cqzzyEH5I7hS1byjWvZbtD93wTW5QBG4M2KWk+B9WNSSwm8v8mi/Pnh/wNHKblwtRlS/KMzQ Ay3jyrkfXj38Eh37M4Cv7VwmsBNNmqrv9OwKF8lm0f+wSW4Om7abWzDRmsfs9KuyHuU0Imx3Q0AER ZAbNWgHZn5tbTJvEdgqX6vx58Jc1AstSfU9BdUtC5U+O8zrXvOcpy1sMmYqObWFFEt0xJw9Ase7ZL 24pyTndrtdkUUd3SbhFseygDv/Okmg+4zGC/X9a2KfIdvJud/46SLd6TpOspXAPAEoF1aQEjJW7ON WDwf8KDw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ppypq-00Bv2r-1H; Fri, 21 Apr 2023 22:02:30 +0000 Date: Fri, 21 Apr 2023 15:02:30 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 154B580008 X-Stat-Signature: 3xfihsfou58c47m9ifk4ffrffby54uaj X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682114558-160297 X-HE-Meta: U2FsdGVkX1/BnNjllPRkrBM2/iR+uo/Hzdc6cvGU/a3BhKuN6AisU+Qaxu3nrsGG/3gaMJqOTAECKi7yxZ6mzToXR35Mwzh1hE2FR5AOvu0m2/Z7K+xPmASQlFsr3ZgNUPvca+dBNILOrdYjMZ3crzkODfqgjjUdmjbEviAKDOZj+f1hLNILl334/Xn8ulyBNbSbPnf+oDsSj9AozHzEVJLRKtGIB++p0y7LuKCs6/9OtYFXPPgDsj2hhVBtVYFxxISJKVMnvvNZWyHnf5a/sBOVLKVRmibH1FbGsTlrzn6FVCjAzDS6UP2PSnz9qifesa+UYK/MyBlBllhYaUiB81TdWbGH+LRlDwuAv+cRgJAtYhJTGMTM+N23yzGPfrZ1Yk8DOaO4KZoJtutdzjP3+owmgaxz3WpjEEUuq8eECQz0SdE7CDTZrnScqj4VhiLclsBFEYYP82BuBsji6jIb+oQ4MTyU04wNhs9Zoobgw8pQmCShxcT+BfH94rmQkX6d2HYhJMHot2vol6Wr9R4dh+UkAh1E0MyowZZ/n2r8oY4yx3PDYmUQNpG8T4Ett/CRLcBfJxL7iGFBjbjJO6U7QlNM8kn3gdrbrI5AqjimdlufZ9xVdlFLJ4YunQNC2zNvW1KtEFkPTGakXbRn9EAU0x0zuupTxrJHXA/8Hh719zJtnCtzS8K70k6Vq5kosf/XZpGI69yM8N1sv8Zb3CLeqb+mh92fUoIiujDGYjLB61vI18Rd+pd5Qw5lPD2m0sMRhK1hOHW3gyB6C7wl6uGXL4tlirbp4/3/u1BZh/dfu0hG+8S5AmtvWpqkTzB4XOK8eNFcSP9fKDwDaNHf0zEcS62scUYv+DdY/hUkROa9/zZyr/OVzcTRMuu+CuD4wNPZlm4lF/+lVpomDLz9mg5y8rwjyfC+aBxEIIqpxehCHn+MuYsXsTIihB7SYqQhSIu1AO4GxnE6ByYvpFuHkvY 0ugwJ3TJ dJ5bb2nDu6q3iNrPnUt+polGYJYSuYHulkFA0HBIbA0Bty/Maldhmz/uhQznvCYVrGyE+4vfxv5EbbLH0z2uIf/ts5xu9hbHhSPSmkovXrKe1CRV4jQnWjM4spu1HzMU4p3c1D9R5FpGWtAXcSTVmIeeL+TxXxC+aCyUZ2Tprf6gqgOYH23AsBqzqY5HxKxdgzyRz2xt/IRp2f4aR7UJwoCErtp9oyOIp+XyD4QKXGsuHw7D+QCp/8yGL8GMr3hhWx83vsEk6nISXro6UKYaK7FzgCGqkyfF+2csZKNWZeuUglx24kppfmmxEDN7IQ5E++Ic6Hnd6a1iEVb6qXYyTP0MnOYhnN0sUwO4dvYXmj+Jed2U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000648, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote: > On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > > Just use the PAGE_SECTORS generic define. This produces no functional > > changes. While at it use left shift to simplify this even further. > > How is FOO << 2 simpler than FOO * 4? > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2, We could just do: - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS, The shift just seemed optimal if we're just going to change it. Luis