From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F65C77B76 for ; Fri, 21 Apr 2023 20:15:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 117A76B0071; Fri, 21 Apr 2023 16:15:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7D46B0072; Fri, 21 Apr 2023 16:15:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9A86B0074; Fri, 21 Apr 2023 16:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E0AA66B0071 for ; Fri, 21 Apr 2023 16:15:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ACC77AC9F3 for ; Fri, 21 Apr 2023 20:15:26 +0000 (UTC) X-FDA: 80706503052.12.B5BF5CD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 0B26780009 for ; Fri, 21 Apr 2023 20:15:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mr+zjn1y; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682108125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7jDGoKVRVE8/8Iw2EXqkPonvmAc0gvYRAzqps4fjwwg=; b=XaY0pFqEgf4yJyT0ex0hYHsBE7/O87HSbaD04onpPwYFAnINMfi7o261NFgHoC2uHN7lJO ScTgr8NtwZ3lR35YP/HgaiMa7Z0rfwDYpwR00ZGF+S7oh3qhBBKh3mkkMqF9IaWCpqVJcF 4zrzo09EpQBarK+LLAPmjW8SpJKGS40= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mr+zjn1y; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682108125; a=rsa-sha256; cv=none; b=0PzVyT8EK7VWcIptXKLjCHsXv+Rk/IvhWC/Me9thd1hwq0RZb2Ui1khDe8oQQl6IJVQxhD f93SpEVes1RXhwFh1IZyhNq/EYZluHRgUUgMIV73+cc+QE4WXw/2ZwUM/7Hc3ZSCOPk5rQ fVeUbsB8nntRhgbW2F93/g24zVByvxc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7jDGoKVRVE8/8Iw2EXqkPonvmAc0gvYRAzqps4fjwwg=; b=mr+zjn1yXtzKk4APmgRaOn77YC qyrdJusW0V5fFBehp0H4LgJmcOzWB0HiZ/19FHS9XzMMBWYiQQiK2ov9vzahR7YBu95NK76q9JJZs AkLKN4MUKm/MQ5+LZ/SLYHWNNTKsZIr04BKzck1FGkgdltQkKD7lNhCvCFoMTcFExtsIMgiMKVPre m9Im6jnJmlKaq2x+wCYrcuNfTZjtNWDTsZNJmxJoZAgKC50KnsIBoeDx/zoi7hd2VV9XP++ihIvTA tOEZ5yH+/ubaSmLHWmwzD23OC6iMGfb2/N5vqIvhKd4FYrTP8/q/0FOd4KBWDZDlc9qXT016NGn1F NwwreEtg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppxA3-00FZsC-AG; Fri, 21 Apr 2023 20:15:15 +0000 Date: Fri, 21 Apr 2023 21:15:15 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 1/5] dm integrity: simplify by using PAGE_SECTORS_SHIFT Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-2-mcgrof@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0B26780009 X-Stat-Signature: twrqpsa466ns58et74p7zn3acyc4z8qp X-Rspam-User: X-HE-Tag: 1682108124-663452 X-HE-Meta: U2FsdGVkX18VIEPwrj6Mw+WVWd2J6Al9z7lX9dVmswmw6BzbSWBgyeV3BVU9XHN596WbSWZVk8Zzwh790GG/gn71GkffY2ph0c6wiPyKGr5acz29agqB90Lq/qy8dJUgNae/Uca4bQP4fKPEXZlaf5mQQqnsa1J8R9u/Sr/mLJX3n+nT2FR+UgkdBoNY82glt69ofDFnj5OqCgybKFe5QpzE+vDgXzlQUq7WZxG3ZIGheVwBDftdQU0a1QILO7vIK8B2hPjS9wm8Gd6cNDpXoyxwhywVC8LztD8gtAPpLI/rtrMzwtmSFfE2JdC2ciL3h2OYXnIJlFdIsni+txEkCoj+VwicbdxuMoQam2lJ00GdN1y1jS9BmJNqQYzaovyn8oFJf4dKwYocphZPYRmMkeH2pTYeQ7AJoY7PiwfA3+9Okg7ckYz3PjECqGIMvxxCfJ+LMPlee4lOcBhmchzrRkB9DxpDwHaogSpJZmX0o3gOTqpqKUVFz2/eRzRw0FyuI1irkoJeu3C4hFNmE3mbvG4lx8i8RwqGPz/wk58OOdDYqguuj5kJ2++iwHdum6oj2sjLwJdB+zcBAvWMCD5Hr4h9X0ivZYiW4i4WAoGgj8nPUnc1Kg03KEBUmcj+Awzsn3pB9hck3SdFmrL7JxJCwjX9tlxkS8jzw2Cz//MpgKJPTFIHuMAuDQW6t0qlL/zkVmOSNZzH7DZ/xSXXzIwJyCIUhCixqct+Ae7Yq2Btz+05LWuRrykZA3d6VPEwoO7brga6ehsmviyzJxWXlxNklMRIr7CzEjtjBgXdHV18i2wSlZ1jurG0Y5EYVJOP5T4zHyebX/U4Wn4ak9XQfmws0GPK8ZO6zVUi2fQWsul0bLTf3f+RnmWm/uUF+Wow1BI7EojsSzkoBQkYQHoVcDnDPCR/UM3DtO/dCrjhPA5+aXKRvcKRwxfBvUcQFdVPhvZPPUuoeYyiGe6PZyQ+0SD fUxcydUd sNF6Ix4VXn0/BfGIbAm9JQmRe/lTuB26f0+eKTV4N7QCohty6Q3QTavchXeBn5WmVwu2EkYcKq32TcYYXvhqOQ/Bm4l5AmotxKSneuLfFDyjoA29XnEKRzoIEtN8dzQZ+ghk3RiZ+v9Q1NC060i58VaJvmhDE+8S8m0D+6Dc9H6Ykgdtr/QCtse2ulA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000040, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 12:58:03PM -0700, Luis Chamberlain wrote: > - *pl_index = sector >> (PAGE_SHIFT - SECTOR_SHIFT); > + *pl_index = sector >> (PAGE_SECTORS_SHIFT); You could/should remove the () around PAGE_SECTORS_SHIFT (throughout)