From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD66C7618E for ; Thu, 20 Apr 2023 19:48:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E41F900003; Thu, 20 Apr 2023 15:48:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19449900002; Thu, 20 Apr 2023 15:48:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05CE0900003; Thu, 20 Apr 2023 15:48:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EAAFA900002 for ; Thu, 20 Apr 2023 15:48:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8A03AC3E6 for ; Thu, 20 Apr 2023 19:48:52 +0000 (UTC) X-FDA: 80702807304.10.A48348C Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf17.hostedemail.com (Postfix) with ESMTP id A588F4001B for ; Thu, 20 Apr 2023 19:48:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=GoIwaWRN; spf=pass (imf17.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682020130; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=JPtfoWMl053gkswHjIsnr53hcsgQvdbivDJKRURN9eCXTrPzz0lJKUyn1tDZM3jkIUAFwV ggzDUz/uUFCIyPewNYcADAaFbbvLMZdM2/1miftqioKquF1qMzBwSIJn9n6jqMyTjrm5dH jhuA2UcgVJC+excApJjwneYyQkXphPA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682020130; a=rsa-sha256; cv=none; b=rFaKNyifarLOZbU5aZyrjdTSECWyqGO0FYQpOMGF++WaOsd5pebA/AYuOFb+fQHxtHbqqY 50qAUanWWNFZf++s8S7yQCut78HN6CiCarFqY6gciGfQfNNbqeAmbeEui3mC3yvrAumswD ztTz028qYF8HwFn5ocelmDYkuslvXQI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=GoIwaWRN; spf=pass (imf17.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-246fa478d45so1210715a91.3 for ; Thu, 20 Apr 2023 12:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682020128; x=1684612128; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=GoIwaWRNZp8R808HTRD2raT1Cv8BRnqejXttPEHtds1fb9h/AhpUl9OJJDZbZmKXs5 ej/EgFXvWbW4w9LKCGU126TWEXFo2+e2QBkYSEiIkVYLkKp1Yq2F3zfrwPr0jqd9Gxuf nQBlNGqMhkaoKeGxlQQKNtnQKu8VM9dMoPNkjoNtq2Vl5kaG9YwMIhgPxXoCy36D5FRc kTUIUtcABjFyfsXA5LyCQQ3tIc/llbcBmRnzOByhC5xDRPIRsz2ZEK0WecgOzzFd/OBx kDyCdn5VDNCWI38ITAGu4oI1U/W4LwSmXRJIn63S/wewHbLIYoRGeaHxay6aEJrk9U+e dTKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682020128; x=1684612128; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=AECbXlF0fHS9JQdiKg5RgOvp7SCD5e8Tk9sg36PwVMmvY3iqRv17IcQxHnulS67n6y bTumlwIB+UdKR8ELb7qIUm60ZEscE3J6dXoisNrTVvZxjvin+nDkV5BY4hXHA+6ojr3V +0lNN+O31QBoICpMsM6x81hhUgtNhMY2dQJDz5moA22mpILXbnz/kvKirmFNHi9HDpwK DVC4kZhzY0Z3S9piy43GS1DVcOF29t9gbPwL0XYcUPjDlPC7iicTJCVcH9ajJdOZKjke iQAL+Em9JexK0M41dvYDQ7H+zqN2KRcS5Tlz/MfjjMAz8XLNgH1SXZDGH47v2zwdzwmW 96aQ== X-Gm-Message-State: AAQBX9fAKCSH3RQSY85whYwtsn601kxyWsH/P5/e1k1VMT1rntvRlmek onTjD5elGEWEZa7/40nVCsA= X-Google-Smtp-Source: AKy350ZtGf0SkVbGCZspaovqfSWXuducYPXYd9oQgGaKPCyMX1ORGiwZ1xJNcQ1I3koOdW1GPF86ng== X-Received: by 2002:a17:90a:c24a:b0:23d:35d9:d065 with SMTP id d10-20020a17090ac24a00b0023d35d9d065mr2219608pjx.48.1682020127742; Thu, 20 Apr 2023 12:48:47 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id j12-20020a170902c3cc00b001a04d27ee92sm1474391plj.241.2023.04.20.12.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 12:48:47 -0700 (PDT) Date: Thu, 20 Apr 2023 09:48:46 -1000 From: Tejun Heo To: Shakeel Butt Cc: Yosry Ahmed , Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm-unstable RFC 5/5] cgroup: remove cgroup_rstat_flush_atomic() Message-ID: References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-6-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: A588F4001B X-Rspamd-Server: rspam09 X-Stat-Signature: xihpooz8su1cq38p3thu5ubr77uyd3os X-HE-Tag: 1682020130-90664 X-HE-Meta: U2FsdGVkX1+tkxCNHSSvFXC5tSNbE+TeLgRFOWuF5Mz5RCE4AjEMuDvsuSZclWeGX+fbpnvEC5CZFLnw+KowelV7nJRYHyLl1oCeAvhpQv0Xmkapat08AxXFRhcUzDVA8pUKJKFWwoYYbjJ775a+OE9OzWQUd1XDj+37Q2Sslbg+WBEYSH+JqT5fxQpfi9dP1rmZndb9u5GZ75FAV0kxG2JIza1zredlw7TizE4q65AlDx70VOVGXTX3o2EEaUCq0HaLTvm6FaidHchj++FvtauVfBjdilERCvoX7uO9nbsn2KWYCJF+fSC14jNRfDlHAqzLHufIkGO5LvkaY66rEukZccecpUqk+u2mIqAeRJ9mIgpEMiPlfFQf+Q1ibfHCxPBOj7PuKVlTLtIJSwohgZqj4nZl/v4x2CV4qlgM2voMZkJACs6ViSgdJwkGcZt72FcOSA3FXods/m5nlnX2EKOjgvkTikfuoWgv441LkBG19dmrLV+0szqh12gtCGd6o3yKaQjhgL2ieLuWujI8r6vknnqbNfYMnnif3sWtctzJ1Mlu+EY7+TmHa5b26CyK6nCVozyHkqGgra+GTJMxNURACTwXuldo6Vj0JcsZ5zNI52izM2GLqgGMGMi3bBXG+B/dyggYfxI5VaCoOYbZ0YzO+hfyUTr4bTC7HOtO+u3N9uFtcFq4sDbJrzX/bwq5L2CnOBu08mebCOHfzDGUisPbS59sXphyag2we0i/0NoJhOi2EEDDeRIxbvT2Ia4aIKbUNLQXF5lrHsjNoJAxcfLC5rnxjsHgJnS2UhFJO3ZAvand6aGib79/N2Yl3QH1B8+ty6UOLCPxOVXk7OOwbgYXBZGPblw7VXE6a00D7lUyLE9uBltpUUyX8Pcj0QJ5pbiNFkoUHqzsI7kWPgYcY4+3ar5SUMPFXNJLnpWeXl93tTQ9I1tSMCi7oQ8VSbBpcHF96jWkDJ2LPXy+O5r 317fNQJs YKKv8xWAchz28Y/VX+Brazv3hE9pXfXfFFhEmMqOIbBCYGLJRqUZ6FzSMVpaqeMomhDrjpytc8EpFVy2zq5r+QjdxlKB//F+7fOe7Asl8XHugTIxfvip2ZSQz5lwld0PptSZABE/jGP1nWaqsVoZxkmjm+92N9bPH8jvqnMVpn/wx2PL9R8aO0NLI12stxYmnkaQjYxaqzG86m+mbXPaZ61MJY6cxmolbBmGSZ0N7SKu9Lv0+F2gaFfHaEqCXpXHnR5ljZIjBm+2WusXL5XDmizw3cbnMjKBJpl6MSg3u51ZnKrLj3+EbXVmRa9D86c1uUYmFnyD6b8n25z/CFVlkXgYfNotqlZrqO7x9urrGlW4usMreNNZv+oUaH+A421jSN1I3X0bBFwq++aSvWLf+6NYvfHp02OQY7WIFzoAKs2Q/kBn9Natp1yIx+Z05q0pWQxNu+ydh6pBiJ8NPo3Ow6qAeqjfCtdi5yRqQFY5XVEnjgDAKug04nQDzQWu354xr/6HNo98EA8Tz83fq2dREsecTL4OwOMHT1emtf80iDNZRCgHBRmedfw/Wvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 20, 2023 at 12:40:24PM -0700, Shakeel Butt wrote: > +Tejun > > > On Mon, Apr 3, 2023 at 3:03 PM Yosry Ahmed wrote: > > > > Previous patches removed the only caller of cgroup_rstat_flush_atomic(). > > Remove the function and simplify the code. > > > I would say let cgroup maintainers decide this and this patch can be > decoupled from the series. Looks fine to me but yeah please cc me on the whole series from the next round. Thanks. -- tejun