From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B208C77B73 for ; Thu, 20 Apr 2023 12:07:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B807900004; Thu, 20 Apr 2023 08:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96634900002; Thu, 20 Apr 2023 08:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 855DE900004; Thu, 20 Apr 2023 08:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 72D6E900002 for ; Thu, 20 Apr 2023 08:07:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2D525AC5C5 for ; Thu, 20 Apr 2023 12:07:12 +0000 (UTC) X-FDA: 80701643904.21.0E18E31 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 769C140014 for ; Thu, 20 Apr 2023 12:07:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oaOdSM1B; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681992429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cfu30d15ow+avOD5lgzsB1BefQFrsp299WM+lwWiBEk=; b=HEMU79orrUn+FbI69gp6O7kIn2Rz6Xn1CSQbRVd6L85knRpd6QLBdkZpQ6RFxT5yKAUSqF Dsc8Z7wYHGX8jJ6AkP1rX3B3GON6OLyJhXoACvminpT3CFUF9ilF7v0WX+ZdUW8B5mXcWo NKQe6oX9PFABigoiOHZ4kCWUCT+joo4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681992429; a=rsa-sha256; cv=none; b=8lPh4e4dCQpPee3G2clSNzmyJbmiCuw6eh12w/v3qjYEgpomwDwLyisRcdhDWVOBhB5UOt bbIIC0aXCgmiXKE77lwXCI95zMfDAh6FoRzjS/ChOEdjZn2IlqqegpJ2HwDXoLZMmobd45 lrqPC+W2EtCZw94MpI/mHUry4iTXTXo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oaOdSM1B; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cfu30d15ow+avOD5lgzsB1BefQFrsp299WM+lwWiBEk=; b=oaOdSM1B7MdYwXCEKHrqG27tWs 9KUuiFRuJBfJst+NFhbr1jUPCMSCozabAry2m3EkXTHfYDcNhdVc+g3CXNXkqTUu8tsFo7Z+G/J2Y UywJWtyVXi5CluJ+0ynUHHBZZhuEv+pwxZOu7I9WzC1/1tgX98k2uSztCKsMH2Fi1OMcUan0P5v6h ktKfRN+bwSDw4d0d+fhNE0UXfz9PIR2wtEfR0mOixmej8JGGFrI7ITUDW7XuLAD7KbBdcAozswkMa 5IvVCFwxIO2Och28OqAeVGGfq/3bmPfwdnUkS5lYOScn/IdO9w1ql1IJX0TRGoGVrpBGOt9fS/Ebb yznLN8ww==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppT3u-00EEMu-Nk; Thu, 20 Apr 2023 12:06:54 +0000 Date: Thu, 20 Apr 2023 13:06:54 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [Resend PATCH] mm: mark folio as workingset in lru_deactivate_fn Message-ID: References: <1681980304-11719-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1681980304-11719-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspam-User: X-Rspamd-Queue-Id: 769C140014 X-Rspamd-Server: rspam09 X-Stat-Signature: sdb5x8kagpezrr8dtc1k38i5wi519nbp X-HE-Tag: 1681992428-18305 X-HE-Meta: U2FsdGVkX1/3kzDtTrLnwDk2ndkIIsAKnD1PdnNfshSbf+NPxX3sjZy8zEoFyutqsZSCuwxEcMai8YFVZJ8oMY1dxHoIFhdOl5XKAuUpOP1uNGPYBHx5tjxRdi4nivkKtEe+k+zpqFOU07/qNLzU2p3u8RivT73TE+gSda8xQf7OzS9lq3QEUVWeKEgRcUN+OFtfj5g18GeFskdTjmvVmCOqeBD9PE+KwGxV7+I0O3xASO+VuVgr459eaOqsCVr7r0vRCBG7MFskxVuZmIKg9QvEL9lGfEVMF2jJSVhHXERWnBeD6YLR3I0C27dCKcqWibqk8yENhffI5ZsTfzBHrO4VxumnI16WpaXhcoPmwqDiYTWgJ+WsEaP4e2vxfmh/9+b/WPY6eb8mxO5je52UYsEc+KoU9r42IHzllKiz9fMdIKuO1HxfWPD+BD34oJYpU4B9gRKOBoY4/zu3dvtWpaoHx5pP8G1s84yR1rRJiMmGZkAYjJZte+a13RpkKHHyZMcmijZEEIM+NAzyomsqCwbCVmmp6+GGNL2R2JlFs9TyhaCoSsyXkr4/bIMmMvD9dXKAX7KjZoDiqMnoFTn2wzUcPOoqqhkXvm7MQSmdciaMIHmWyZphi6Jr6SGqkM28NO9z73o323qOJzVnLNYzthlnTcU3P910khvweidKgCWZEZm47OUv4DAvrv1DVF2w7YnYIsj4071x04NHz5b8hSYJALtZlryFwXse6XHCU+aTuVg0Iuqv12Qzdetq7eXFO41lhkJHzJy28iDLRbWSBdcu3ANxG7zwxJk2IAU6PErodI0lGPMfXSaQxyofjbNKa6k+986h7qET9ZmRBpGztgKBOYw9mwsjcWY8qnx1FOeTvDCZxlayB4FL+X3S+AqMHPJ3n5/9x9cmrSvXpMJrNgbc/hTcmo9/dMjmpwzhNgSV6z/HgBrF827PKLYQYcIQezmkiIdITrby0Cgtv3M 4Deeygsi +aeJmIRaqAuJCiFdxKePCvfSRl6zm+lf1i0cJaBDK48BVgNYKhLfE1pIRIujsjCi7TkRwv9MGtn28HWrqrXdh1zey8C/Gm4wGvWjYPVLu9eSTMvtmr5y5HE3l4X6uJnBV/fH9NybfJPUuQ0nCBRRqv8fmGZw4nym4WILAEfejasO2lMAthYHqlcPy2GUGEm2B+sIP25PFKZpg460lMzCuBWdQeIsM/2tAY7GucvDEGa1YwjB5gIuTCAsN6Fp1gfp0rKUK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 20, 2023 at 04:45:04PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > The folio will be set as workingset by shrink_active_pages during normal reclaiming. > However, it will be escaped from doing so when madvise move it by lru_deactivate__fn, > which will affect accuracy of thrashing. Why are you resending this? Johannes pointed out that your understanding of this situation is wrong. The folio is being made _inactive_. It's clearly no longer part of the working set!