From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CB3C77B73 for ; Thu, 20 Apr 2023 10:54:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A49FA900003; Thu, 20 Apr 2023 06:54:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FA9B900002; Thu, 20 Apr 2023 06:54:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89B49900003; Thu, 20 Apr 2023 06:54:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 79895900002 for ; Thu, 20 Apr 2023 06:54:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44675120130 for ; Thu, 20 Apr 2023 10:54:16 +0000 (UTC) X-FDA: 80701460112.08.420F522 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf23.hostedemail.com (Postfix) with ESMTP id DD3B2140008 for ; Thu, 20 Apr 2023 10:54:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Diag6ujN; spf=pass (imf23.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681988054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eM/bbS9WflvzKKWIfx+jLsxSVcQoWaZ6xsaA8rVouFE=; b=qvhtrtPSBTsGozupRXqtN/I4mDBPvNHAHtt3Lwk1Da2+2TMOxeyGX4vWE6Mlj6wBqv8QAo Qz31w3RIl4XTDJQ2/gYZs5k/MHs4DAvPWFGm6psk/T9XkEQIG5dO8bVeNRBvnJdQFOwFEl XbmbKRqiyOVMstODMtDxbOWanxllsjs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681988054; a=rsa-sha256; cv=none; b=P0SbIhcs9NYUGzxWfbuwev4HPCDh34GB2r8k0nTqQB8RsXWEMgBRGTCgTx911RfPJ1xcwl w7NMOSWKEv76PW8sio7At7kH1tr/UcErLnTfALcV1eQlAlR2gUQWNh471VgUlSXFSFaNLU P8fqR7eXZ4QVOgyWHzvunNCushxQ4Uk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Diag6ujN; spf=pass (imf23.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33KA6Zg5015906; Thu, 20 Apr 2023 10:54:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=eM/bbS9WflvzKKWIfx+jLsxSVcQoWaZ6xsaA8rVouFE=; b=Diag6ujNdT0etL8gWSW0SL0CrJvegkjvLvWFrr0ceVp58z8au8cUiRrk2guXw3DSLSL4 f11ot3Lz9/+kfnSXIT2ud2zTxdOl5HDmvLGS1yOU17OuxbUyCGBfjkL4ds6yiNTgxyKH X85wcjJPym86W9mxUSsODatWX/7h6EMwO37nPgRyRaOVVnuVT84AvhXiqmQAPJa9jYF3 h7nSRbTO2dqADwm/AIWzU8I1nHKCfKuPoHhlFLoJygXjs9nVyYQ5jW6E6q14ae0Ojleg H/v4aYD1cJvOXCsF6aRduj2OjWw1FKCide5tt9jf0SgW2Hz+h82rKchrtBjsvHgck+r6 kA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q31v1cx2r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 10:54:12 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33KAcphK024287; Thu, 20 Apr 2023 10:54:11 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q31v1cx1e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 10:54:11 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33J7bMF4006465; Thu, 20 Apr 2023 10:54:08 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3pykj6bbaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 10:54:08 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33KAs6ew24248938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Apr 2023 10:54:06 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7669E2004B; Thu, 20 Apr 2023 10:54:06 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D29920040; Thu, 20 Apr 2023 10:54:05 +0000 (GMT) Received: from linux.ibm.com (unknown [9.171.40.70]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 20 Apr 2023 10:54:05 +0000 (GMT) Date: Thu, 20 Apr 2023 13:54:03 +0300 From: Mike Rapoport To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz , Nadav Amit , David Hildenbrand , Mike Rapoport , Axel Rasmussen , Leonardo Bras Soares Passos Subject: Re: [PATCH v2 16/31] selftests/mm: UFFDIO_API test Message-ID: References: <20230412163922.327282-1-peterx@redhat.com> <20230412164257.328375-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412164257.328375-1-peterx@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JLNC56jIXz60lHVpOE4tYXeZywynNx6a X-Proofpoint-GUID: XpsqNRY_z0qR0ltFm0kE0siiCjNk5FaB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-20_06,2023-04-20_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304200085 X-Rspam-User: X-Rspamd-Queue-Id: DD3B2140008 X-Rspamd-Server: rspam09 X-Stat-Signature: xrhde1mxs34efdd8ja3ikzwsw79zju3k X-HE-Tag: 1681988053-196413 X-HE-Meta: U2FsdGVkX1/KcN+N1w5vjsJ8ZLdtX/Juub1667RPhTZhYxcfJcbHvoghIISYhtDI3vkXFQ5zN8DTujMkM/ZngclyYnybAHFnCcU3wXDN0L94bMuU4sudnK3k7Qxci5E7UWKyXIU9Pw5kTIRS8lxD10E8+Wg4BudLZQRrf/LiS8EUV+L626kp9wBmCytYULgVa30WkE4CGbgcoyyLgBwTSL49dIdsQYftAlWKWrKrfnlKrAd5XWh2lgZFWhiLULbdAz6ZTZcxYew7srS2mU3k+PuNHdjCXg/0PCF0AYKRRYPLHoE//bsZzAIPnsE7kTNvvcvy0Ui+sY85GvHbJPOkmGBpeLKAxfgqyH/1LfbuGpWljHNyzqdTF8aEGHy5wpg5+WHBc/2CGDZBeAPegItP4Pv36OJ14qPSTnvvUM9tcyDyrMRYc4w/OfqpyEyK+0W3Q1RNe7P0Yn5qpNG19fWJlutAwcHQ4PcahhiqxTnWXeoGNZ765Mu3h/dugCK9WFqxqQ6B3+BkscuFQKTYDUt4Ha1XfAmo3yN8ZHFi/HCz6T7mSUC9D2aTW7rY5mVzRzQBA8aIEYSWhzLvOacqhGzpxtRf53uSmi3AVR8hffkz+breTp043XOPDH6TD1Zk+4NlyzD1UKAhK4I2UzGSXaiIwSEUyOQK4YAoMkG/DGXJAGGiAbi9WPShydgAQftweG061AFWwl+xoPAqTEVlkpGUgSiz5cj5Yjmyp6qAGnA0LVORcgMrRJnQSgPdik+SixJRJPe8WxQQgdMJDfL+6vTbUMIF11nfQvN3t2dSvtuOFnLRumUgBVyQkNsKYVA79ghgrR/+GM6YIUm/FXMGh+RnmzizP53EedtSZr+C/qg8aC7jWXvukhloTffE6WTGGEoDdOHDizAygrhTdnN8mfF/dw6HQlgwRZiQ1k/3tIGPfPLFLfbQRUYAofWgijzpxIgWAUWBQuIeT1WeqD2uSFO B0zl8hel K9BoYy2E1hOlorK7qA7g4FSTJPdWvTXe7NNZDXa5XcBs67km/MCtpyZPSiS+C+s0LMp+x12EbXAMUyhPWE+0kNqaG1SUeZKBSkXq1i6rJWG4rCuAaYrS/o+6kja1tH5GD1SLk7+8XsvXOZ/U5I9bUGgkMTQ2Q5s9pOphrWbxVEggcGEvEUNPpdmP8CAXsyIqufnARM/tx+AbDxugsUMApmOKrJLgLkGy2ShCTw7qou8mFoueNy4hrEdK2wKtzsmkJqZJrWDM9aI3LheuHJ5NZ6CH15tk0E8qf3+3ETt5EBm1ESZVc2I3cuaEuCyvDbFElU3u+uDusW5e4QDJlPgtwfFIb7yLZIZPaG1rK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 12:42:57PM -0400, Peter Xu wrote: > Add one simple test for UFFDIO_API. With that, I also added a bunch of > small but handy helpers along the way. > > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > tools/testing/selftests/mm/uffd-unit-tests.c | 109 ++++++++++++++++++- > 1 file changed, 108 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > index 6857388783be..bb492c258486 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -9,9 +9,116 @@ > > #ifdef __NR_userfaultfd > > +static void uffd_test_report(void) > +{ > + printf("Userfaults unit tests: pass=%u, skip=%u, fail=%u (total=%u)\n", > + ksft_get_pass_cnt(), > + ksft_get_xskip_cnt(), > + ksft_get_fail_cnt(), > + ksft_test_num()); > +} > + > +static void uffd_test_pass(void) > +{ > + printf("done\n"); > + ksft_inc_pass_cnt(); > +} > + > +#define uffd_test_start(...) do { \ > + printf("Testing "); \ > + printf(__VA_ARGS__); \ > + printf("... "); \ > + fflush(stdout); \ > + } while (0) > + > +#define uffd_test_fail(...) do { \ > + printf("failed [reason: "); \ > + printf(__VA_ARGS__); \ > + printf("]\n"); \ > + ksft_inc_fail_cnt(); \ > + } while (0) > + > +#define uffd_test_skip(...) do { \ > + printf("skipped [reason: "); \ > + printf(__VA_ARGS__); \ > + printf("]\n"); \ > + ksft_inc_xskip_cnt(); \ > + } while (0) > + > +/* > + * Returns 1 if specific userfaultfd supported, 0 otherwise. Note, we'll > + * return 1 even if some test failed as long as uffd supported, because in > + * that case we still want to proceed with the rest uffd unit tests. > + */ > +static int test_uffd_api(bool use_dev) > +{ > + struct uffdio_api uffdio_api; > + int uffd; > + > + uffd_test_start("UFFDIO_API (with %s)", > + use_dev ? "/dev/userfaultfd" : "syscall"); > + > + if (use_dev) > + uffd = uffd_open_dev(UFFD_FLAGS); > + else > + uffd = uffd_open_sys(UFFD_FLAGS); > + if (uffd < 0) { > + uffd_test_skip("cannot open userfaultfd handle"); > + return 0; > + } > + > + /* Test wrong UFFD_API */ > + uffdio_api.api = 0xab; > + uffdio_api.features = 0; > + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { > + uffd_test_fail("UFFDIO_API should fail with wrong api but didn't"); > + goto out; > + } > + > + /* Test wrong feature bit */ > + uffdio_api.api = UFFD_API; > + uffdio_api.features = BIT_ULL(63); > + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { > + uffd_test_fail("UFFDIO_API should fail with wrong feature but didn't"); > + goto out; > + } > + > + /* Test normal UFFDIO_API */ > + uffdio_api.api = UFFD_API; > + uffdio_api.features = 0; > + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) { > + uffd_test_fail("UFFDIO_API should succeed but failed"); > + goto out; > + } > + > + /* Test double requests of UFFDIO_API with a random feature set */ > + uffdio_api.features = BIT_ULL(0); > + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { > + uffd_test_fail("UFFDIO_API should reject initialized uffd"); > + goto out; > + } > + > + uffd_test_pass(); > +out: > + close(uffd); > + /* We have a valid uffd handle */ > + return 1; > +} > + > int main(int argc, char *argv[]) > { > - return KSFT_PASS; > + int has_uffd; > + > + has_uffd = test_uffd_api(false); > + has_uffd |= test_uffd_api(true); > + > + if (!has_uffd) { > + printf("Userfaultfd not supported or unprivileged, skip all tests\n"); > + exit(KSFT_SKIP); > + } > + uffd_test_report(); > + > + return ksft_get_fail_cnt() ? KSFT_FAIL : KSFT_PASS; > } > > #else /* __NR_userfaultfd */ > -- > 2.39.1 > -- Sincerely yours, Mike.