From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3405C77B60 for ; Sat, 29 Apr 2023 23:01:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FEDF6B0071; Sat, 29 Apr 2023 19:01:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AEC96B0074; Sat, 29 Apr 2023 19:01:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0287D6B0075; Sat, 29 Apr 2023 19:01:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E6B466B0071 for ; Sat, 29 Apr 2023 19:01:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BA45216054F for ; Sat, 29 Apr 2023 23:01:18 +0000 (UTC) X-FDA: 80735951436.14.ACCD03D Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2084.outbound.protection.outlook.com [40.107.237.84]) by imf18.hostedemail.com (Postfix) with ESMTP id CE8CA1C0011 for ; Sat, 29 Apr 2023 23:01:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=VGyzzmF1; spf=pass (imf18.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.84 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682809276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vAzOe1E4oP2JwXEcXxp6XW35UWYUCw84ldO05T3Lkns=; b=Pfpa6UclbPezdCvwRtcBohV1fqaGPJj+xazgTGsQeYort4ZFdyPdIXvdqkXCIotIAlnYIo PbSXgIx0HYyKpsMlsDMTuo3W3Squt9nCw9IdKsJbyp5g89l5uXyDqSK30OnwdUSCLaHUdf eRJcIv2ifcT9X5cNSUkSCyAAmIUuslo= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1682809276; a=rsa-sha256; cv=pass; b=SFfktDHJQrqNoQFrT+aqCPwh8K7aNQif4NaC9wk9U+f9iNGnw+c5xc0HcpX/yTdMb/dJIb Lco3huPs566ML8OcPmA81rfulTDzytVg3pMA+OY2M3hb7mDvyrUuGDdxgYO2i01Kh5bqWB 7Km6XE4TmBCrvSSAUC4pnQY8tKFT3Cg= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=VGyzzmF1; spf=pass (imf18.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.84 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRvlAc+gOYeNsn1WfUamGMpCQoxYL//qgUtBctRQEoXtb9RmmukVnGYjo8JwGIkUBA3WumR63X+H0YpEwmR/suMqVwvRHSb8DQ0558N2jwU5OiDKxLqLZy8GZzxwc01FQ/EkrtfPiQ7piIScoVYefPF2fniPy8aHvUKpzi75fadZky3hUmFdfbiM9dfRW2fpfpHgUePaDEfQLjSe8X7ZpVYralkOz+FGe4x7Aqfi+g0+E6tKHAPkXrHTy8TxL1CpU3wUDiBpkjlcHkHl8Bhu9O8nu30LMN3ENfT+odCj7YJBWyas4InGVbs87r/cgtvq137UbeGevtqsWrMlzyH4HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vAzOe1E4oP2JwXEcXxp6XW35UWYUCw84ldO05T3Lkns=; b=OSdqdPu6++EViRy5+TCQXx483JM7E1WSCZjWTlEQQC37YURFg1WhPhakzYYfn3k0LO007sIHk8KPidsFMjRPt7tfuP4rsuplkytM8R7u9gYoeczngLihuFpi/jVKXc9JDrQOuuKmQI6mI34p+AdW/u5arSm8f4217yD/Uav/qVi+7rT2eOUV6x9C8L28xmCMBTRvNjKbJRjXeCYXHyTamHmbXYpVCk0Ff+2nFOdJVI6ma0FDWCvVDB1EVn3wnOVCm/gUaiBkLuREPbjpOnNwF5KacrYC9tBp/wV6BCtuUhaUFqgnGUWTSiN3EAnK94ThYzouxkQ34/+YIVPMAz7auQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vAzOe1E4oP2JwXEcXxp6XW35UWYUCw84ldO05T3Lkns=; b=VGyzzmF1+NMk3/44UfdcLMGPB2/TiBWSVUfz2wUAHcGixvciyadploRzein9W0ydIKCYtiUWFC3nLQ9Yme8QQ4LC3UF0h6jACCA6akfXq7O0Snr1+RDd/Fb+Lg5t2tMrJpwqZejD/Qh6Zz1WqvYqwngDqOts332NO1mZx4p/TPD/xxZxld/yCX/cULGRR2UyDsRDBk4rMn7lElZ7LAJqkB1ISponpil36ssWOwUG6Yj75aN46nuAS6/bE9fLN1qsiHb6td6R3HGhxpJn5T/ytmrByekMwctJN29bdmZAHHAI8rk8GKaWo2aL5bLzvo8T01HqdyRmS1s8RJOSiF/Wlw== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by SA1PR12MB8162.namprd12.prod.outlook.com (2603:10b6:806:33a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.27; Sat, 29 Apr 2023 23:01:13 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab%6]) with mapi id 15.20.6340.024; Sat, 29 Apr 2023 23:01:13 +0000 Date: Sat, 29 Apr 2023 20:01:11 -0300 From: Jason Gunthorpe To: Theodore Ts'o Cc: David Hildenbrand , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Message-ID: References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0370.namprd13.prod.outlook.com (2603:10b6:208:2c0::15) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|SA1PR12MB8162:EE_ X-MS-Office365-Filtering-Correlation-Id: b7f0a4b6-9920-4195-1190-08db4905a0ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cvroNd8IL2CEBwf7HOaNb5bO5VEaDVE6NkxfYjBMiWUADkzRfdEWJIDTRN+Eyk22dK4E5bVjbEPinPBV1L6r6v6qepFNdzXmWQQFVOto1cKtP7O8uME9zC30QDajes9ov2jVD77kDx1dE5L0hQFOUGlq6u6AQLvBt0+l1xVy2+cQqBZz/gr1Jtrqvhr1loi/H2VFqloj447qCvJKk5PUKCUs+UCtmIWUZR3oeVl3Ssqxy2au9U101FWNMdAZtVQk7j6ACCpji0eMR4qTNWQOc4I1oj8nwozYJ6i6t/2BWQd89vQaJ0M3gjUhqsWQbcN9YM/IdlmfBb7AtAWOKVyG4WNMIbM+vsbo8/P8qE+DYpf58XecgrPmrCSOJgtYhYObYrh+y9nCLemmOIwCLJCQuCuCigzzOf6HW4+bYR45z6hc+yXVFlFLPLg3nXwQrm1Hp+tWogx0+DNbv4MqPNkyPmUUTTAPcfTq2uiO+Cyr54jMH04rJ+69/cZ8gHRf3BsHdETM76uCiFJpPKZ/LbPWvaei3k3rTBW8PbV4caYzQ/uBut60wgL+BGORNgjlnQq1ZRgJHnLxLSr0dtpGuaXCO6iyEDt9XHFWI8lvD1kvqjI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(316002)(6512007)(6506007)(26005)(186003)(41300700001)(2616005)(83380400001)(66476007)(478600001)(54906003)(66556008)(66946007)(4326008)(6486002)(6916009)(38100700002)(4744005)(2906002)(36756003)(86362001)(5660300002)(8676002)(8936002)(7416002)(7406005)(66899021)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iE0OKmkRiV3OCd4usK7tt+/I2b7ADXN9MFJv9oHh2+6omO5t018JxSVLeAI8?= =?us-ascii?Q?3bkcI+iHJm/IKJevp6X8c515vNGHtpMnVi9BTx9pSk23U48tuAYS/d8kl90a?= =?us-ascii?Q?cQwz32+xyEe1e4trNfj3WEGeF1MlEUuidkRLorfOcQ+E6rDGPVYTTb4jkNuO?= =?us-ascii?Q?VgvYwvI5SYSwcwyTR3HzFQKHoiREZqZAT459owUGvea8sXMdY1av3n6PA/AI?= =?us-ascii?Q?SqlyyXvZ3+2Znu06TR+ldDD11Z5JNs6J+gZ1l3SHmgyCTdIhr4oFlPEJ7116?= =?us-ascii?Q?UVaHuJjw/Tp88nqDhMOZoWTd5LxyamWp7FLxEbVE7JvypAXHgdhDpifYioZQ?= =?us-ascii?Q?j3MoK7hytJI9Mr/DsB4Uckp3+JLthoOWeN3eWreRU26D1Jd1lPs3jJHGhtGm?= =?us-ascii?Q?mZQPfzuLRbUWQzteFu22zSQ4Kqtp5sPm60XQw/5qaoBi0K9zTuChq5RAs7hG?= =?us-ascii?Q?+zcPULtvzHx+IRy5wK9QFuStnLLycVYumWYNHUKIv7kKmcIep2X8yUdUBxRe?= =?us-ascii?Q?oLcoCPRnwKL+wZgVksgJaCuDB6vQn0r8fHmx79xQXAVOwNVRPJsnX10vgBHI?= =?us-ascii?Q?CnaN8ZlrrFrudWgQ12LzAEJ2CMNYpWJyGnte91s2I5VP1GP13GYD/F21nWel?= =?us-ascii?Q?Cg9I0ltOvtG5iT8jpxXk5a8wcMU8Qt8IrL+yKAfsyuGkFvXLwTtsntKwzfjQ?= =?us-ascii?Q?np/cKeTA0iLtmWPJ1JpfZPgbDs7nT69AyXwOKB2Qx6el5jCKYozHGbr45/mI?= =?us-ascii?Q?kadHaAw6dR/x4vRoh/XA7glfEUxGN/spAG0f1Msuza11uHQ8Q/nezLCRxrw4?= =?us-ascii?Q?ZKjDgYfF6VMZFsfLQVtzNvjy0d9AM2vlgykgWzkoazxMT+ZXjkSJksIKdIqD?= =?us-ascii?Q?Y1FUG+czFcDT3O2pwl4q8698854OcWiiLDZKVQyopd+Ns+wvmSfHuutmA1Ak?= =?us-ascii?Q?HYFKNEmcayaUYe1VwY5eY0M2yaIAntpf4mFNCzVmp9NkGlnJUnLt/fCk/yUy?= =?us-ascii?Q?QH5zXlWdn10aTXHJWUcYY9DP+ANP4cxYg6kCuTTzFobUwfPX5ZPalWOICLju?= =?us-ascii?Q?ewYwSBWMl/p4W0xJ5CE0kHfNOgJXedjExoINm0KUcovJrC2ODHrEkmvEjXU3?= =?us-ascii?Q?TRlX2eKJFnk1fsQ3zhSr1HXdWN7h2L31dTh41F/vIsGiZLj9vOeIfy+uZVZF?= =?us-ascii?Q?gDOWaAHgXw1eaeRMiTYy1u3Q6okOj7Fgp7mA9jsePe+/mNwxtGdM+ykZ0C2R?= =?us-ascii?Q?eLTJgYS0VVUGcV/Ph1n4kDsh0dBHogUZpvK8UwkageVPAJHWyb/YiMupN3Qc?= =?us-ascii?Q?35dg5GuHI6JRXIjAW2bsanRMj8ENVqD8RT1Xs6ot/na5+h+g+WVS/ev6LoW+?= =?us-ascii?Q?c9YH5aVBdWW6+ZDgkiUuuybN3vu4xrskLXzxhy5sE8I7ScbzRf2a4vP8lfaW?= =?us-ascii?Q?MNPFLoqdhI4HvN0Qt2XtS/kA+IANIdBuoKa2Qg1/yZ/WUMRA2L1Nh5wuw2SH?= =?us-ascii?Q?ee7T2OlxRK6PALE3QIFwX+T9XQ+hR0s57u8+dqD5Bc5YblOZwS1HLXIR6LvS?= =?us-ascii?Q?hRb06Q/7QA/njs9VES4=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7f0a4b6-9920-4195-1190-08db4905a0ea X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2023 23:01:12.9432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gSGh5gs93kWmWsiRmyswfGfTbUstHzbWQYn2DRr4ZlUBnrGex5QPWGFEimC42Dzj X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8162 X-Rspam-User: X-Rspamd-Queue-Id: CE8CA1C0011 X-Rspamd-Server: rspam09 X-Stat-Signature: jnano8pq9jgt55pr5b5f3a74j15gso55 X-HE-Tag: 1682809275-832143 X-HE-Meta: U2FsdGVkX18rhCWxDyPi8vCyVpjoyVBBFqhllghVAdcXDdm4RZgMbErh8h2q0cNlQFRTrEB8xPVJmewI+c1IadJbJq/vAihHc7zUR4vAhqLupSerup9egcsCQEhgi1kwM+tsZCbdx640b4/6QZadqW2ktz74KIHcnxggVpya2JjIPRazDS5+HJXKk0w/mC0YVtYpsDOTfLqMIMNFOw/wij8hYhbyJd70kXAsftQRfEF8BRyoBu6eZ+g2bMlA6KyPdpoW47uy61LjNp7V/supSbJHInCYlKX8sAA4iefrbOkJiyu8MfU2StvtEiwgjTRvgW1e9+eEPv3nM8jctaw5Ug0ETKaKhvG6IXGO0t6QiGgJ+bh86ltJAR6OL24Vas77Gze4NVbQPfQaUPEThw8oyR7Qk/+UC3DSN2pGVge2D3R3YN4Yiw37zWXNteTRaXuGDmu0O5gVHfXA1Y3tiBClSa1EWbnjD2PF4D8B/vAe3sP02osdQ0r11M0ObsTMEN5rP5rebcSvhQF2/dgwlxsSj/FhsExtGkxfEt9n5BxdhaX+bjUExXF+WzL/0oTz0sIL5/GeumwTIimnOxnfZQ9gIw28g5ox3E3BX7ZiOuestywp9mRHXvxrRkwvAPbMa6BUK7zG39HVzCEl0CDS9hmn+eZnBTH513a0orw4y+1jRiyYOC0UHlspj5DVbQ5yhpe7E1iL9JC9ful3mK3WQmuC4EYXZBuMuP/Vxyeil9cwYu/t15k9WkgPDLdAEu6ny5UBu+L9KNR/ja8LRvzBBdy7iw0ZF0eyw/R3QER5Nn6zY1fm1Kli1PyTzDMpfAbQy3mYvkOGvTU/Uq1NwtqYm8mKH7MsRqTedxqMhM4YsLEv48LxC2fjNmRllA6JXQ0cDl+DoXsajJqt/iqiapBeegoVK872b7kPki0x7oSbMVyzM044UdOoczg4Eze5woU+MktQAcrRPK6GCRis84iXmkx tj/3TsHz 0tb7udwLTKOlW3LiJjrko4NARwqrm1uDkddNb8r6QFcl1Pq1im9MnQRh2jlEBRvI1QdcJB2Y7PY7cdWmPyoFdE8YJ5FaRMQoJyJIcPwfsRJimNow2J2Y5OmtSRDnbmBA8Nc2X1CutWwqzQoRwQ8ruVcKPPrco5scr6u+qOirevz7yCtSQGU+TiRXW8x8OPV01gbEttYUKGxvQPPXyVsBDmhG8pu0vcwowvTTVPiamE+FdlrZWrm3Kf8eje9j48cXsgB5fAZ/1Z0LdcvvgpnkI0z3ZtC0atrVnm2KS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 29, 2023 at 12:21:09AM -0400, Theodore Ts'o wrote: > In any case, the file system maintainers' position (mine and I doubt > Dave Chinner's position has changed) is that if you write to > file-backed mappings via GUP/RDMA/process_vm_writev, and it causes > silent data corruption, you get to keep both pieces, and don't go > looking for us for anything other than sympathy... This alone is enough reason to block it. I'm tired of this round and round and I think we should just say enough, the mm will work to enforce this view point. Files can only be written through PTEs. If this upsets people they can work on fixing it, but at least we don't have these kernel problems and inconsistencies to deal with. Jason