From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E818BC77B60 for ; Sat, 29 Apr 2023 22:35:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05A896B0071; Sat, 29 Apr 2023 18:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F25C66B0074; Sat, 29 Apr 2023 18:35:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC6A16B0075; Sat, 29 Apr 2023 18:35:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C99246B0071 for ; Sat, 29 Apr 2023 18:35:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 90BEE1A04EE for ; Sat, 29 Apr 2023 22:35:20 +0000 (UTC) X-FDA: 80735886000.22.C242958 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 891814000A for ; Sat, 29 Apr 2023 22:35:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D6Txqb4K; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682807718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XcdUan2iFHddXov9G7YJReB4CDdi1xu2/JAc2op9gvc=; b=bUnBOjH1pRnqH/WKP8H+O08obl8W9aw7KilpifBZ2m7nCR+G/1oZhbujWWNlUtwTXKiXcD NHY8ZuBJOyOv/Vo1N4Bx8wMSRVEloRQQiHMUpXXr4UaOie/FpEjbmGpd5CrlCCFHamHj/7 rAVNKP8udnRsTE5a0yJ2ocm1fbP68mI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D6Txqb4K; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682807718; a=rsa-sha256; cv=none; b=RqUcUXNd4hqdcqscdeJvqdvkCA9buTecYrX5bKHzyZvXCY9kMugz5pv8kk79uOxsGP1SKy x7e/rMis0BLz2ZB2RUHh5Palej19EZPyPiV00Yqbezo/Wy90inrdrB7Ka4iB0eYBi0Vf0J sfANlIJ+lMN0thVK2IwEGLMBHrqSUU4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XcdUan2iFHddXov9G7YJReB4CDdi1xu2/JAc2op9gvc=; b=D6Txqb4KfhGeB6vDcosqt8Ql4J YMPqGyndtMEeepL/OHW8flM+FQOeat0ydJLq3hSyyl/ZwaRcAiOYYmj4VqxhqTon0w6N4LhvRjbq7 kXm+eJPDx+n/poN0ktKAXPKg2NQuOf4la4J1mfLfHHbdoImHHri27ZP8vGQwyy79r4gPgDOy7sE0d DugsBnLUuErVDr+gapt1BQr3pwOiDVEFa+K1HPMW7dkjPpOhg8TYvJSuF1r0egow9A0g8BV9FvThM 35ZXx7tP6MwtsLjEQrD7LedlkqwrQiZCs1nuYnxu//hiaOnM07d/L+Gn1MILQLl7wLrj2hkBPieXe /tOiShNg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pst9n-005reF-4k; Sat, 29 Apr 2023 22:35:07 +0000 Date: Sat, 29 Apr 2023 23:35:07 +0100 From: Matthew Wilcox To: Yin Fengwei Cc: linux-mm@kvack.org, akpm@linux-foundation.org, kirill@shutemov.name, yuzhao@google.com, ryan.roberts@arm.com, ying.huang@intel.com Subject: Re: [PATCH v3 2/2] lru: allow large batched add large folio to lru list Message-ID: References: <20230429082759.1600796-1-fengwei.yin@intel.com> <20230429082759.1600796-3-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230429082759.1600796-3-fengwei.yin@intel.com> X-Stat-Signature: gjz1k5n1fw8qbx9iyf8yseza14cqyqho X-Rspam-User: X-Rspamd-Queue-Id: 891814000A X-Rspamd-Server: rspam06 X-HE-Tag: 1682807717-375936 X-HE-Meta: U2FsdGVkX1917GHAm/TAViTKse7R9ryRLNHGyCAf2onNa2Pn8QLTaeeAxEHrF9BRTgl8HjLspjDzvVs69J7jWLDI5qxPHdr+lm/cFE1gDvFb/ShjbYnBRLWWhRygAewPiyW64nKoLnadfH6ynqLvLChkpyN7YjDk9Sp9ybfgmAmKebH/5Kp6z28WrnPDTKV4sTlviVEvqLojyFLilBXJvj3x0vVUQOKbIJjr8zPNS0qT8HD7TWPIdxB7J1DX+ZG1kVoCwmLKfzTeKnKpnj/G2AQEQnO0WJqiiDAV7VPybqX5IF+6kXaXN1rAm0jujHPYBwzwHDEUa8UxKepqAdFkw4wNYa6xaQhNkJgXottwXzp0jI2l4GSPvXnrr1g0BwwAZNCuefElBLzhsflCc5JS6zdcsMgg2ezCdlS+vQH6dBNjS9JtYUrwhPZbmqGWu406UU4oV05yv/PLfnz1Srl1ETz4XI1kXjqu7i+3sFKnvfq1baFUTu8YlJdyUk7TBhvwd8L3gDzVn9GPsMU/TnLnFZXtWo4nG9Vrg8CN0JhTrgLzA9gZttFUbPqm8QTX/EigRZ/K6DoUyvzP8ZIE19JqUKWDKsNRlApjPD8uz4dEi+HgzHuIS86R7QY7zN0BV6edos0xyoHUgFpZgozHApaXAMjnqjVUYlhGVKQmNE6FFJhUv18jDpIPqDKowqk6dIRxC7OJArXh70W7gu35/Z0LVOuID4/nKr77LxbLK+TZYvKfEZEUhm6vwCaa+eexbqV7y5sknK9jRwSCDMqGcz/WUULMA89A6pe2WMc8wOlJQHY/ksLSwv/J30cQMbkUnAXySdqJCZXaKQhbAajL5GUvTsdHd3HC+Lrqej/qUDM60HFuT6tlkgVHDWvwS4yRrwUzzoDREbcXaJG8amzQYGhUQ6fDadrHihsW8a72I3/psGmtCz91Mtd1+f7o9gebOEALR+V/IxTo8N2mgGWmG7w 1OD4kZGt ZaDVKQjw7IhmeqKqbxMVuBLtSriGZCZCZw1IJd2HhB1uCvQwokCPwSMEh9teU+BSAYN/aLETrnxAKNm08KmhSkjqgJbeUdqRMzETyPnLTjCqwsW52IE/UvbmLC+rUZ7Wo0MpcnQzloFDHWw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 29, 2023 at 04:27:59PM +0800, Yin Fengwei wrote: > @@ -22,6 +23,7 @@ struct address_space; > struct pagevec { > unsigned char nr; > bool percpu_pvec_drained; > + unsigned short nr_pages; I still don't like storing nr_pages in the pagevec/folio_batch.