From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1B4C77B61 for ; Mon, 1 May 2023 17:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94615900004; Mon, 1 May 2023 13:12:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F5F2900002; Mon, 1 May 2023 13:12:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E4F6900004; Mon, 1 May 2023 13:12:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 71311900002 for ; Mon, 1 May 2023 13:12:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37F5640817 for ; Mon, 1 May 2023 17:12:18 +0000 (UTC) X-FDA: 80742329556.27.0187742 Received: from out-19.mta0.migadu.com (out-19.mta0.migadu.com [91.218.175.19]) by imf10.hostedemail.com (Postfix) with ESMTP id EDB83C0023 for ; Mon, 1 May 2023 17:12:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MPA5h7hp; spf=pass (imf10.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.19 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682961135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4x5T3Q/c5NLcOH8sHPSyYz1LAl/Oui3iWtz8Ou0TELA=; b=hybVo3mrBxSl7s3nR1jC7/KPia6fBOAzbGaU0Czm1PtSS6KuhkAxWBe7O3OmQre3ek/VRS tbO8SEvDorNSh7gM9m8WObYYaDSbA4s+mTer5o/ZmRyKfZyPPwoRhTTJFhfiXw8iVMI/WZ 1qKjXL/p0z21QX5qiG3S1FK2hTVWH6I= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MPA5h7hp; spf=pass (imf10.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.19 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682961135; a=rsa-sha256; cv=none; b=PchtJUmHdTEgtO0EYAn4eO12XoVeH726DypC8orCFF79WwQkU8Y0X47/c7Nv7G6iYDg74o JvzvOx3FWzAhrWuLE/4GY6UDKHwnSITcXWvIlofffKqSuW5eIunYKXh/VwZ72Ha/J/ihSr AxP0aoO4xCY47KJDsNYdetAxEGgC+uA= Date: Mon, 1 May 2023 10:12:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682961132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4x5T3Q/c5NLcOH8sHPSyYz1LAl/Oui3iWtz8Ou0TELA=; b=MPA5h7hprdGRBRt8GnzewCY3kfxDJs3GElH6DlWeWQOj/Nuh52+eTtuWim/0ItsFa5CP8X mzTumzR8D7IX2h/aspnXt96wTj8uF2HIFWhpxCG+2BLB349fL7uUM58pH4c5yXtEdYcNqd T1N707rA8SN2sJgM0UBiXc/tV1sDbno= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: "zhaoyang.huang" Cc: Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCH] mm: optimization on page allocation when CMA enabled Message-ID: References: <1682679641-13652-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1682679641-13652-1-git-send-email-zhaoyang.huang@unisoc.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EDB83C0023 X-Stat-Signature: ezj19bpymcdrwfne8zcob8hax4j31pxe X-Rspam-User: X-HE-Tag: 1682961134-116557 X-HE-Meta: U2FsdGVkX19KLqfQh3A8NoXPWgiMW9H7W7vhM17mfATBq9I14RbP3ZIKAjIdtoL8uBvh7hXxRSYL4Ht/H5TAC7D3a7j/klRxQYM+fZzGd5nz2rRzalyf6KDJgxWW3t6cGt8j6V9LtImIWpeyOvAnCbvcGybKcrAMYk5wFTl8H4aKZCa73qX1wJ5FkUlnrlhVUiQuU01XaRVa1MlY2JA5G27g5R+xwR3C/MkUz7ptTf8gs5iLN8g49yA93nlESK1PyOCzCEOc41nTT1pi0H3vsiFo0SSQ20f68PzZ/VrENAFViDkS4p4DzQa3uh8hv0/7+UtVSBUaZKl/dfAjOeq4Y2+YFb6n4G08dUgY9DSMxWlSsqOYIRlkzciwucgtWJW3DBAr781Bh2PCAHo7QZMAW1avOP+UNXY44xQEzK3BCmIK+apX8IxnVcNAcRiL1kwdq97cwQI6xomLCAy2ybPYGrwH9c8sguAFrYq5wsUpneE2afm5qY8YJxVBuPXPL0uiVVSd1P37RUJb208NH7JikcdpxWwYQQ+jbwlv3NX77xoIKj5SVRvAQAJnh9fY6gN7mOdi/Jl+u9w1WRnwfkbRs0/UzfMMZB/02Ol7IkO397j0mhzaCfFAsaEt0db/gwFlGxRyHMF68lXM7ZHqjhPGugQbLgUS3xpArCwvr6V6EwqS0cH8BHNQ72g2lTuMM7d4RoLddBomICYXIqXypBlfMW6t9TCXLUxlEk8A8fe9DayxqFmSmuOwzfT8Qtym2Wf1wu+xGTIJHQ9+JDgXqWeOFkykk5hHdijqozJpLbIZznvgnbiC2Z9DejqANM9XS5JcMyoV5JXCx1aRzB/QaZGKAjwm+0aSARqFNdf2kY2vccx4/3zksguv+cX4f1r9IgvI7NH8F/0wuq9cFE8Yg0zTIRcXNyQJR9bSNZruwI7TwFAdwdiRMdbEfa6LRQd1mab/rRoxeJqwj7WxR+RXDRr Wt3ftX9H zo6gvmEkR3bChFqeyA4+/dKGmnqwXl3lDePk+ndWx8RnNtwrdF2OMrNrfl/lanrLsGl5NaUensjgk7N/aezPVglhARGYjI9x3KzbVygkw1j+oww357i/H58QZQIsnX9YvaiZDXYtESD9D5BozDwe5TKwmPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zhaoyang! On Fri, Apr 28, 2023 at 07:00:41PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Please be notice bellowing typical scenario that commit 168676649 introduce, > that is, 12MB free cma pages 'help' GFP_MOVABLE to keep draining/fragmenting > U&R page blocks until they shrink to 12MB without enter slowpath which against > current reclaiming policy. This commit change the criteria from hard coded '1/2' > to watermark check which leave U&R free pages stay around WMARK_LOW when being > fallback. Can you, please, explain the problem you're solving in more details? If I understand your code correctly, you're effectively reducing the use of cma areas for movable allocations. Why it's good? Also, this is a hot path, please, make sure you're not adding much overhead. And please use scripts/checkpatch.pl next time, there are many code style issues. Thanks! > > DMA32 free:25900kB boost:0kB min:4176kB low:25856kB high:29516kB > > Signed-off-by: Zhaoyang Huang > --- > mm/page_alloc.c | 40 ++++++++++++++++++++++++++++++++++++---- > 1 file changed, 36 insertions(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0745aed..97768fe 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3071,6 +3071,39 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac, > > } > > +#ifdef CONFIG_CMA > +static bool __if_use_cma_first(struct zone *zone, unsigned int order, unsigned int alloc_flags) > +{ > + unsigned long cma_proportion = 0; > + unsigned long cma_free_proportion = 0; > + unsigned long watermark = 0; > + unsigned long wm_fact[ALLOC_WMARK_MASK] = {1, 1, 2}; > + long count = 0; > + bool cma_first = false; > + > + watermark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK); > + /*check if GFP_MOVABLE pass previous watermark check via the help of CMA*/ > + if (!zone_watermark_ok(zone, order, watermark, 0, alloc_flags & (~ALLOC_CMA))) > + { > + alloc_flags &= ALLOC_WMARK_MASK; > + /* WMARK_LOW failed lead to using cma first, this helps U&R stay > + * around low when being drained by GFP_MOVABLE > + */ > + if (alloc_flags <= ALLOC_WMARK_LOW) > + cma_first = true; > + /*check proportion for WMARK_HIGH*/ > + else { > + count = atomic_long_read(&zone->managed_pages); > + cma_proportion = zone->cma_pages * 100 / count; > + cma_free_proportion = zone_page_state(zone, NR_FREE_CMA_PAGES) * 100 > + / zone_page_state(zone, NR_FREE_PAGES); > + cma_first = (cma_free_proportion >= wm_fact[alloc_flags] * cma_proportion > + || cma_free_proportion >= 50); > + } > + } > + return cma_first; > +} > +#endif > /* > * Do the hard work of removing an element from the buddy allocator. > * Call me with the zone->lock already held. > @@ -3087,10 +3120,9 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac, > * allocating from CMA when over half of the zone's free memory > * is in the CMA area. > */ > - if (alloc_flags & ALLOC_CMA && > - zone_page_state(zone, NR_FREE_CMA_PAGES) > > - zone_page_state(zone, NR_FREE_PAGES) / 2) { > - page = __rmqueue_cma_fallback(zone, order); > + if (migratetype == MIGRATE_MOVABLE) { > + bool cma_first = __if_use_cma_first(zone, order, alloc_flags); > + page = cma_first ? __rmqueue_cma_fallback(zone, order) : NULL; > if (page) > return page; > } > -- > 1.9.1 > >