From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ADEC77B73 for ; Mon, 1 May 2023 17:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541E5900004; Mon, 1 May 2023 13:47:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F169900002; Mon, 1 May 2023 13:47:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B90F900004; Mon, 1 May 2023 13:47:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 28889900002 for ; Mon, 1 May 2023 13:47:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BCE101C72C9 for ; Mon, 1 May 2023 17:47:22 +0000 (UTC) X-FDA: 80742417924.05.5304CC2 Received: from out-29.mta1.migadu.com (out-29.mta1.migadu.com [95.215.58.29]) by imf06.hostedemail.com (Postfix) with ESMTP id D08D9180010 for ; Mon, 1 May 2023 17:47:20 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DiqG+Df4; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.29 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682963241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pCOJ4TIX11zw2jBaDOP97T7hx/pG0LP03OwHceiD+AE=; b=sR8LWEMx2uqFMPUDasDCJbaZ50ZagRklc2PchfCzaUWYeOPYkY9VTn5w0OUK+LhyY3KVda eG+atw8W469Be64RryHy1PihMpIKW1y0F6IdDQXEcv79UibhTsIWjRxRieKVh6OY5jIN7a YirbaYR0ax0ZpquH2r47n7AaJq8XCPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682963241; a=rsa-sha256; cv=none; b=w1pSohgDcCOUBL/59DC+wv6VtPj1YCbfuIHFNE/FC3xbT5S2bGTdid0dd9rdBTGcMJYvn4 9mIyKoFz7NcPMROOrhQaymLmk778jClSgEt6h+7UhUlcxpzSCJQJ7y57RsUdBnmixl9aM5 VWd+q7jc5/WR/G2vlccPGjrIkCe1S7s= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DiqG+Df4; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.29 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 1 May 2023 10:47:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682963238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pCOJ4TIX11zw2jBaDOP97T7hx/pG0LP03OwHceiD+AE=; b=DiqG+Df4D+DZsn0wO9LjwkV/mLuZ3abtM/u+Nuamt3enIlxM0dOl/zDiGUemCbI1ba6Ge7 UFxA8r7ovThZ0bL+PW2tO2CTjinF1Mnn4ax/lyq+OVwg8tX+hPdBw7CohOYds+psfqGMqa jFVVfskQ2Ze12DnahYd6juPiFkLzBag= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 00/40] Memory allocation profiling Message-ID: References: <20230501165450.15352-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501165450.15352-1-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: D08D9180010 X-Rspamd-Server: rspam09 X-Stat-Signature: 7pd4cepf9mxyq5353kkei31eexjxx9h6 X-HE-Tag: 1682963240-593964 X-HE-Meta: U2FsdGVkX18Rl6Hs1kuLv9wJTDH3yv2GRMFCT5fHef66QhenRwGSqRL3YINXfFkzLWGw68bFvaP7q2gnv62vdBdxw4mdXaSRnUow8mSReMec8pNEwNDCopAo5UvoBws0OFPW5VbU6TyN3e8QkEJH0JRCFSLjIKPNbuzNQen/4YrDJSikDFjVFdMIPUIvOOZG8pJMidgcL9ZCSRCg8SFJqkKzFbNUkt8Fj2OZEWN07YNQrlLsMM6vmf7XUtf0KE9kx16tfz7ziHu5nnOuDOPqSEqHML8Lc6YumgHcxtxYzEED5oerpW5zS8TLLT8gG/D0J8EjnnVyhNA4cngSJFVxyTikW08r3ZeQtQIyv1BoGieaCLIU28Dq56t1aRvlGNnzEId4EiP2jLrBqNOE2YpbY31Vz9sQsbkm901i0+hdtutgmRz/OvZSZHB7VSJqUD8H5PIV/HbaiPr+qsf/EJUrnZ0Fubv0D8GLsaFoW+6L141fJQp9SecRRA5AghfGh+tvwGH5RJ/0Pw+2KnaJ6pqyUJCtN5hsQeVl0AfkswOuEUxv1K0z9yiyUh/R/83En6TFSoq9a/OIDCHMSMG7vHtwq6d8ic3g+UrnPbRcMhlwSNKs77lgYmkveqYEflIN3jlyoqK6q7jw1DkSNFkBFAS642AXMeBCvFurUsUqOmFHpZw5ryQA18RuFeWspEQfLpbQfErhbaU45Jh4zRx1kiynd9xmrnQIyA8PmAlblJMPNR+X8wBvhYICT06iUzdCGyMttDYWTz7ZwPsfk/Xxg9G9LqcB0dxzFgEtWssM7FySYKCnw/kPCskbV7fIo3l9GGauZ8rbiS9Ij4aTRsE2n3t3SMypaI+hnQQP5Xyl7reGbqiyNfcRn3rarihhCONxPjDSvZcC1AIJTaO2VxqAKH5mDO8zWTGk65m3xKMcewWcgJzerUlPqJRU0gLBL6n7rjBKRDUcHC+sVcUqeSFBna7 DqvJv39i AmHBT4iz15NNDdUKzpB3iNLkyKWdVXMdOjduAlXbXOZGwsVXl42baB/4WthFV9ysfllIoRLufL5D7GA1OX9RbKmx+6Ip3QYTK/CuxHQ5RggJ7uJ1GMG5j9oLLkc9VmbAtqUWnyFbQSNCJ++GYS1aHRri/JQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 01, 2023 at 09:54:10AM -0700, Suren Baghdasaryan wrote: > Performance overhead: > To evaluate performance we implemented an in-kernel test executing > multiple get_free_page/free_page and kmalloc/kfree calls with allocation > sizes growing from 8 to 240 bytes with CPU frequency set to max and CPU > affinity set to a specific CPU to minimize the noise. Below is performance > comparison between the baseline kernel, profiling when enabled, profiling > when disabled (nomem_profiling=y) and (for comparison purposes) baseline > with CONFIG_MEMCG_KMEM enabled and allocations using __GFP_ACCOUNT: > > kmalloc pgalloc > Baseline (6.3-rc7) 9.200s 31.050s > profiling disabled 9.800 (+6.52%) 32.600 (+4.99%) > profiling enabled 12.500 (+35.87%) 39.010 (+25.60%) > memcg_kmem enabled 41.400 (+350.00%) 70.600 (+127.38%) Hm, this makes me think we have a regression with memcg_kmem in one of the recent releases. When I measured it a couple of years ago, the overhead was definitely within 100%. Do you understand what makes the your profiling drastically faster than kmem? Thanks!